Skip to content

Comments

Fix #10261 ページのUIを差し替えるプラグインAPIを追加#10323

Merged
syuilo merged 2 commits intodevelopfrom
unknown repository
Mar 15, 2023
Lines changed: 34 additions & 3 deletions
Merged

Fix #10261 ページのUIを差し替えるプラグインAPIを追加#10323
syuilo merged 2 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 13, 2023

What

ページのUIを差し替えるプラグインAPIPlugin:register_page_view_interruptorを追加しました。
基本的な動作はノート向けのPlugin:register_note_view_interruptorと同様です。

Why

機能追加の背景については #10261 に記載しております。

Additional info (optional)

ローカル環境での動作テストを行っております。

テスト用のノートの例は以下になります。セクションの入れ子でも動作することは確認済みです。
image

テスト用のプラグインスクリプトは以下になります。
https://novelskey.tarbin.net/@tar_bin/pages/1678732562011

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Sorry, something went wrong.

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #10323 (eded78f) into develop (c05c504) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10323   +/-   ##
========================================
  Coverage    74.41%   74.41%           
========================================
  Files          872      872           
  Lines        85156    85156           
  Branches      5599     5598    -1     
========================================
+ Hits         63367    63368    +1     
+ Misses       21789    21788    -1     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost
Copy link
Author

ghost commented Mar 13, 2023

すみません、なにかテスト失敗しているようですがおそらくこの変更の影響ではなさそうですかね・・・?

FAIL test/e2e/streaming.ts (87.051 s, 689 MB heap size)
  ● Streaming › Streaming › Hashtag Timeline › 指定したハッシュタグの投稿が流れる (OR)

    QueryFailedError: duplicate key value violates unique constraint "IDX_347fec870eafea7b26c8a73bac"

      at PostgresQueryRunner.query (../../node_modules/.pnpm/typeorm@0.3.11_ioredis@4.28.5+pg@8.10.0/src/driver/postgres/PostgresQueryRunner.ts:299:19)
      at InsertQueryBuilder.execute (../../node_modules/.pnpm/typeorm@0.3.11_ioredis@4.28.5+pg@8.10.0/src/query-builder/InsertQueryBuilder.ts:163:33)

@syuilo syuilo merged commit 42833cd into misskey-dev:develop Mar 15, 2023
@syuilo
Copy link
Member

syuilo commented Mar 15, 2023

👍🏻

@ghost ghost deleted the fix_10261_add_plugin_register_page_view_interruptor branch March 15, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants