-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
|
Deploy preview for web-dev-staging ready! Built with commit 21dcff6 |
|
Yes, @jpmedley is already reviewing the doc. |
45e51b6 to
effe980
Compare
jpmedley
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more typos.
|
@jpmedley Resolved all issues but not sure how to dismiss "Changes requested" by you. |
|
I have to approve it. |
|
@kaycebasques These are things I should have found on the first review. Since none of these change words, would you mind merging these for me? Then we can finish this today. |
|
@jpmedley Merged the suggested changes. One you LGTM, we should be good to go. |
kaycebasques
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll use the Commit Suggestion UI to commit these changes myself. I'm also going to check if the images can be optimized (to keep the repository size at a minimum). Then I'll merge.
|
I need @jpmedley's approval to merge this. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I rebased locally, but might have messed up 🙄 |
Co-Authored-By: Joe Medley <jmedley@google.com>
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
We'll start working on it after we post this. cc: @jpmedley when do you think you can start working on the other half?
It's my bad. This should have been sorted already. |
|
Looks good to me now. Thanks! |
kaycebasques
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can commit these suggestions myself. I think the new hero image needs to be optimized. I'll do that, too.
Fixes #2328