Skip to content
/ Recaf Public

Unable to auto patch recaf on JDK 12 #132

New issue
New issue
Closed
Closed
Unable to auto patch recaf on JDK 12#132
Labels
bugYup, thats broken
@artemking4

Description

@artemking4
artemking4
opened on Jun 15, 2019

Auto patch in recaf just gives me a error

C:\Program Files\Java\jdk-12.0.1\bin>java.exe -jar recaf.jar Detected JDK 11+ without OpenJFX dependencies Dependencies will be downloaded and Recaf will restart... java.util.UnknownFormatConversionException: Conversion = 'F' at java.base/java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2839) at java.base/java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2865) at java.base/java.util.Formatter.parse(Formatter.java:2713) at java.base/java.util.Formatter.format(Formatter.java:2655) at java.base/java.util.Formatter.format(Formatter.java:2609) at java.base/java.lang.String.format(String.java:2988) at me.coley.recaf.util.Updater.generatePatched(Updater.java:145) at me.coley.recaf.util.Updater.updateViaJdk11Patch(Updater.java:107) at me.coley.recaf.util.Dependencies.check(Dependencies.java:49) at me.coley.recaf.Recaf.main(Recaf.java:13) java.util.UnknownFormatConversionException: Conversion = 'F'

Activity

Col-E
added
bugYup, thats broken
on Jun 15, 2019
Col-E

Col-E commented on Jun 15, 2019

@Col-E
Col-E
on Jun 15, 2019 · edited by Col-E
Owner

Can you try again using this? This build should include some more useful debug information. I can't reproduce this on my own machine.

recaf-1.15.1-debug.jar.zip

In the meantime if you download the source code and compile via mvn package it will generate a proper JDK 11+ compliant jar.

artemking4

artemking4 commented on Jun 16, 2019

@artemking4
artemking4
on Jun 16, 2019
Author

So i have ran this file as admin in javaw.exe and i see that it only made a file called recaf-1.15.1-patched.jar. But it is empty

Col-E

Col-E commented on Jun 16, 2019

@Col-E
Col-E
on Jun 16, 2019 · edited by Col-E
Owner

But can you please tell me what the console logs said? Using java.exe not javaw.exe. Running as admin is not going to change the behavior. The debug jar has additional logging in the hopes that I can figure out why it crashes for you and not me.

Nevermind, I found out why this occurs. I'll fix it shortly.

Col-E
closed this as completedin 68ae1ceon Jun 16, 2019
Col-E

Col-E commented on Jun 16, 2019

@Col-E
Col-E
on Jun 16, 2019
Owner

You probably ran Recaf in working-directory that had a space or some special character in it. Then because of URL encoding Recaf failed to use the path in String.format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugYup, thats broken

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @artemking4@Col-E

        Issue actions