Skip to content

Conversation

@mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Oct 4, 2024

Problem

The node-js fetch function didn't validate DNS records for each hop of a redirect.

Production uses a rust based system instead which does not appear to be affected.

Changes

Provide a custom DNS lookup function to node-fetch.

How did you test this code?

I made a fetch request locally to a URL that redirects, and saw the lookup function called twice.

@mariusandra mariusandra merged commit 6e8f035 into master Oct 4, 2024
@mariusandra mariusandra deleted the static-lookup-per-hop branch October 4, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants