Skip to content

A library mod #3

@Nek

Description

@Nek

Hello.
Thanks for the great library! I'm using a heavily modified version of it in my own lib https://github.com/cljs-audio/cljs-audio/tree/master/src/main/cljs_audio/workers.
I've changed the code to use transit for data serialization/deserialization. I'd be glad (and I'm obliged) to credit you, but not sure how. I can also extract the code and create a PR if this is something you'd like.

Activity

jtkDvlp

jtkDvlp commented on Nov 1, 2021

@jtkDvlp
Owner

Hi @Nek,
thank you for you support.

Thanks for the great library! I'm using a heavily modified version of it in my own lib https://github.com/cljs-audio/cljs-audio/tree/master/src/main/cljs_audio/workers.

Cool 👍

I'd be glad (and I'm obliged) to credit you, but not sure how.

These days there is no way to credit me, but that triggered me to look into a support option.

I've changed the code to use transit for data serialization/deserialization. ... I can also extract the code and create a PR if this is something you'd like.

PRs are always welcomed. I took a look into your changes. What was your reason to use a string based format (transit) for data transfer? I see problems at least for "transfered" data switching the monitoring thread. I would guess it cant work this way with transit, do you tested it?

Best regards
Julian

Nek

Nek commented on Nov 5, 2021

@Nek
Author

Hey @jtkDvlp ,
I have to say my reason was pretty simple, it fixed the problems with deeply nested data structures, and it worked. I didn't think thoroughly about the benefits and drawbacks of my specific solution. So, no, haven't tried any other way, but yes, you are right about the thread switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Nek@jtkDvlp

        Issue actions