Skip to content

Conversation

@EvilOlaf
Copy link
Member

Description

  • bump edge to 6.17.y
  • rewrite kernel config

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Oct 28, 2025
@EvilOlaf
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

This pull request updates the BCM2711 edge kernel from version 6.16 to 6.17, with accompanying kernel configuration adjustments. The kernel config file changes include modifications to Netfilter target configurations (adding CT, HL, NAT, NETMAP, REDIRECT, MASQUERADE targets), wireless driver entries (ATH10K, ATH11K, ATH12K series), sound codec drivers (Realtek, Cirrus, CS8409, HDMI variants), and RTC drivers (PCF85063). The version metadata in the family configuration file reflects the kernel branch upgrade from rpi-6.16.y to rpi-6.17.y.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Kernel configuration symbol changes are repetitive in nature across Netfilter, wireless, and audio/RTC subsystems
  • Version metadata updates are straightforward
  • No logic changes or code implementation modifications present
  • Changes follow consistent patterns (adding/removing configuration options)

Possibly related PRs

Suggested labels

Patches, Build

Suggested reviewers

  • PanderMusubi
  • igorpecovnik
  • teknoid

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "rpi maint: bump edge to 6.17.y" directly and clearly describes the primary change in the changeset: updating the edge kernel version from 6.16 to 6.17.y for the bcm2711 (Raspberry Pi) platform. The title is concise, specific, and avoids vague terminology. While the changeset also includes a kernel config rewrite, the title appropriately focuses on the main version bump objective, which is the most significant and actionable piece of information for developers reviewing the history. The title provides sufficient context for quick understanding without noise or emojis.
Description Check ✅ Passed The pull request description is clearly related to the changeset, explicitly stating both main objectives: bumping edge to 6.17.y and rewriting the kernel config. These align directly with the changes shown in the raw summary. The description further provides testing details (boot tests on rpi5 and rpi4b with log references) and references to tracking systems, demonstrating that the author provided context related to the actual changes. The description is not vague, generic, or off-topic; it meaningfully describes what was changed and how it was validated.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc3d3c9 and 1081108.

📒 Files selected for processing (2)
  • config/kernel/linux-bcm2711-edge.config (5 hunks)
  • config/sources/families/bcm2711.conf (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-23T19:50:25.841Z
Learnt from: igorpecovnik
PR: armbian/build#8812
File: config/kernel/linux-rockchip-edge.config:730-733
Timestamp: 2025-10-23T19:50:25.841Z
Learning: For ATH12K wireless driver configuration: only CONFIG_ATH12K=m needs to be explicitly set in kernel config files. The kernel build system automatically selects CONFIG_ATH12K_PCI when both CONFIG_ATH12K and CONFIG_PCI are enabled. This pattern is consistent across all Armbian edge kernel configs. CONFIG_ATH12K_PCI does not need to be explicitly added to config files.

Applied to files:

  • config/kernel/linux-bcm2711-edge.config
📚 Learning: 2025-10-23T19:48:42.980Z
Learnt from: igorpecovnik
PR: armbian/build#8812
File: config/kernel/linux-sm8250-edge.config:498-501
Timestamp: 2025-10-23T19:48:42.980Z
Learning: For Armbian EDGE kernel configs, CONFIG_ATH12K=m alone is sufficient for PCI-based Wi-Fi 7 devices (e.g., WCN785x/QCN9274). A separate CONFIG_ATH12K_PCI option is not required, as confirmed by maintainer testing.

Applied to files:

  • config/kernel/linux-bcm2711-edge.config
🔇 Additional comments (6)
config/kernel/linux-bcm2711-edge.config (5)

219-232: LGTM! Netfilter configuration updates are appropriate.

The addition of Netfilter target modules (CT, HL, NAT, NETMAP, REDIRECT, MASQUERADE) is consistent with kernel 6.17 updates and provides enhanced network filtering capabilities.


701-708: LGTM! Wireless driver configuration aligns with best practices.

The ATH wireless driver configuration is correct:

  • ATH10K and ATH11K drivers include explicit PCI/AHB/SDIO/USB variants
  • ATH12K is configured with only CONFIG_ATH12K=m, which is sufficient as the kernel build system automatically handles PCI selection when both ATH12K and PCI are enabled

This provides Wi-Fi 6E/7 support for the platform.

Based on learnings


1409-1412: LGTM! Sound codec additions enhance audio hardware support.

The HDA codec modules (Realtek, Cirrus Logic, CS8409, HDMI) provide comprehensive audio hardware support and are appropriately configured as loadable modules.


1846-1846: LGTM! RTC driver addition is appropriate.

The PCF85063 RTC driver module provides support for a commonly used I2C real-time clock chip.


2392-2392: LGTM! Test module addition is appropriate for edge kernel.

The TEST_MEMCAT_P module is a kernel self-test for the memcat_p function. Including it in the edge kernel config is reasonable for validation purposes and won't impact normal operation since it's a loadable module.

config/sources/families/bcm2711.conf (1)

40-41: LGTM! Kernel version bump is verified and correct.

The edge kernel bump from 6.16 to 6.17 is correctly applied to both KERNEL_MAJOR_MINOR and KERNELBRANCH. The upstream rpi-6.17.y branch exists in the Raspberry Pi Linux repository, confirming the configuration is valid.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • AR-9999: Request failed with status code 404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sorry, something went wrong.

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 28, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 28, 2025
@igorpecovnik igorpecovnik merged commit f2c9081 into armbian:main Oct 28, 2025
11 checks passed
@EvilOlaf EvilOlaf deleted the rpi branch October 28, 2025 11:47
@coderabbitai coderabbitai bot mentioned this pull request Oct 29, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

None yet

3 participants