Resize unattended video if zoom factor >1

[Vilsol]

Make it possible to resize the video even in unattended mode.

[Vilsol]

@vadosnaprimer I am sorry that you have to resort to personal attacks. As a third-party contributor, my job is to propose changes to the repository. Then it is the job of the core contributors to review whether that change is valid and will not cause issues with other use-cases. My PR was pulled and merged without question or comment. If you expect all of your third-party contributors to know your codebase by heart, I don't see anyone wanting to be insulted for trying to better the community and software.

[zeromus]

how do you know he wasn't talking to me?
target zoom factor is the client window size. it has nothing to do with dumping. if you want your video scaled, bizhawk is the wrong place to be doing it. do it in postprocessing.

[Vilsol]

I assumed that because the comment was on my commit with no additional tags to any other person, it would be relating to me. I apologize for any trouble I caused and I won't be causing any more.

[zeromus]

you're too sensitive. I caused the trouble by merging the commit.

[vadosnaprimer]

@Vilsol apologies accepted. Sorry but it wasn't possible to react in a better way (see here why). You're probably entirely new to coding, in which case it's better to just make an issue and ask something. The option you want is 2x window size + capture OSD enabled (make sure to disable all the actual HUD you don't want). This will result in a dump at whatever the size of the client area is.

[vadosnaprimer]

LOL, downvoted for telling how to do the scaling, what a petty flashmob. How about posting any sensible arguments instead?

[nickrobson]

@vadosnaprimer wrote:
You have absolutely no idea what Global.Config.TargetZoomFactor is, do you.

This sort of language is directly in violation of the GitHub Terms of Service:

2. Content Restrictions

You agree that you will not under any circumstances upload, post, host, or transmit any content that:

• ...
• is libelous, defamatory, or fraudulent;
• is discriminatory or abusive toward any individual or group;
• ...

3. Conduct Restrictions

While using GitHub, you agree that you will not under any circumstances:

• harass, abuse, threaten, or incite violence towards any individual or group, including GitHub employees, officers, and agents, or other GitHub Users;
• ...

Perhaps it would be wise for you to consider re-reading them – I believe it would be totally within my rights to report you for such behaviour and attitude should you continue.

This sort of toxic behaviour, as described by @Vilsol, is disappointing to see on the issue tracker of a reasonably popular piece of software. Perhaps it is why there is a disproportionate number of issues to pull requests on this repository – 196 to 6 (~33:1) at the time of writing – significantly higher than most popular repositories marko has 105-6 (~18:1) and angular has 2230-367 (~6:1).

---

@vadosnaprimer wrote:
@Vilsol apologies accepted. Sorry but it wasn't possible to react in a better way (see here why). You're probably entirely new to coding, in which case it's better to just make an issue and ask something. The option you want is 2x window size + capture OSD enabled (make sure to disable all the actual HUD you don't want). This will result in a dump at whatever the size of the client area is.

A simple check of his GitHub page is enough to confirm that he is not new to it at all – his first commits on GitHub were in December, 2013. Perhaps you could make at least some effort to confirm your opinions before judging others.

While it is good that you gave the settings required to perform the scaling in the end, you could have closed the PR with that message. Perhaps consider ensuring your community managers (those with the power to merge) are up-to-date with knowledge of the codebase, or move them to only be reviewing PRs, so that you have the final say on matters. Wrongly-merged PRs should not at all be portrayed as the fault of the PR creator(s).

[zeromus]

Wow, he wasn't kidding about the flashmob. Now we've attracted a visiting lecturer.

[vadosnaprimer]

libelous, defamatory, or fraudulent
discriminatory or abusive
harass, abuse, threaten, or incite violence

@nickrobson please link me to the actual definitions of those terms that you used when deciding that anything I said matches them. Or will I be reported for asking that too?

[nickrobson]

@vadosnaprimer wrote:
@nickrobson please link me to the actual definitions of those terms that you used when deciding that anything I said matches them. Or will I be reported for asking that too?

You should be able to find sufficient definitions in your English dictionary of choice. 🙂