Skip to content

Rename downloaded pages if the file name exists #2078

New issue
New issue
Open
Open
Rename downloaded pages if the file name exists#2078
Assignees
VishalNehra
Labels
Area-FileOperationsRelated to file operations (e.g. moving, copying, renaming).Issue-FeatureA feature request or improvement.
Milestone
v4.0
@HT-7

Description

@HT-7
HT-7
opened on Nov 9, 2020

Is your feature request related to a problem? Please describe.
While I like the feature which allows downloading pages when sending URLs to it, it has one problem:

When downloading the page a second time (i.e. because it has updated), then the existing HTML file will be overwritten.

Overwriting by default is a poor behaviour (not programmer's fault but default in UNIX, as far as I know, thus only a result of neglect), which has caused me to lose my backed up log by 3C Battery Monitor Widget (file name: bmw_history.txt).

Describe the solution you'd like
If the file name exists, rename the new files to example(1).html, example(2).html , and continuing.

Describe alternatives you've considered
Google Chrome for Android allows MHTML downloading, but not in Incognito mode.

Mozilla Firefox for Android allows PDF downloading, but PDF is not quite a website format (better than nothing, obviously).

Activity

HT-7

HT-7 commented on Nov 9, 2020

@HT-7
HT-7
on Nov 9, 2020
Author

Side note: Yes, I could indeed rename the existing HTML file in advance, but doing that every single time is inconvenient. And one could forget to do it.

EmmanuelMess
added
Issue-FeatureA feature request or improvement.
Area-FileOperationsRelated to file operations (e.g. moving, copying, renaming).
on Nov 9, 2020
EmmanuelMess

EmmanuelMess commented on Nov 9, 2020

@EmmanuelMess
EmmanuelMess
on Nov 9, 2020
Member

We should add a dialog to put in a new name.

TranceLove

TranceLove commented on Nov 9, 2020

@TranceLove
TranceLove
on Nov 9, 2020 · edited by TranceLove
Collaborator

I wonder if there's a library handle all this naming stuff?

VishalNehra

VishalNehra commented on Nov 9, 2020

@VishalNehra
VishalNehra
on Nov 9, 2020
Member

Edit: maybe use the same dialog which we use when copying existing file. We already have it to handle Overwrite / skip actions. We can add one more action to Rename it to (1) or (2) instead. It'll help in copy / cut scenario as well.
Let me pick this up.
@TranceLove i don't think we need a library for this. Should be straightforward.

VishalNehra

VishalNehra commented on Nov 9, 2020

@VishalNehra
VishalNehra
on Nov 9, 2020
Member

Possible duplicate #1589

VishalNehra

VishalNehra commented on Nov 9, 2020

@VishalNehra
VishalNehra
on Nov 9, 2020
Member

Duplicate #1366
Related #721
Will pick this and close all the issues.

VishalNehra
added
Duplicate
on Nov 9, 2020
VishalNehra
self-assigned this
on Nov 9, 2020
VishalNehra
added this to the v3.5 milestone on Nov 9, 2020
EmmanuelMess

EmmanuelMess commented on Nov 10, 2020

@EmmanuelMess
EmmanuelMess
on Nov 10, 2020
Member

v3.5 milestone? It should be at least 3.6 this is not a bug.

VishalNehra
modified the milestones: v3.5, v3.6 on Nov 10, 2020
HT-7
mentioned this on Nov 15, 2020

14 remaining items

TranceLove
added 10 commits that reference this issue on Aug 11, 2023

[WIP] Fixes TeamAmaze#2078

175d712

[WIP] Fixes TeamAmaze#2078

3404a62

[WIP] Fixes TeamAmaze#2078

3bd2b81

[WIP] Fixes TeamAmaze#2078

5aa8a1f

[WIP] Fixes TeamAmaze#2078

a824da8

[WIP] Fixes TeamAmaze#2078

f3d044e

[WIP] Fixes TeamAmaze#2078

b84d9a5

[WIP] Fixes TeamAmaze#2078

1ad7ab1

Implement filename renaming library

e0b6fdd

Implement filename renaming library

072355e
TranceLove
mentioned this on Aug 19, 2023
TranceLove
added 2 commits that reference this issue on Aug 19, 2023

Implement filename renaming library

e1c2ad9

Implement filename renaming library

e039abf
VishalNehra
modified the milestones: v3.9, v4.0 on Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-FileOperationsRelated to file operations (e.g. moving, copying, renaming).Issue-FeatureA feature request or improvement.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @TranceLove@VishalNehra@EmmanuelMess@HT-7

      Issue actions
        Rename downloaded pages if the file name exists · Issue #2078 · TeamAmaze/AmazeFileManager