Status Update
Comments
ft...@chromium.org <ft...@chromium.org> #2
ft...@chromium.org <ft...@chromium.org> #3
ft...@chromium.org <ft...@chromium.org> #4
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
commit dfa3dfa3b5351f13efc942f51e73d333c2bbca3c
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 10 19:29:43 2021
[Temporal] Add some tests for Temporal.Calendar
All marked as FAIL at this stage.
Bug: v8:11544
Change-Id: I6e4346a57aa3df054d2ef5bd353544fba7fd855b
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76211}
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6
commit e28be66ffd8923259e06e830643fbb1a3fffaff5
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 26 15:03:59 2021
[Temporal] Preparation refactorying
Move MakeDate/MakeTime/MakeDay to src/date/date.h so
we can reuse it to implement the GetEpochFromISOParts AO in
Temporal soon after.
See
Bug: v8:11544
Change-Id: Ie48bf06670a9cae660864d66729b46f4c71e4fd1
Reviewed-on:
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76513}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7
commit a91a6e1a2316a72881f89240b0a04bd2f0e014b5
Author: Frank Tang <ftang@chromium.org>
Date: Fri Aug 27 06:07:53 2021
[Temporal] Add some tests for Duration
Land some of the tests for Temporal.Duration
All marked as FAIL at this stage.
Bug: v8:11544
Change-Id: I4696edee7a2345133ed13c25aa720febe1f8fc69
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76524}
[modify]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8
commit 7d729e85b621d41cf2496e0214fe503db9470915
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 28 04:48:35 2021
[Temporal] Add some tests for Instant
Land some of the tests for Temporal.Instant
All marked as FAIL at this stage.
Bug: v8:11544
Change-Id: I79d14df47248c708e5d73a0e00e3f7973c521d16
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76550}
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9
commit d61809bb4162851827776799f9061309fd78cdf1
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 28 05:00:41 2021
[Temporal] Add some tests for PlainDate
Land some of the tests for Temporal.PlainDate
All marked as FAIL at this stage.
Bug: v8:11544
Change-Id: I004b7cb34effe1de1735b61c7ac749ae3c8e9bf7
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76551}
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10
commit 4613e86e034c008d71b254035c31057251b017f0
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 07 17:13:14 2021
[test262] Roll test262
Bug: v8:7834, v8:12167, v8:12168, v8:11544
Change-Id: I1cebc0a82cced63fbf9ec46111825f22ac01eeeb
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76710}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11
commit 0adc1410b1dae42b135b613ed86c18edafc83e3a
Author: Frank Tang <ftang@chromium.org>
Date: Mon Sep 13 22:54:48 2021
[Temporal] Part 1 - Skeleton
1. Expose all the functions to empty buildins.
2. Wire up basic structure of classes and internal slots.
Design Doc:
This is just a CL to establish a skeleton for Temporal.
The Temporal is very big. The prototype CL is in
but too big to be reviewed so I break up the basic structure here first.
Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel
Bug: v8:11544
Change-Id: I10d09e3c2530e5b1a6ba60014a2294e138879ff3
Reviewed-on:
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76819}
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #12
commit f1a5b680dbdafbc5ffdb678d1f683f0b50c298cc
Author: Deepti Gandluri <gdeepti@chromium.org>
Date: Tue Sep 14 17:57:55 2021
Revert "[Temporal] Part 1 - Skeleton"
This reverts commit 0adc1410b1dae42b135b613ed86c18edafc83e3a.
Reason for revert: Reverting due to fail on V8 Linux - noi18n - debug
Original change's description:
Bug: v8:11544
Change-Id: I358f671452a986c8e87d1f831ab5eb1550a38441
Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Auto-Submit: Deepti Gandluri <gdeepti@chromium.org>
Owners-Override: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76821}
[modify]
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[delete]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13
commit 1733097759bacf1aa9ee86097632892dc79ce370
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 07 18:30:55 2021
[Temporal] Preparation Refactor 2
Refactor generic option reading facility also used
by Temporal from intl-objects.* to option-util.*
See
Bug: v8:11544
Change-Id: I8b27e8fa3515c1287217c2fbe225172fb8f69210
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76824}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14
commit bb500e63ff708ecb409bfba1898f6d64b93239f1
Author: Frank Tang <ftang@chromium.org>
Date: Wed Oct 06 05:25:09 2021
[test262] Roll test262
Bug: v8:7834, v8:12288, v8:11544, v8:11989
Change-Id: Ie7c799f1c757554bd66619fe65433921d4419d52
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77270}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #15
commit 77e713f5337adcbd082ce14af906595a7c8a8c71
Author: Frank Tang <ftang@chromium.org>
Date: Thu Oct 07 21:22:29 2021
Reland "[Temporal] Part 1 - Skeleton"
This is a reland of 0adc1410b1dae42b135b613ed86c18edafc83e3a
1. Fork out test/mjsunit/temporal/function-exist.js test
to test/mjsunit/temporal/function-exist-no-i18n.js and mark
function-exist FAIL in no_i18n build.
Original change's description:
Bug: v8:11544
Change-Id: I60eaface94ba9b3408cb235cd1ae425151a36732
Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel
Reviewed-on:
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77303}
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[add]
[modify]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #16
commit 790d55486bb515184db3570db4ebbd8b84dcd0df
Author: Frank Tang <ftang@chromium.org>
Date: Tue Oct 12 08:14:03 2021
[Temporal] Add some tests for PlainDateTime
Land some of the tests for Temporal.PlainDateTime
All marked as FAIL at this stage.
Bug: v8:11544
Change-Id: I09bf681e61f19d96607c848ddcb6bee06580aff1
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77332}
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17
commit 8cb0a45a65e533fca454575f4cd2b086cc6f3388
Author: Frank Tang <ftang@chromium.org>
Date: Tue Nov 23 22:03:51 2021
[Temporal] Part 2.1 Add TemporalParser to parse ISO8601
Parser based on
Bug: v8:11544
Change-Id: I18eafc86da86005d5aee7b672c145fcf38a3ef5e
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78049}
[add]
[add]
[add]
[modify]
[modify]
[modify]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18
commit 69608fc76dbcb5a7127ceb3382e8a8e3d27d6ce3
Author: Frank Tang <ftang@chromium.org>
Date: Fri Dec 03 07:25:44 2021
[Temporal] Sync Parser to pull/1950
Sync the parser to grammar change in
Bug: v8:11544
Change-Id: I57e9f9c2bd234f930cc06dd730ad4ccf77d239d0
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78233}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #19
commit 40deaa176848765068c55ba22bab0902ed601adf
Author: Frank Tang <ftang@chromium.org>
Date: Mon Dec 06 19:50:27 2021
[temporal] Sync parser change in PR1957
Resolve
Bug: v8:11544
Change-Id: I50d406848e815b400d6e0cd14dee95589aac0647
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78263}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #20
commit f811e8926966b5568a4dd6f28037bc53a9e53a71
Author: Frank Tang <ftang@chromium.org>
Date: Thu Jan 06 03:32:26 2022
[Temporal] Part2 Add constructor and simple getters.
Bug: v8:11544
Change-Id: I3206ca3e0c505b14e4497ccb2af25a31940a1c1e
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78518}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #21
commit 470bebc2b9c68c252d338a6b37c9246a2b5eb6a3
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jan 11 04:57:16 2022
[Temporal] Implement Temporal.*.prototype.valueOf
Bug: v8:11544
Change-Id: If0a6eeb6591538a969efaac9d148d019300b4113
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78555}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #22
commit c4ebb5dc5011548ebd1a666ea6cc83e9778dea6a
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jan 11 07:02:23 2022
[Temporal] Implement simple getters
get Temporal.*.prototype.(calendar|timeZone|epochNanoseconds)
Bug: v8:11544
Change-Id: Iede568431847f1413e018ab0766cd74f3eeafc66
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78574}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #23
commit 8dfe2d41564edc7e311fb2b0f49f333b363a35f6
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jan 12 23:33:55 2022
[Temporal] Remove unnecessary -0 code
Bug: v8:11544
Change-Id: I1f8fa01ece950addac048c5ae94d8c961666f720
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78594}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #24
commit f61ac65e95dbb085f40e1eaf5a034045e6a727ba
Author: Frank Tang <ftang@chromium.org>
Date: Fri Jan 14 05:37:13 2022
[Temporal] Implement getter with division
get Temporal.*.prototype.epoch(Millis|Micros|S)econds)
Bug: v8:11544
Change-Id: I97d7560f386666fb4bff84b97de9927769e6ca04
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78617}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #25
commit 261ad0d5c2abcfdcb25b261a8a04ca7691e2d96d
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jan 19 03:26:59 2022
[Temporal] Implement getters which forward to timeZone
get Temporal.ZonedDateTime.prototype.(hour|minute|*second)
Bug: v8:11544
Change-Id: I5f3d20f371db4898365876483c49df73d96f3728
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78674}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #26
commit a141d2a58d809aea958750c3cf4199a821983e76
Author: Frank Tang <ftang@chromium.org>
Date: Thu Feb 03 21:42:33 2022
[Temporal] Add Temporal.*.prototype.withCalendar
Bug: v8:11544
Change-Id: I59e5a448385b2e67927c18c9609f24f4d66f3756
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78933}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #27
commit c705272afe721bc39d3beb24fd85c99ae8135405
Author: Frank Tang <ftang@chromium.org>
Date: Thu Feb 03 23:50:49 2022
[Temporal] Add ZonedDateTime withTimeZone
Bug: v8:11544
Change-Id: I72e005c0937418f4160e763edc4fd2b81b14b9c0
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78966}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #28
commit 1288650e4e82ae0dda68bafc8c36736ba7685866
Author: Frank Tang <ftang@chromium.org>
Date: Sat Feb 05 03:39:51 2022
[Temporal] Implement Temporal int getters
get Temporal.Plain*Time.prototype.(hour|minute|*second)
Bug: v8:11544
Change-Id: I6de1304c1a920f8047d499e4e6dcedbd72ba07f7
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78967}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #29
commit 40b099e38f5532d8b38f1bf01237bb26d0952183
Author: Frank Tang <ftang@chromium.org>
Date: Sat Feb 05 05:07:01 2022
[Temporal] Add Temporal.(Calendar|TimeZone).from
Bug: v8:11544
Change-Id: Iab90377372dcd97f1919fde1d886dfe67b336198
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78968}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #30
commit 2144c5357a94bdb833940db4b011060b33b8a5ab
Author: Frank Tang <ftang@chromium.org>
Date: Thu Feb 24 02:38:58 2022
[Temporal] Implement Temporal.Now.*
Bug: v8:11544
Change-Id: I5dda2845618cc7c709fb9ddac337472e112407e4
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79359}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #31
commit afe71f3936745d24bfbe8f6c9208816712a603da
Author: Frank Tang <ftang@chromium.org>
Date: Tue Mar 08 05:24:38 2022
[Temporal] Add Temporal.PlainDate.from
Bug: v8:11544
Change-Id: I781119561db5ec05b12b9bca31c98403355e35ac
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79396}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #32
commit 70467d9ed1b17f69c605125eb711d4dce320622a
Author: Frank Tang <ftang@chromium.org>
Date: Fri Mar 18 05:39:17 2022
[Temporal] Add Temporal.PlainTime.from
Bug: v8:11544
Change-Id: I134b8c786a8dfaef2f4f2509ec5f6c6a009852f3
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79523}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #33
commit 9fa4bb6609aa4e2b54b2f640b70a3de4f9146dfd
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 19 00:59:03 2022
[Temporal] Add Duration fromEpoch*Seconds
Spec Text:
Bug: v8:11544
Change-Id: I254ef66faf5e6a49bfc389f2952ffab3d5c0bed2
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79532}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #34
commit 29d1e17aa402030ababa94893a7f2e545170c767
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 19 04:52:08 2022
[Temporal] Add from to Instant
Also add AO: ToTemporalInstant, ParseTemporalInstant,
ParseTemporalInstantString,
Spec Text:
Bug: v8:11544
Change-Id: Ie78f7389eef15795f276291ba99e18a72566f9bc
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79534}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35
commit c232d789c7e60c5fed61223eaad0c6fc0b3fd25b
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 19 00:41:41 2022
[Temporal] Add Duration.prototype.(abs|negated)
Also add AO: CreateNegatedTemporalDuration
Spec Text:
Bug: v8:11544
Change-Id: Ie522a7446f40c946c30f2e90c5f6c7fbc96c41eb
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79633}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #36
commit cdafded496ba1ee9efe18b2bf5e0e471fab61571
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 19 01:10:24 2022
[Temporal] Add Calendar.prototype.daysInYear
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I627fcf82641659c4697395057ee664a37f237228
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79634}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #37
commit 8b663818fc311217c2cdaaab935f020578bfb7a8
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 26 22:31:23 2022
[Temporal] Add Temporal.Calendar.prototype.year
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: Ifadcdb4efe00a9954d5ac4c1154420c4903f28d5
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79635}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #38
commit eb9a19a0a11d7767888d632897f348ff36873841
Author: Frank Tang <ftang@chromium.org>
Date: Sun Mar 27 06:19:28 2022
[Temporal] Add Calendar.prototype.dayOfYear
Also add AO: ToISODayOfYear
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I5e5f9ea93cc0577df8d9b228efe5c3a97d118b88
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79681}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #39
commit 803d1d3961fe00eedc69dabb5ff3d9e8ba48d554
Author: Frank Tang <ftang@chromium.org>
Date: Wed Mar 30 23:37:03 2022
[Temporal] Add Calendar.prototype.monthsInYear
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: Ibf7a9f1e64ce638f745df2649ee3a69dc9e08139
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79682}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #40
commit 3f3a427f48acede9113ad3073aa305d278fa32bb
Author: Frank Tang <ftang@chromium.org>
Date: Thu Mar 31 01:23:08 2022
[Temporal] Add Calendar.prototype.dayOfWeek
Also add AO: ToISODayOfWeek
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I0b3448209741e4aa56cd8170a331d837853bff17
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79698}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #41
commit 05a58f2687b991980d0f11e68312abe5350209be
Author: Frank Tang <ftang@chromium.org>
Date: Thu Mar 31 00:55:22 2022
[Temporal] Add Calendar.prototype.inLeapYear
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I0f30d45ed6d742acaeaa2f7ddf5b393ef7fa5437
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79699}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #42
commit 4bbe174c887758189af71fd31c35178c1c2fff7d
Author: Frank Tang <ftang@chromium.org>
Date: Fri Apr 01 18:15:09 2022
[Temporal] Add ZonedDateTime.prototype.toPlain(MonthDay|YearMonth)
Spec Text:
Bug: v8:11544
Change-Id: I5b109282187055df767239ff240822591f95c9a7
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79717}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #43
commit 63f9f0fab53cd37c64ffc3e09bca0ecddd833ab9
Author: Frank Tang <ftang@chromium.org>
Date: Fri Apr 01 21:41:03 2022
[Temporal] Add Calendar.prototype.daysInMonth
Spect Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: Id5d426d9c5fe1db94c15433afbad443c7056abe3
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79720}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #44
commit b214cb7d72332b74689fd50f1cb4864daa1684ae
Author: Frank Tang <ftang@chromium.org>
Date: Sat Apr 02 01:07:59 2022
[Temporal] Add Calendar.prototype.daysInWeek
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: If54733ae7c902b4d189fc22b0800942f8748981c
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79721}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #45
commit a46415809187d438d8aa923771cc951e6c792a1b
Author: Shu-yu Guo <syg@chromium.org>
Date: Tue Apr 05 22:23:09 2022
Roll Test262
Bug: v8:7834, v8:10776, v8:11544, v8:12744, v8:12750
Change-Id: I782a347833af3418ff5c15562ae24f213375b539
Reviewed-on:
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79788}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #46
commit dda56765dc5d2ef5d7e5cc2090a518eb7b426631
Author: Frank Tang <ftang@chromium.org>
Date: Tue Apr 05 16:48:40 2022
[Temporal] Add Calendar.prototype.dateFromFields
Also add AO: RegulateISODate, ResolveISOMonth, ISODateFromFields
Spec Text:
Note:
This is only the non-intl version. The intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I493dc60694421e9908eb5d785fdb8b07fc968699
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79793}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #47
commit 519267b325286829682211ebce99b9a09a473963
Author: Frank Tang <ftang@chromium.org>
Date: Wed Apr 06 04:46:15 2022
[Temporal] Add Calendar.prototype.mergeFields
Add AO: DefaultMergeFields
Spec Text:
Bug: v8:11544
Change-Id: I270f8bffb79e57ef50736ae7ce87cfa53f9cafb1
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79795}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #48
commit cf428859588ee9422617da8a60d2db9c6947feff
Author: Frank Tang <ftang@chromium.org>
Date: Fri Apr 15 20:31:22 2022
[Temporal] Sync with spec
Add DateDurationRecord, TimeDurationRecord
and use them in the AO args.
Also change arg and return to struct to avoid passing in pointer for output.
Bug: v8:11544
Change-Id: I34c497ffd341c5cc4693255f51f3dae6d29cfd72
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80000}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #49
commit 7a919fe25fa25bbf9eee46bf332272423b1ecf5f
Author: Frank Tang <ftang@chromium.org>
Date: Sat Mar 19 08:33:30 2022
[Temporal] Add ZoneDateTime.prototype.offset*
Spec Text:
Bug: v8:11544
Change-Id: Ia88d96b038117a8e528ff9d0cdb9a07fb7cbcda5
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80096}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #50
commit 5c3627754e309184fd02dd3f9444c54ac0e06085
Author: Frank Tang <ftang@chromium.org>
Date: Fri Apr 22 20:55:55 2022
[Temporal] Add Calendar.prototype.fields
Spec Text:
Bug: v8:11544
Change-Id: I8df987ddbbf08372da637d7c4620c428fce97cae
Reviewed-on:
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80127}
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #51
commit 07601b124e899ba1a1db0f493ea3322aaf8713c7
Author: Frank Tang <ftang@chromium.org>
Date: Tue Apr 26 06:10:31 2022
[Temporal] Add Calendar.prototype.dateUntil
Also add AOs: ToLargestTemporalUnit, ToISODayOfYear, RegulateISODate,
AddISODate, DifferenceISODate
Spec Text:
Bug: v8:11544
Change-Id: I03a28bf07ddfae036491e49cb06278d050ddebf6
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80166}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #52
commit 9143c553878e8e547fe8ea9160e8e4a638c02e9d
Author: Frank Tang <ftang@chromium.org>
Date: Tue Apr 26 19:09:50 2022
[Temporal] Add Temporal.Duration.from
Also add AOs:
IsIntegralNumber, ToIntegerWithoutRounding, ToTemporalDurationRecord,
ToTemporalDuration, ParseTemporalDurationString, CreateDurationRecord
Spec Text:
Bug: v8:11544
Change-Id: I0f4176921e088bd2f2fd48ddd28f22f3b454bd3b
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80195}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #53
commit f09026a6f269e9cfa987599368af90732081ca60
Author: Frank Tang <ftang@chromium.org>
Date: Wed Apr 27 19:21:46 2022
[Temporal] Add PlainDateTime.from
Also add AOs: ToTemporalDateTime, ParseTemporalDateTimeString,
InterpretTemporalDateTimeFields
Spec Text:
Bug: v8:11544
Change-Id: I3cf5c7c0f876dd8f384d62a47d7b24d8780bf03f
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80240}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #54
commit d43080a7f78aeccb04c5602624376a9e0fe47efb
Author: Frank Tang <ftang@chromium.org>
Date: Mon May 02 17:34:02 2022
[intl] Fix ResolvedOptions to output.
In v3 we allow both significant digits and fraction digits to be set in some conditions.
Also fix the case in v2 we didn't handle "precision-integer" with currency format.
Related spec text:
Bug: v8:11544
Change-Id: I89c147dcc7803eae7aad2a380e85d1d877e30370
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80322}
[add]
[modify]
[add]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #55
commit 97122a48387053114af375c7d3bf2f0ef0edd414
Author: Frank Tang <ftang@chromium.org>
Date: Thu Apr 28 05:36:00 2022
[Temporal] Add Temporal.Calendar.prototype.day
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: If56182cf65b3b8cc91ed843f0e20edeb6a065954
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80347}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #56
commit 08a5a57311e8d27a3513e838f0d51e1337bb6706
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 03 20:27:59 2022
[Temporal] Add Temporal.Calendar.prototype.monthCode
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: I52dfc1bda6d2ed8c0aba735c64d7ae8227844ed1
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80348}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #57
commit 2dd3cc3054994d158942aa53309d66a43df03c59
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 03 08:24:05 2022
[Temporal] Add TimeZone.prototype.getInstantFor
Spec Text:
Bug: v8:11544
Change-Id: Ibb38f807386c4e213bfd2bb568911a96a17cf1be
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80350}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #58
commit 10bbb38fed9e908d02eeeb8cb5bc7c3138a1aed4
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 04 20:56:01 2022
[Temporal] Add Temporal.Calendar.prototype.month
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
Bug: v8:11544
Change-Id: Ibbbb00faa0bdb4d49784cd9aae69fb779d95f924
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80359}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #59
commit bf54cc83a588c68e697ea7a7276fc1e1f94d4932
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 04 22:21:58 2022
[Temporal] Add monthDayFromFields to Calendar
Add AO: ISOMonthDayFromFields
Spec Text:
Bug: v8:11544
Change-Id: I8a04a8e61af8abdb902de33efbf5635b8e8300aa
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80360}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #60
commit 904b372be36ad712192109b344244f15dfd8b006
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 04 04:42:40 2022
[Temporal] (Calendar|TimeZone).prototype.toJSON
Also change the macro to pass method name directly to CHECK_RECEIVER()
Remove MACROs which has up to only two usage.
Sync with changes in
Spec Text:
Bug: v8:11544
Change-Id: I31f4ef6f725462da885893f1266d30590098b031
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80363}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #61
commit c8c0632388b8259f11e33eafbb767252a92afa4e
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 06:49:09 2022
[Temporal] Add Calendar.prototype.dateAdd
Spec Text:
is not yet implemented.
Note: The intl version stated in
https: //
Bug: v8:11544
Change-Id: Id7fd043d234f559c0e03bdf3f0f31d8bc91da27f
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80364}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #62
commit 3f10a72c2fd0a27d8f0e77f83e5f3623693d9b92
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 17:48:22 2022
[Temporal] Use MAYBE_ASSIGN_RETURN_ON_EXCEPTION_VALUE
1. Move the use of MAYBE_RETURN to MAYBE_ASSIGN_RETURN_ON_EXCEPTION_VALUE
if possible.
2. Remove some MYABE_RETURN in the wrong spot and therefore fix some tests.
3. Change Intl::GetTimeZoneIndex() to return Maybe<int32_t> as index and use
< 0 value to indicate not getting index to make the function signature
simpler.
Bug: v8:11544
Change-Id: I685cbff142e9dea69ef316a1bc180730aef5aec8
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80379}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #63
commit 4251c285e62388fc69ac5ef0bb5bf271561be534
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 08:34:20 2022
[Temporal] Add TimeZone get*Transition and getPlainDateTimeFor
Also add non-intl (only support UTC) version of AO:
GetIANATimeZoneNextTransition, GetIANATimeZonePreviousTransition
(support of other timezone in Intl will come later)
Spec Text:
Bug: v8:11544
Change-Id: I17d5a60638dcd8543e5d9f22c6560b311f2f402a
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80383}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #64
commit 2b140a9f96e023d3f768b2e397b0cc5ca4d38799
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 21:36:29 2022
[Temporal] Add Calendar.prototype.yearMonthFromFields
Add AO: IsValidISOMonth, RegulateISOYearMonth, ISOYearMonthFromFields
Spec Text:
Bug: v8:11544
Change-Id: I1baadbbe54fb0c3fd45750eddb13b790465c3a3b
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80384}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #65
commit 4dc48c7841d66bd055e5052e14b62e68ac1163f2
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri May 06 06:11:30 2022
Revert "[Temporal] Add Calendar.prototype.yearMonthFromFields"
This reverts commit 2b140a9f96e023d3f768b2e397b0cc5ca4d38799.
Reason for revert: Need to revert parent CL.
Original change's description:
Bug: v8:11544
Change-Id: I1d93a25ee36b08d7a0bc86937d5b0a18ab6cdf86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#80385}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #66
commit 9b3bd2c81a42704d5ed1f3eee4d41d7d82ef4088
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri May 06 06:12:38 2022
Revert "[Temporal] Add TimeZone get*Transition and getPlainDateTimeFor"
This reverts commit 4251c285e62388fc69ac5ef0bb5bf271561be534.
Reason for revert: Fails on CI bots:
Original change's description:
Bug: v8:11544
Change-Id: Icfbb643578ac028b06aa07c3ac6bbce030f49390
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#80386}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #67
commit 9ae5bfa5b909657ae2bdde1d00ad025dbefadca6
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 21:36:29 2022
Reland "[Temporal] Add Calendar.prototype.yearMonthFromFields"
This is a reland of commit 2b140a9f96e023d3f768b2e397b0cc5ca4d38799
Original change's description:
Bug: v8:11544
Change-Id: Ic5831c7094cd235526d93010cd722110f2951d77
Reviewed-on:
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80399}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #68
commit 187ecb8b72c05715f2ca678db9a0c2e8f8da944b
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 05 08:34:20 2022
Reland "[Temporal] Add TimeZone get*Transition and getPlainDateTimeFor"
This is a reland of commit 4251c285e62388fc69ac5ef0bb5bf271561be534
Change the test262.status by moving test which passing on no_i18n
but not on ALWAYS:
1) Change the [FAIL] of that test in the ALWAYS section to [SKIP].
2) Add the same test the no_i18n section as [PASS]
Original change's description:
Bug: v8:11544
Change-Id: Ieddadbc9d0708bda24f88dd2083b0dbe7dc1b9f3
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80405}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #69
commit d36c7f1f8a248703aa7ddbb213f163b942872378
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 06 23:03:37 2022
[Temporal] Add TimeZone.prototype.getPossibleInstantsFor
Also add the basic version of GetIANATimeZoneEpochValue AO which only
implement UTC. Verison to support other TimeZone will come later w/ intl
work which depends on ICU.
Spec Text:
Bug: v8:11544
Change-Id: Ib603530d1c70f7a2b85691860a815d44b48eece2
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80406}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #70
commit c9ebb118a93d85ff8a2e050aa59bd7103c5886a0
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 07 02:59:22 2022
[Temporal] Fix GCC >= comparison error by cl/3624980.
Change kUTCTimeZoneIndex to int32_t from uint32_t
And compare index against 0.
Bug: v8:11544
Change-Id: Ib7dd55cab796d1d9a4b0e2869b098520265a04f0
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80412}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #71
commit 988aa5139f66789529fd0310ac7658974e1a658c
Author: Frank Tang <ftang@chromium.org>
Date: Mon May 09 02:24:30 2022
[Temporal] Sync w/ PR2028
Sync to spec changes in
PR2028 Consistently call observable operations with undefined options
Bug: v8:11544
Change-Id: I850761e76ba1bb33f6c3b655a71163d1b68bb4c8
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80433}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #72
commit 1f09e46859356b6d1332978e37a2e560d9dea4c4
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 10 04:50:43 2022
[Temporal] Change Parser from Maybe to Optional
Bug: v8:11544
Change-Id: I16b1fb2cb4f6f4104b2f972a06b8fe0798ac6835
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80435}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #73
commit 4819584a2c09d53ecef10d8d5dcc0000e8ba1542
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 11 16:44:43 2022
[Temporal] Implement the iso8601 part of Calendar.prototype.era(Year)?
Spec text:
Notice this only implement the "iso8601" calendar and we will implement the
code for other calendar later by calling ICU with other Calendar methods.
This CL reduce the differences of testing result between ALWAYS and no_i18n
because the code in no_i18n will not call Calendar era or eraYear and therefore
passed the test even w/o this CL but the ALWAYS tests will cause Temporal
object to internal call era and eraYear and therefore fail if w/o this CL.
Bug: v8:11544
Change-Id: I921fbfbbd26473c238024161eb58b096c38b881b
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80513}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #74
commit 972d7e5abf792b3dcc76cf0cdbf8aea61f88a8ec
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 18 06:35:03 2022
[Temporal] Add TimeZone getOffset(Nanoseconds|String)For
Also add the non-intl version of AO
GetIANATimeZoneOffsetNanoseconds which only implement for UTC.
(intl version implement other tz come later)
Also fix bug in JSTemporalTimeZone::offset_nanoseconds() that
"1000000L * offset_milliseconds()" may overflow int32_t before returning as int64_t by first casting offset_milliseconds() to int64_t in the operation so the whole formula is calculating under 64 bits not 32 bits. This bug fix some *timezone-string-datetime tests.
Spec Text:
Bug: v8:11544
Change-Id: I2227dbfc8d6ed3ef83edcef5a9b903b8642b5902
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80606}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #75
commit a1d642bed17e994faafd23b1a1ac7b874b996a29
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 18 06:55:07 2022
[Temporal] Minor tweak for code calling temporal parser
Rewrite CreateTemporalTimeZone to sync with
Bug: v8:11544
Change-Id: I75c75146a5a84fc51d4b5ed182641ebf697e8389
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80607}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #76
commit a5697616ebee4d15756834b8ba1177b49710cb83
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 19 00:43:19 2022
[Temporal] Add PlainDate.prototype.toJSON
Also add AOs: PadISOYear, FormatCalendarAnnotation, TemporalDateToString
Spec Text:
Change the ISODateTimeWithinLimits from
-8.64 × 10^21 - 8.64 × 10^16, 8.64 × 10^21 + 8.64 × 10^16
to
-8.64 × 10^21 - 8.64 × 10^13, 8.64 × 10^21 + 8.64 × 10^13
per
Change to use AppendCStringLiteral instead of AppendCharacter when
appropriate.
Bug: v8:11544
Change-Id: I01f22657b2c3e5aacbea790593d7e9f60076ec74
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80622}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #77
commit 0b44a86009d7114e45129da59a6227c48064329b
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 19 00:45:39 2022
[Temporal] Add PlainMonthDay.prototype.toJSON
Also add AO: TemporalMonthDayToString
Spec Text:
Bug: v8:11544
Change-Id: Ibbc5b28a9c73474f7edc1b67c9beabf5bca54dbc
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80624}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #78
commit 5354d8a1c6d4f6ac418ea93d58d6bf953283be3a
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 19 04:25:16 2022
[Temporal] Add PlainYearMonth.prototype.toJSON
Also add AOs: TemporalYearMonthToString
Spec Text:
Bug: v8:11544
Change-Id: Ibe8bd20ae5eb5b7721e50cf5386c20d8d23e18e6
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80627}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #79
commit c68336252dc2f787b3e9dce3fa4f778e049f64b3
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 19 23:48:12 2022
[Temporal] Add Plain(Date|MonthDay|YearMonth).*.to(Locale)?String
Spec Text:
Implement toString/toLocaleString as non-intl version.
Because toString took options bag in Temporal, we cannot use the
same way how we handle Date.prototype.toLocaleString() for non-intl
build by just forwarding to it's toString implementation.
Change built-ins-defintions.h to always has built-ins for
*.toLocaleString , not just in intl build.
Change src/init/bootstrapper.cc away of the toLocaleString forward
to toString approach.
Implement the non-intl version of ToLocaleString in js-temporal-objects.cc for
Temporal.Plain(Date|YearMonth|MonthDay)
Bug: v8:11544
Change-Id: I202bcf28ef05ed03c337475300cfdfd18b52ffb3
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80675}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #80
commit caccea8d091776521fd9ac444210ea178d05edf0
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 20 21:40:33 2022
[Temporal] Add PlainMonthDay.from
Also add AOs: ParseTemporalMonthDayString, MonthDayFromFields,
ToTemporalMonthDay
Spec Text:
Bug: v8:11544
Change-Id: I971b5a0f43b9dbeefe38ebe28035f7c9b1a617ff
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80676}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #81
commit 74aa5e7d68603da21a14d52784ed085acdb1a665
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 20 04:26:41 2022
[Temporal] Add Temporal.Duration.prototype.toJSON
Also add AO: TemporalDurationToString
Spec Text:
Bug: v8:11544
Change-Id: I7dfdb5458b88646a4ac7b7713e7c8e63352f7539
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80677}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #82
commit 71fb98092b08f23d14af35ad3a26660d48e3ceed
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 20 22:09:45 2022
[Temporal] Add ZonedDateTime.prototype.* forward to calendar
Implement the following methods of ZonedDateTime
year, month, monthCode, day, dayOfWeek, dayOfYear, weekOfYear,
daysInWeek, daysInMonth, daysInYear, monthsInYear, inLeapYear,
era, eraYear
Also implement corresponding AOs (CalendarXXX).
Spec Text:
Bug: v8:11544
Change-Id: I7d7008a719f0109836834d170c5f52b49c3ffb7e
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80678}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #83
commit a2f22f43556256c60ede59a74739ee2c91208804
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 20 23:44:31 2022
[Temporal] Add PlainDate(Time)? toPlain*Month*
Spec Text:
Bug: v8:11544
Change-Id: Ia97de3b4dde183ae4ee514deb4d13da5d5ff9bae
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80680}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #84
commit db2dc635352d00e6a10419324f947f9120574a8e
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 00:09:50 2022
[Temporal] Add ZonedDateTime.prototype.withPlainTime
Spec Text:
Bug: v8:11544
Change-Id: I1c35c1105c9f2cc051d3b17718f52170fbee2a5f
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80681}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #85
commit 9473a5e987f898ced756b008c2bd8b14a518c201
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 00:30:39 2022
[Temporal] Add toJSON to PlainTime
Bug: v8:11544
Change-Id: Iaf440009b2abdf9e90de3ed0e6e02eb35060a65b
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80682}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #86
commit 4cf301722c29004dac2d5b8979d9e1c83b590f23
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 00:39:41 2022
[Temporal] Add PlainYearMonth.from
Also Add AOs: ToTemporalYearMonth, YearMonthFromFields, ParseTemporalYearMonthString
Spec Text:
Bug: v8:11544
Change-Id: I04b30a4159142a996c765c542f19e66bee593e4e
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80683}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #87
commit a90169d304842edfc33d991dab1b6df8fe1dbbfe
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 00:51:08 2022
[Temporal] Add Instant.prototype.toZonedDateTime(ISO)?
Spec Text:
Bug: v8:11544
Change-Id: I452dfbf027e5d58edde9f9691519204ff29d8082
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80684}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #88
commit 05f3596f802bca88afbffe49de16666df5647dd7
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 00:57:22 2022
[Temporal] Add PlainDateTime.prototype.toZonedDateTime
Spec Text:
Bug: v8:11544
Change-Id: Ic4464e6d4521fb7e006164933df4f38c5d3115b1
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80685}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #89
commit 2fc37ae5e25a73cdcb768014d0f459ab37c6109d
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 03:56:05 2022
[Temporal] Syntax error if DateExtendedYear is -000000
Sync to PR2036
Treat -000000 in DateExtendedYear as syntax error
Bug: v8:11544
Change-Id: I8cf7a506e85ad2b74d572142d646f3f98cd8bffa
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80705}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #90
commit 3c53e9adaea8c813daad9a2148e70615bbb518c3
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 04:52:00 2022
[Temporal] Add PlainDateTime.prototype.withPlainTime
Spec text:
Bug: v8:11544
Change-Id: I5277fb88675bb6d99b028a289329db06b95cc003
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80706}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #91
commit a663b1ff66f9c367cd28443ee50a42194ca5ff85
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 21 05:09:21 2022
[Temporal] Add PlainDate toPlainDateTime
Spec Text:
Bug: v8:11544
Change-Id: Ie86a5d8a2f1206a44d0e74638392ae26e0f8e900
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80707}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #92
commit 8516c9bed50527be5943099152c195ec2a8c4ca9
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 24 06:03:23 2022
[Temporal] Add Plain(Date|YearMonth|MonthDay).prototype.with
Spec Text:
Bug: v8:11544
Change-Id: I311d6246646ce18503804352bc95a374af3d8c6e
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80708}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #93
commit fc50b033e3abc56d6d0c2010a06e75705cfccdf4
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 24 06:25:18 2022
[Temporal] Add PlainDate.prototype.toZonedDateTime
Spec Text:
Bug: v8:11544
Change-Id: I758e46efdc33cfc3f336e5c595a402123ae6c485
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80709}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #94
commit 38e56036dd965db78b9462c30d4844bea3cf7309
Author: Frank Tang <ftang@chromium.org>
Date: Tue May 24 06:48:17 2022
[Temporal] Add PlainTime.prototype.toZonedDateTime
Spec Text:
Bug: v8:11544
Change-Id: I147b1d21b4728520c5667a30548ec77f71d7445a
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80730}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #95
commit 702f874a3b013539d3f434645fe7f8fe8c2bc262
Author: Frank Tang <ftang@chromium.org>
Date: Mon May 23 17:19:21 2022
[Temporal] Add PlainDateTime.prototype.toPlain(Date|Time)
Spec Text:
Bug: v8:11544
Change-Id: Ifb7115823d1d3d1ff53806f1b376d69302e00ae1
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80731}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #96
commit 3ba8390cb93e1b203d64ee05f74a19a75dabc905
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 25 02:31:20 2022
[Temporal] Add PlainTime.(compare|prototype.equals)
Also add AO: CompareTemporalTime
Spec Text:
Bug: v8:11544
Change-Id: I8e2a320c2e296558e1fb15ef6e855e6b6a14ece2
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80732}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #97
commit 06d61bd5756947332a48be7d8ab77290976ca1f2
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 25 00:45:29 2022
[Temporal] Add ZonedDateTime.prototype.startOfDay
Spec Text:
Bug: v8:11544
Change-Id: I475e03fa9ba43290896a906524414cfbddd1f7bb
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80754}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #98
commit 600cebb4d0439c267f730a74f5cbb029ab02fab9
Author: Frank Tang <ftang@chromium.org>
Date: Wed May 25 00:53:42 2022
[Temporal] Add Date.prototype.toTemporalInstant
Spec Text:
Bug: v8:11544
Change-Id: I65315152333291f76edc05cc41a528912a185d02
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80755}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #99
commit cc8b4427739114c4d6a708784874fbe9fcefba14
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 26 04:09:23 2022
[Temporal] Add PlainTime.prototype.toPlainDateTime
Spec Text:
Bug: v8:11544
Change-Id: I95bab9814471bb9347101d654f6dc902159f8fe3
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80757}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #100
commit 1b13172df346797b8a574a2341ed90a08cfdf443
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 26 01:40:08 2022
[Temporal] Add PlainDateTime.prototype.withPlainDate
Also add AO: ConsolidateCalendars
Spec Text:
Bug: v8:11544
Change-Id: I98084f7cc92a837f6401a88ad10389a7c5df8b3d
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80764}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #101
commit 86a219d9c903edb63655e5513bbfcbe82b187e25
Author: Frank Tang <ftang@chromium.org>
Date: Thu May 26 22:36:01 2022
[Temporal] Add Duration.prototype.with
Also add AO: ToPartialDuration
Spec Text:
Bug: v8:11544
Change-Id: I43282f5285a3c884229445547add6db2cde4fbe4
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80767}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #102
commit 4ad4ba1dff6a0a5eb0d7c3771d2ac7b5c1d8748d
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 27 03:14:52 2022
[Temporal] Add Plain(Date)?Time.prototype.with
Refactor ToTemporalTimeRecord to a new routine
ToTemporalTimeRecordOrPartialTime to share code with ToPartilTime
Change the return type of ToTemporalTimeRecord, RegulateTime
Spec Text:
Bug: v8:11544
Change-Id: I214147f497a405ee48e264833c7c0b9401596c01
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80769}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #103
commit 17087937da04ea40fabc7841e85b929280b11d04
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 27 00:47:59 2022
[Temporal] Add Plain(YearMonth|MonthDay).prototype.toPlainDate
Spec Text:
Bug: v8:11544
Change-Id: I506efe3fa3685f621596fa34301a73d8c57ded38
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80783}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #104
commit e85a0243ce46b432a46c78afd3be349c356aab25
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 27 16:52:50 2022
[Temporal] Add PlainDate(Time)?.(compare|prototype.equals)
Also add AO CalendarEquals, CompareISODateTime
Remove Isolate from CompareISODate argument
Spec Text:
Bug: v8:11544
Change-Id: I5505c7923e3c1f76d44e292135b489ea20fbf13c
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80787}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #105
commit 6fdea7b04069417632808346ea619d690c30feb3
Author: Frank Tang <ftang@chromium.org>
Date: Fri May 27 06:21:54 2022
[Temporal] Add ZonedDateTime to(Instant|Plain(Date)?(Time)?)
Also change some AO's return type from MaybeHandle to Handle
and call ToHandleChecked() on the right spot.
Spec Text:
Bug: v8:11544
Change-Id: I140b6a7053d00837bc48fb70980d69778715c0c9
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80788}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #106
commit 8ea33c9f54eaef0418fb6a8fcb8cb7f1b91133b7
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 15:49:09 2022
[Temporal] Add PlainTime toString and non-intl toLocaleString
Also implement AOs:
ToTemporalRoundingMode, ToSmallestTemporalUnit, RoundNumberToIncrement, RoundTime, ToSecondsStringPrecision
Spec Text:
Bug: v8:11544
Change-Id: I47ea27e966232e89bab48bf15a48c2c00ce5e160
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80792}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #107
commit c61c73ad0d07534f2dbf9dc646b50d321a9ef27f
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 18:30:56 2022
[Temporal] Add toJSON and non-intl version ot toLocaleString to PlainDateTime
Implement AO: TemporalDateTimeToString
Spec Text:
Bug: v8:11544
Change-Id: I170fa13822d87cfd668bd4cd8df50476f00c86f8
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80793}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #108
commit 88b644717f47ddd9f04f9ec6d9feebbab27c6ac1
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 18:46:22 2022
[Temporal] Add PlainDate.prototype.(add|subtract)
Spec Text:
Bug: v8:11544
Change-Id: Iacb4b9ba7d481005d14e2e4d42e2422133f5ab42
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80955}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #109
commit 9b4b64c282ca1e4a0ce63034b6c01fec7542458a
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 23:01:46 2022
[Temporal] Add PlainDateTime.prototype.(add|subtract)
Spec Text:
Bug: v8:11544
Change-Id: Ib76b090a62a932931ab48cb5814ce1f1050fae10
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80956}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #110
commit 7627b400c94dd8720777375c3e48ab95f74d6eb9
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 21:24:29 2022
[Temporal] Add PlainTime.prototype.(add|subtract)
Spec Text:
Bug: v8:11544
Change-Id: I0d684eec9eebfd26eceb6bb4c360025a33bd4c3c
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80957}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #111
commit 8436df4b68a9be64d0a2b72959af0a4b141d4c58
Author: Frank Tang <ftang@chromium.org>
Date: Sat May 28 21:19:47 2022
[Temporal] Add ZonedDateTime.prototype.hoursInDay
Also add AOs: AddISODate, RegulateISODate
Change the return type of GetISO8601Calendar from MaybeHandle to Handle since it will never throw exception.
Spec Text:
Bug: v8:11544
Change-Id: Id0b59e2818a095ee9390de2302501888fd93ca2b
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80958}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #112
commit 6d33cb89a4eee84180c2516d5966ae38f272c0a1
Author: Frank Tang <ftang@chromium.org>
Date: Mon Jun 06 17:02:57 2022
[Temporal] Add Instant.(compare|prototype.equals)
Also implement AO: CompareEpochNanoseconds
Spec Text:
Bug: v8:11544
Change-Id: I953a890250ff0bf29cd24e4638bf17ceb5f9bb2f
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80959}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #113
commit 5828eb425491c8b997f71664d7f3ff2c5251db31
Author: Frank Tang <ftang@chromium.org>
Date: Mon Jun 06 19:36:20 2022
[Temporal] Add ZonedDateTime.prototype.(add|subtract)
Spec Text:
Bug: v8:11544
Change-Id: If4e1f71a05a0d1e88829bf219d4f90bd7a343877
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80960}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #114
commit fdde51c67467802578d8eeafd9990c7e3b3a8955
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jun 07 22:49:26 2022
[Temporal] Add Instant.prototype.(add|subtract)
Spec Text:
Also fix bug in IsValidEpochNanoseconds
Bug: v8:11544
Change-Id: Ied605c9de4ee38a18e2356a89e3a69d534a004d1
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80983}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #115
commit e78152036752fef6c60ceb2ab9a7231dabd80e82
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jun 07 07:07:24 2022
[Temporal] Add withPlainDate to ZonedDateTime
Spec Text:
Bug: v8:11544
Change-Id: I8d7099906c04eae0e29ff0dabd48b736a07305d6
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80984}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #116
commit dc88fb92ed531d39f86ad56b39cbfff5326e1c1a
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jun 07 05:30:29 2022
[Temporal] Add toString to PlainDateTime
Implement AOs: RoundISODateTime
Spec Text:
Bug: v8:11544
Change-Id: Ib0318be8047bb01e593a43cef4405caa5979d1af
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80985}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #117
commit cddfa0c5ce8cfb6fea527a1bc6a667ef78e0a697
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jun 07 04:30:01 2022
[Temporal] Add compare/equals to YearMonth and MonthDay
Spec Text:
Bug: v8:11544
Change-Id: Ia03946e0e183ec9b0a8130515607c29a32a8b265
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80986}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #118
commit 25c264f894c6365c8300e59e2ae1d9fd9133b2a3
Author: Frank Tang <ftang@chromium.org>
Date: Thu Jun 09 17:14:38 2022
[Temporal] Add with to ZonedDateTime
Add AOs: ToTemporalOffset and InterpretISODateTimeOffset
Spec Text:
Bug: v8:11544
Change-Id: I8b757386596d0d73a73e8e9aa2d52cd72b90a95a
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81053}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #119
commit b66d08241d866bd5f7a0ec8de1738957cc7b3b5a
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jun 08 18:17:00 2022
[Temporal] Add non-intl toLocaleString to Duration
Spec Text:
This does NOT implement the intl version of toLocale in (noteice 'sup'
vs 'sec' after #)
since the details is not specified yet.
Bug: v8:11544
Change-Id: I7f5a2e9766005d1a7f6409d428ca53b5a38a3960
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81167}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #120
commit 2506d6ca1c584fd99a1d00ae35adea1495a28d83
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jun 15 04:42:10 2022
[Temporal] Add from to ZonedDateTime
Also implement AOs: ParseTemporalZonedDateTimeString, ToTemporalZonedDateTime
Spec Text:
Sync ToTemporalOffset and ToTemporalDisambiguation to latest spec to take undefined.
Bug: v8:11544
Change-Id: I4137725155201b025066538ce337f6ae4749dc5e
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81200}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #121
commit bb70895e491bcc8ebdb799327a81fba0f2f1798e
Author: Frank Tang <ftang@chromium.org>
Date: Fri Jun 17 01:10:23 2022
[Temporal] Add Instant.prototype.round
Also add AOs: ToTemporalRoundingMode, ToSmallestTemporalUnit,
ToTemporalRoundingIncrement, RoundHalfAwayFromZero,
RoundNumberToIncrement, RoundTemporalInstant
Spec Text:
Bug: v8:11544
Change-Id: I37750f166e6b5597db16574d2ce4d5f92065a7b0
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81212}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #122
commit 08c18bfc2e2639453ef6950414943ec763efdb8a
Author: Frank Tang <ftang@chromium.org>
Date: Fri Jun 17 22:37:24 2022
[Temporal] Add compare and equals to ZonedDateTime
Also add AOs: TimeZoneEquals
Spec Text:
Bug: v8:11544
Change-Id: Ibcd1e42d72f86f16e0f5ddb1fd589bbe7ab2225c
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81227}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #123
commit cd7100e9aabf1173a9a42f483840480e88585582
Author: Frank Tang <ftang@chromium.org>
Date: Fri Jun 17 22:07:48 2022
[Temporal] Add add/subtract to PlainYearMonth
Also add AOs: AddDurationToOrSubtractDurationFromPlainYearMonth,
CreateNegatedDurationRecord
Spec Text:
Also see
Bug: v8:11544
Change-Id: I5ca6acc82dad07a8dd202de02bca5a16e585e84c
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81228}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #124
commit 9262713316c18f224076ef3d69d6ce60ebf02a88
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jun 25 02:53:26 2022
[Temporal] Add round to PlainTime
Spec Text:
Bug: v8:11544
Change-Id: I564cec6fdc030e3d39a9798c047534228f670dc6
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81427}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #125
commit 1a5cfc20e1741ac638184da312ff8d15a37a65a7
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jun 29 07:51:32 2022
[Temporal] Add toJSON, toString, and non-intl toLocaleString to Instant
Also add AOs: FormatISOTimeZoneOffsetString, TemporalInstantToString,
GetUnsignedRoundingMode, ApplyUnsignedRoundingMode, RoundTemporalInstant
Also update the RoundNumberToIncrement implementation and a BigInt version.
Fix the test setup in test/mjsunit/temporal/instant-to-json.js since fromEpochSeconds and fromEpochMilliseconds do not take BigInt
Spec Text:
This does NOT implement the intl version of toLocaleString
specified in (notice the "sup" not "sec" after #) yet.
Bug: v8:11544
Change-Id: I807afd5bf550d2a65a4732a8e536056eea79cf8f
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81428}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #126
commit 8a14d953e23cb8161465851a339ece5e60efcc24
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jun 29 22:25:05 2022
[Temporal] Sync to PR1953 and PR1917 to fix bugs.
Bug: v8:11544
Change-Id: I667980e312248ccbaf826d4e3104fb1ddabef890
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81453}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #127
commit a63e2ddfb49715aaf6f8995184d5bed73120b412
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jun 29 22:58:48 2022
[Temporal] Add toString to Duration
Add AOs: MoveRelativeZonedDateTime, DaysUntil, MoveRelativeDate,
RoundDuration,
Also fix bugs in CalendarDateAdd, TemporalDurationToString, IsValidDuration
Spec Text:
Bug: v8:11544
Change-Id: I351cdb88a930f3f7b48f351549d390e5bd02d91e
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81501}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #128
commit e61e0194818860bb3bbef3567fa4760b830da9e5
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 02 01:38:00 2022
[Temporal] Add since/until to Instant
Also add AOs: GetTemporalUnit, NegateTemporalRoundingMode,
MaximumTemporalDurationRoundingIncrement, GetDifferenceSettings,
DifferenceInstant, DifferenceTemporalInstant
Spec Text:
Bug: v8:11544
Change-Id: Iabcc452304366132b03bb82529159c7553c610b3
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81502}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #129
commit 6b02aed32b05a129f9ad83f6a83fd4d38249fb60
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 02 02:29:00 2022
[Temporal] Sync to PR2248 to use GetTemporalUnit
Bug: v8:11544
Change-Id: I02612030f626adf2b163dca96c7602efe6adef4a
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81503}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #130
commit adb111b776429a8962978eef1f1e664b6ef2bb56
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 02 05:58:38 2022
[Temporal] Fix PlainTime/PlainDateTime toString bugs
Bug: v8:11544
Change-Id: Iaf3d673c9746badadae082121402e723d3704189
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81506}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #131
commit 7a4a6cc6a85650ee91344d0dbd2c53a8fa8dce04
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 02 06:02:42 2022
[Temporal] Add toJSON, toString and non-intl version of toLocaleString to ZonedDateTime
Also add AOs: FormatISOTimeZoneOffsetString, TemporalZonedDateTimeToString, ToShowTimeZoneNameOption, ToShowOffsetOption,
Update FormatTimeZoneOffsetString to use ToZeroPaddedDecimalString
Spec Text:
The intl version of toLocaleString is not implemented in this CL yet
Bug: v8:11544
Change-Id: Id7e4f72b63864857b0b3fa8dc8dfcba0b5949faa
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81507}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #132
commit a72b10aaab6be5185694a534f91d142a1be262e5
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 02 15:45:27 2022
[Temporal] Mark passed test to fix build.
Bug: v8:11544
No-Tree-Checks: true
Change-Id: I12b093da9f9f4f63bc67b1efaeefb735b8a6c5e4
Reviewed-on:
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81508}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #133
commit 320844e05917cbf0e8cd9693094c4093624cc343
Author: Frank Tang <ftang@chromium.org>
Date: Wed Jul 06 22:33:21 2022
[Temporal] Add round to PlainDateTime and ZoneDateTime
Also change InterpretISODateTimeOffset parameter type.
Add AOs: ToTemporalDateTimeRoundingIncrement
Spec Text:
Bug: v8:11544
Change-Id: I1a74ed165b3643467d8d894fd16fd59217ba8063
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81649}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #134
commit a10194cf824ec67a40b10b355aec47566879eba2
Author: Frank Tang <ftang@chromium.org>
Date: Mon Jul 11 22:22:25 2022
[Temporal] Add add/subtract to Duration
Also implement AOs: ToRelativeTemporalObject, AddDuration, AddDurationToOrSubtractDurationFromDuration,
ParseTemporalRelativeToString, DefaultTemporalLargestUnit,
DifferenceZonedDateTime
Spec Text:
Bug: v8:11544
Change-Id: Id2eff50d7f810042e1b7c53c49a09f9e489d5460
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81650}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #135
commit cfbe175edad2b7bd3392717f485d8a82f1a0909c
Author: Frank Tang <ftang@chromium.org>
Date: Mon Jul 11 23:33:19 2022
Revert "[Temporal] Add add/subtract to Duration"
This reverts commit a10194cf824ec67a40b10b355aec47566879eba2.
Reason for revert: Merge conflict break build
Original change's description:
Bug: v8:11544
Change-Id: Ia40c6f47d7cf6255b0ad6f2f70571b79c7e2d7af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81651}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #136
commit 3c2925edd1aa139b08d3fd0f259809362875de30
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jul 12 00:04:47 2022
Reland "[Temporal] Add add/subtract to Duration"
This is a reland of commit a10194cf824ec67a40b10b355aec47566879eba2
Original change's description:
Bug: v8:11544
Change-Id: I4bf8055bc328e28cd40a4eaa282d125d69c47e96
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81652}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #137
commit f593e43a0ca8262bcbda90ffbc3191fa36f5dac0
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jul 12 02:28:00 2022
[Temporal] Add since/until to PlainDate/PlainTime/PlainYearMonth
Change temporal::ToTemporalTime to use default argument value
Fix negative float division bug in BalanceTime
Also implement:
DifferenceTemporalPlainDate, DifferenceTemporalPlainYearMonth and DifferenceTemporalPlainTime
Spec Text:
Bug: v8:11544
Change-Id: Ic717c69f4e399bc0ed4aaaaff4578cb329223205
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81672}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #138
commit df2109cb5ce22ec30e0505cea9f38590ccfcef26
Author: Frank Tang <ftang@chromium.org>
Date: Mon Jul 18 20:19:29 2022
[Temporal] Parser sync to PR1952 and PR2187
Spec text:
Support 'T' prefix in time-only strings and require it in cases of ambiguity
Remove TemporalDateString and TemporalRelativeToString from parser
Change algorithm of ParseTemporalDateString
Related spec changes:
Bug: v8:11544
Change-Id: I7430afabb7dd78930b339b818bad7c7721decb99
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81792}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #139
commit 2a609e4592dd7ea4a835141438748dcad260457a
Author: Frank Tang <ftang@chromium.org>
Date: Thu Jul 21 21:50:47 2022
[Temporal] Add special version of BalanceDuration
Add a second implementation of BalanceDuration which
the nanoseconds could be very large and beyong the precision
could be handled by double and passed in by BigInt, and values
of other time fields are 0.
Bug: v8:11544
Change-Id: Ib794c6c78b81b8338434314fa5033cf1e991d32b
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81876}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #140
commit f52762254617e57bc36ac332191423a4b1ae4732
Author: Frank Tang <ftang@chromium.org>
Date: Sat Jul 23 06:06:56 2022
[Temporal] Add compare, round and total to Duration
Also add AOs:
ParseTemporalRelativeToString, DefaultTemporalLargestUnit, CalculateOffsetShift, UnbalanceDurationRelative, BalanceDurationRelative,
Spec Text:
Bug: v8:11544
Change-Id: I3b20bdb7cec30f6a8503603169643678988f4dcf
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81942}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #141
commit a06680e71490fea2bf01d92f736c94fe6f4217a3
Author: Frank Tang <ftang@chromium.org>
Date: Tue Jul 26 22:10:10 2022
[Temporal][Intl] Implement non UTC timezone in intl
Call Intl function which call ICU TimeZone for the calculation
of timezone other than UTC
Bug: v8:11544
Change-Id: Idc355aaeccc0bed026a7117bb366ee914fa29733
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81983}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #142
commit f4a938e4a6873739380a69d6d943ec8ab756d4f9
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 03 20:57:21 2022
[Temporal] Fix bug in Plain(Date|YearMonth|MonthDay) with()
Correct the wrong parameter passing in the 3rd PrepareTemporalFields
calls
Spec text:
Bug: v8:11544
Change-Id: I8acd7059cedf6924eee36ed5cb7892b636c8c72a
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82184}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #143
commit 6fd503608aceed2bb6142dc7ffe5cfd394d112d1
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 03 23:12:01 2022
[Temporal] Fix test to sync with latest spec after spec change.
1. fix year value between 100 and 9999 should use 4 digit padding without '+' prefix to sync with the latest spec in
mjsunit/temporal/plain-date-time-to-json
2. Change the the toPlainDateTime to accept object with partial time fields to sync with current spect in
test/mjsunit/temporal/plain-date-to-plain-date-time.js
3. Change the test to accept input parameter type to Number instead of BigInt for Instant fromEpochSeconds and from EpochMilliseconds in
test/mjsunit/temporal/instant-from-epoch-milliseconds.js and
test/mjsunit/temporal/instant-from-epoch-seconds.js
Throw TypeError if the type is BigInt.
4. Change the return type of Instant epochSeconds and epochMilliseconds from BigInt to Number to sync with the spec in
test/mjsunit/temporal/instant-constructor.js
Spec text
Bug: v8:11544
Change-Id: Icd290905b65fdabbedece27e59c785635c212ec2
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82185}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #144
commit 3f0c44148d212f96f8d3cdc5b1f210382bfaea51
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 10 07:26:14 2022
[Temporal] Fix ToRelativeTemporalObject
Change to use Handle<Object> instead of Handle<String>
for calendar and offset_string.
Spec text:
Bug: v8:11544
Change-Id: Ia9051f176e0e91a362b0c6b9edf6fea5a53ddcf2
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82363}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #145
commit 267889f6c2e25480ab7e4d773a40965ffc41e2c8
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 10 23:03:44 2022
[Temporal] Fix bug in ScanCalendarDateTimeTimeRequired
Split from cl/3822342
Should advance the length of the TimeZone
Spec Text:
Bug: v8:11544
Change-Id: Ic16a16ac41c29cb04136030b2f2c8b78022f8241
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82367}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #146
commit eb6dfc67fa126283dfae127ed30122d5162a6351
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 02:44:48 2022
[Temporal] Fix Calendar dateAdd
Sync to spec to allow BalanceDuration to throw.
Spec text:
PR change:
split from cl/3750098
Bug: v8:11544
Change-Id: I5a73dede2335bcf3f3e61a0ce789555671e5dda5
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82402}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #147
commit ca43e2d0f86abcd7fc1ca405fc68664b1f10ae76
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 01:15:12 2022
[Temporal] Remove unnecessary code
Remove the unnecessary int64_t version of RoundNumberToIncrement
and remove the unneeded RoundHalfAwayFromZero. Change the type of the
increment to double from int64_t.
split from cl/3750098
Bug: v8:11544
Change-Id: I591486c472e9c1343306ff9a1d0384d06fe01835
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82403}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #148
commit c54ba26acc80ca3fef50f3d201abf9052be53df8
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 01:39:01 2022
[Temporal] Use the BigInt version of BalanceDuration
in AdjustRoundedDurationDays
Bug: v8:11544
Change-Id: I5067aba802b5051312afdd38b0f9c71bfdc14c2a
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82404}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #149
commit d9f589730f73b7ce796b61d7dac2ab321cc7fe8a
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 06:03:01 2022
[Temporal] Mark fixed tests
Bug: v8:11544
Change-Id: Iefd64619e6361683e70fdac26d155aa8d27da9e5
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82405}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #150
commit 6033866bd41d0ae598663586e7cdd014dee2cad3
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 20:52:19 2022
Revert "[Temporal] Mark fixed tests"
This reverts commit d9f589730f73b7ce796b61d7dac2ab321cc7fe8a.
Reason for revert: Break UBSAN
Original change's description:
Bug: v8:11544
Change-Id: I5501bf416345a69508a07f4bbe70bb300f49c296
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82406}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #151
commit cf765fc3485555d647b01c27638e4ce1a761d9eb
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 22:28:46 2022
[Temporal] Use double instead of int32_t for input of BalanceTime
To avoid overflow int32_t in the math of balancing time.
Bug: v8:13182, v8:11544
Change-Id: Ib76cf95bbd4f9b47efd6921a67b09d3024e72b13
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82409}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #152
commit a8dc8823b28b022981ff310b4c5e878194588347
Author: Adam Klein <adamk@chromium.org>
Date: Fri Aug 12 00:39:25 2022
Revert "[Temporal] Use double instead of int32_t for input of BalanceTime"
This reverts commit cf765fc3485555d647b01c27638e4ce1a761d9eb.
Reason for revert: fixes more tests than expected in test262:
Original change's description:
Bug: v8:13182, v8:11544
Change-Id: Id7dd491b4485d13b0e2cc6aae8603479c7949ce8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Auto-Submit: Adam Klein <adamk@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#82413}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #153
commit eaa1c536aaf7572b5b71fa7dc704f9dc306225e0
Author: Frank Tang <ftang@chromium.org>
Date: Fri Aug 12 02:42:38 2022
Reland "[Temporal] Use double instead of int32_t for input of BalanceTime"
This is a reland of commit cf765fc3485555d647b01c27638e4ce1a761d9eb
Original change's description:
Bug: v8:13182, v8:11544
Change-Id: I7550b3a7186beed0e32e95a41cae87030d0c5a7c
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82445}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #154
commit 5bc20acb0fa78daf8c60f6ac135d04503010a08c
Author: Frank Tang <ftang@chromium.org>
Date: Fri Aug 12 22:42:34 2022
[Temporal] Add since/until to PlainDateTime and ZonedDateTime
Also add AOs: DifferenceTemporalPlainDateTime, DifferenceTemporalZonedDateTime,
Spec Text:
split from cl/3750098
Bug: v8:11544
Change-Id: I326d91a897fcd7e39de2fb2bfecfc5bfd920eb44
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82447}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #155
commit a4bb60e96d0c994e8db7ab246dd614a3ccf00bea
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 11 01:31:34 2022
[Temporal] Remove the int64_t between BigInt to double conversion
Bug: v8:11544
Change-Id: I41662b3c43a1a387f3c11796774999e515b00a32
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82450}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #156
commit ca9b931994757e58a82e669951c71d325b87a1ff
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 13 00:04:13 2022
[Temporal][intl] Implement real toLocaleString for Temporal
Also change Intl.DateTimeFormat to take temporal objects for format.
Design doc:
Implement the intl enabled
Temporal.Instant.prototype.toLocaleString, Temporal.PlainDate.prototype.toLocaleString
Temporal.PlainDateTime.prototype.toLocaleString
Temporal.PlainMonthDay.prototype.toLocaleString
Temporal.PlainTime.prototype.toLocaleString
Temporal.PlainYearMonth.prototype.toLocaleString
Temporal.ZonedDateTime.prototype.toLocaleString
Implement AOs:
HandleDateTimeTemporalDate, HandleDateTimeTemporalYearMonth, HandleDateTimeTemporalMonthDay, HandleDateTimeTemporalTime
HandleDateTimeTemporalDateTime, HandleDateTimeTemporalInstant, HandleDateTimeTemporalZonedDateTime, HandleDateTimeOthers, HandleDateTimeValue
Spec Text:
Temporal.PlainDateTime.prototype.toLocaleString
Remove the output_range parameter and use the is_null() of
MaybeHandle<T> for to check the optional return.
Bug: v8:11544
Change-Id: Ia9ffe7a71c8fb68391581eb5ef7620708e2bd1f0
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82453}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #157
commit 20f232060d7f0addba1d647ebe960b2e25e89734
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 16 07:29:13 2022
[Temporal] Change TotalDurationNanoseconds to return BigInt instead of double
TotalDurationNanoseconds previously return a double to represent the
total duration nanoseconds, but the value could be easily bigger than
the precise value a double can represent. A double can precisely
represent integer to 2^53, which is only about 104 days if that value
is nanoseconds. So we need to change the return type to BigInt.
Refactor BalanceDuration to merge common code.
Change JSTemporalDuration::Compare to use the BigInt version of
TotalDurationNanoseconds
Change the call site of TotalDurationNanoseconds in RoundDuration
Add newly defined BalancePossiblyInfiniteDuration and change
BalanceDuration to call it.
Spec text:
Split from changes in cl/3750098
Bug: v8:11544
Change-Id: Ia4ca8f9bdba49c3a5e54edeef0d2a5833b0002a2
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82475}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #158
commit c7804c7bfb6f1fb4907ca2d2ecb99c4a9680f970
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 16 17:52:48 2022
[Temporal] Add IsValidEpochNanoseconds to NanosecondsToDays
Sync to
Use Smi::zero instead of BigInt::FromInt64(isolate, 0)
Rework the BigInt comparions code
Bug: v8:11544
Change-Id: I8b85156927601aad272b10c35ae15fd1c65e01c4
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82502}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #159
commit 967a3b484700ec059823b1265e47cccaaa760ff8
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 16 21:42:36 2022
[Temporal] Mark fixed tests
Bug: v8:11544
Change-Id: Iaf285f431e742e607e09d37c47a94d3f86806b13
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82507}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #160
commit a9ed44ba39706547e5e3c1139bcd622452f535c5
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 00:22:20 2022
[Temporal] Sync to PR 1685
Pass undefined for option in calendar monthDayFromFields and
yearMonthFromFields
Bug: v8:11544
Change-Id: I3fd37e176bd83dc0b01d92a3c323d2933291c49b
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82544}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #161
commit d4122c665aa72769e3775e9b908a2489516f31a9
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 04:28:02 2022
[Temporal] Group invalid calendar-number test together
See issues in
and
Bug: v8:11544
Change-Id: Iefe6353e95178e1241a7f29c80b24baad2a8428d
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82545}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #162
commit a94b566a75beafe14c04f1b946d9660d2e94f50d
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 02:07:06 2022
[Temporal] Sync to PR 1954
Move calendar validation out of ParseTemporalCalendarString
Spec PR
Bug: v8:11544
Change-Id: I4dbfcba1a9f5940d5692547b7ea212ebe45ca341
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82546}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #163
commit 7e86bb86f181e6b958d55488568acb6bcadbe93f
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 00:43:00 2022
[Temporal] Sync to PR 2295
Pass OrdinaryObjectCreate(*null*) to DifferenceISODateTime in NanosecondsToDays
and to DifferenceZonedDateTime in AddDuration
Bug: v8:11544
Change-Id: Ied1860b755b1cebd0fbcbc4bd574cd525f108378
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82547}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #164
commit d5f29b929ce7746409201d77f44048f3e9529b40
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 21:01:37 2022
[Temporal] Fix limits tests
1. Add if/throw based on IsValidEpochNanoseconds()
in DisambiguatePossibleInstants, ParseTemporalInstant, GetIANATimeZoneEpochValueAsArrayOfInstantForUTC,
GetIANATimeZoneEpochValueAsArrayOfInstant,
JSTemporalTimeZone::GetPossibleInstantsFor, and
InterpretISODateTimeOffset(
2. Add assert IsValidEpochNanoseconds in GetISOPartsFromEpoch
3. Fix ISODateTimeWithinLimits
These changes are syncing of the following PRs:
Spec Text:
Bug: v8:11544
Change-Id: I38244d039f33e294b698d470b587b1b44b72fa09
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82548}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #165
commit 3752ce19466389c5f72a3cd368280c5b3bf8c069
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 18 01:35:31 2022
[Temporal] Fix fractional second rounding in ParseTemporalDurationString
Spec text:
Bug: v8:11544
Change-Id: I2d54759c07529f95c7a27c334ee5d3fa6760b2e0
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82569}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #166
commit 0cf8befb4e7fde0257819e933c0fb1e5048f196a
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 17 22:51:45 2022
[Temporal] Fix relativeTo passing bug
Fix BalanceDuration to pass relativeTo to BalancePossiblyInfiniteDurationResult
and then pass to NanosecondsToDays.
The bug is introduced in
The spec text in 4-a of BalancePossiblyInfiniteDuration is
"a. Let result be ? NanosecondsToDays(nanoseconds, relativeTo)."
but the code wrote
"a. Let result be ? NanosecondsToDays(nanoseconds, *undefined*)."
Spec Text:
Bug: v8:11544
Change-Id: I3ea9a3b71521cdcc210e9db370d6e849fcde56ee
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82570}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #167
commit 4db42a36ef2fb5b8ef16413d66e2981e3dafbd8c
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 18 18:27:01 2022
[Temporal] Fix Duration ToString
Use SNPrintf to handle bigger unit duration fields.
Spec Text:
Fix test:
Bug: v8:11544
Change-Id: I63a6e823652a0826216593cd153ef5103f94e7a9
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82573}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #168
commit a8cb3cef03aea1d119e00d256cc6993acd46f49b
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 18 21:17:32 2022
[Temporal] Avoid double overflow in AddDuration
Add a version of BalanceDuration which take two TimeDurationRecord
and add them internally after converting to BigInt as nanoseconds so it will not overflow the double.
Use "std::isinf()" instead of "!std::isfinite()"
Inspired by
Bug: v8:11544
Change-Id: I29e06fa857ff43f2668e1e4ffd07735ff6efee42
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82576}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #169
commit 4b14efad6103e065434841ec9d13090a03e50ddb
Author: Frank Tang <ftang@chromium.org>
Date: Mon Aug 22 21:17:44 2022
[Temporal] Add Calendar.prototype.weekOfYear
Also add AO: ToISOWeekOfYear
Spec Text:
Note- this is only the non-intl version. intl version in
will be implemented in later cl.
PR
Sync spec text for ToISODayOfYear and ToISODayOfWeek
in the comment and add DCHECK for assertion.
Bug: v8:11544
Change-Id: If07ff76551707d17d125e41bc624c12da6efa45a
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82733}
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #170
commit a165e82ea79130243e9934b8f6c2bb09021ba9ae
Author: Frank Tang <ftang@chromium.org>
Date: Fri Aug 26 20:44:44 2022
[Temporal] Use double/int32_t instead of int64_t for duration parsing
Use double instead of int64_t and int32_t in duration parsing result
so we can parse very large duration fields as infinity and throw RangeError in later stages. The three fractional parts can hold up value from 0 to 999,999,999 so we use int32_t to hold it. Other part could be infinity so we use double to hold it. Also rearrange the order of the three int32_t in the struct ParsedISO8601Duration after all the double
Bug: v8:11544
Change-Id: I7e5b02f7c7bbb60997f1419f016aed61dd3e0d6c
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82754}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #171
commit 8ff03afee071565c5fab8b72c814ace55a354fd3
Author: Frank Tang <ftang@chromium.org>
Date: Fri Aug 26 22:39:42 2022
Revert "[Temporal] Use double/int32_t instead of int64_t for duration parsing"
This reverts commit a165e82ea79130243e9934b8f6c2bb09021ba9ae.
Reason for revert: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/objects/js-temporal-objects.cc:3837:22
Original change's description:
Bug: v8:11544
Change-Id: Ia9d0a014463b00640d43b051753a554f42171c2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82755}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #172
commit 88a8b5358b7b4b66e2a20e67f9e4b91b07f47880
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 25 05:17:39 2022
[Temporal] Sync PR 2344 change BalanceDurationRelative by using newRelativeTo to store info
Spec Change PR:
Relative tests in test262 are
built-ins/Temporal/Duration/prototype/round/february-leap-year.js
Bug: v8:11544
Change-Id: Id31648436f629a8adf395e3b4c835adf46a2c455
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82757}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #173
commit af04e3c3c17c4d56b720a7ce5b16c0ca832aa5f3
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 27 02:25:43 2022
[Temporal] Sync PR 2269 change toString by calling MaybeFormatCalendarAnnotation
Sync
Add AO MaybeFormatCalendarAnnotation
Use MaybeFormatCalendarAnnotation in
TemporalDateToString
TemporalDateTimeToString
TemporalZonedDateTimeToString
Spec text:
Bug: v8:11544
Change-Id: Ia361b1cba1b2e9db77125a8888054cfd89626611
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82758}
[modify]
[modify]
sy...@chromium.org <sy...@chromium.org> #174
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #175
commit f54b1eb461b13635c3f63dd3c34271e0d45004ca
Author: Frank Tang <ftang@chromium.org>
Date: Thu Aug 25 06:36:18 2022
[Temporal] Sync PR 2225 Consistently check overflow options
Call ToTemporalOverflow in ToTemporalDate and ToTemporalDateTime
Spec Text:
Bug: v8:11544
Change-Id: I3d2846e2efc214ea5385be58cb49e319369b5900
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82797}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #176
commit f03d02e23f5195ebe12d482e9ed983af7772b992
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 27 05:42:54 2022
[Temporal] Sync PR 2261
Disallow negative day lengths as round result
PR
Also fix the missing extraValues=<"day"> to GetTemporalUnit
Spec Text:
Bug: v8:11544
Change-Id: Ibc963d5d93dde30f29df707ef3b3ecea99cd4a60
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82798}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #177
commit 0f901f00e88e73e162c69d4307b9e2a84c88ee3b
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 30 03:24:15 2022
[Temporal] Sync PR 2297 change ToSecondsStringPrecision
Validate fractionalSecondDigits after truncation
Spec text:
Bug: v8:11544
Change-Id: I648f087f4fa2cfd6245c7946cfa625a7c5e3b3b9
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82801}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #178
commit f5ef68dead4d27e3c59901d40f7e571ca1033d33
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 30 03:30:07 2022
[Temporal] Fix TimeZone getPossibleInstantsFor
Subtract timeZone.[[OffsetNanoseconds]] from epochNanoseconds
before calling the IsValidEpochNanoseconds() for the case of
4. If timeZone.[[OffsetNanoseconds]] is not undefined
Bug: v8:11544
Change-Id: Icea2d8390a9db01054956f8c57b47dc5a88446d4
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82802}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #179
commit 87ba2e2e11db3366fcd6cb59a7e6866d7b4f05a2
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 30 05:13:53 2022
[Temporal] Sync PR 2266 add ISODateTimeWithinLimits to CreateTemporalMonthDay
PR
Disallow arbitrary integers for the reference ISO year in PlainMonthDay
Spec text:
Also add missed assertion of calling ISODateTimeWithinLimits
Bug: v8:11544
Change-Id: Idd18428f3e6e6af53c2c207652688af269746782
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82804}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #180
commit b7fd6e237c7f9a449ed6d5113334b962cc2f6c57
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 27 06:13:38 2022
[Temporal] Sync PR 2203 ISOMonthDayFromFields
Adjust order of operations in ISO{Date,MonthDay}FromFields
Spec text:
Bug: v8:11544
Change-Id: I4ae945656e3f35d0af422ee86e1f5108a350b6a6
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82845}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #181
commit 89655531ff57e659d9ea611832192d2259a7d0b8
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 30 06:59:38 2022
[Temporal] Sync PR 2219 to use OrdinaryObjectCreate(*null*) impact add/subtract
Sync to
Also sync the MergeLargestUnitOption to latest spec
Change some of the type from JSObject to JSReceiver based on the code
change.
Change AOs: MergeLargestUnitOption, PrepareTemporalFields,
AddDurationToOrSubtractDurationFromPlainYearMonth
Spec text:
Change the parameter or return from type Handle<Object> to Handle<JSReceiver> in
DifferenceISODateTime, PrepareTemporalFieldsOrPartial,
PrepareTemporalFields, PreparePartialTemporalFields,
MergeLargestUnitOption
Bug: v8:11544
Change-Id: I30e997521f0ed644f5ec50d0982acf1e12f2977d
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82846}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #182
commit d42f2801dbcfc5e8c75f2c765fad6240ed9f3eb7
Author: Frank Tang <ftang@chromium.org>
Date: Wed Aug 31 05:40:51 2022
[Temporal] Unskip fixed tests.
We fixed the test earlier but forgot to remove the SKIP.
Bug: v8:11544
Change-Id: I6594dc2ad07fe88fdc2ed9bfaa0f0715bc14930b
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82874}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #183
commit edb902d99e640e2c2863eb89ef0a58d3247104a2
Author: Frank Tang <ftang@chromium.org>
Date: Sat Aug 27 07:54:55 2022
[Temporal] Fix bug in RoundDuration
Access the correct years, months and weeks which modified previously
instead of the value from the input.
Spec text:
Bug: v8:11544
Change-Id: I2ffaca5545e2359bc1cc03320068424bba4c7907
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83045}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #184
commit 0b670eef36a8ce29648747a77205521873c9b99f
Author: Frank Tang <ftang@chromium.org>
Date: Tue Aug 30 06:25:31 2022
[Temporal] Fix bug in DifferenceTemporalPlainDateTime
The days is passing incorrectly between calls.
Spec text:
Bug: v8:11544
Change-Id: If818d0f42bdd3260e68eef2c6aba1c3781632c93
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83046}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #185
commit 95b02431bdef1a34bec401bb1ab67132bae58a41
Author: Frank Tang <ftang@chromium.org>
Date: Thu Sep 08 04:34:11 2022
[Temporal] Fix AddInstant and AddZonedDateTime
Change AddInstant to use BigInt::FromNumber(isolate, factory->NewNumber
instead of BigInt::FromInt64 to convert from double to BigInt.
Sync AddZonedDateTime with
Spec Text:
PR:
Bug: v8:11544
Change-Id: I4bd176294780f761341c25a5f71643b437f99c82
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83088}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #186
commit 14d9b9a246a47948efad6d723a644404c264b623
Author: Frank Tang <ftang@chromium.org>
Date: Thu Sep 08 21:18:54 2022
Reland "[Temporal] Use double/int32_t instead of int64_t for duration parsing"
This is a reland of commit a165e82ea79130243e9934b8f6c2bb09021ba9ae
The reason of revert is SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/objects/js-temporal-objects.cc:3837:22 which is the line
"nanoseconds_mv = std::round((seconds_mv - std::floor(seconds_mv)) * 1e9);"
where seconds_mv is a double and nanoseconds_mv is a int32_t
In this reland, we change the type of nanoseconds_mv to double to avoid the ubsan error.
Original change's description:
Bug: v8:11544
Change-Id: If8b72cb4912d8b4fc4c286fc856ea59df5cf0bb7
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83090}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #187
commit a4afe1a09fc7a7bf986abbec4b17a3725d01cad3
Author: Frank Tang <ftang@chromium.org>
Date: Fri Sep 09 03:16:08 2022
[Temporal] Remove passing tests
Bug: v8:11544
Change-Id: I23435db7f625ee35f560fd84ee98d481081fb5ff
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83092}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #188
commit 093e68b408d8fceaa68f14185e17da90cb272050
Author: Frank Tang <ftang@chromium.org>
Date: Sat Sep 10 03:21:33 2022
[Temporal] Sync the Parser to the latest spec.
Add TimeHourMinuteBasicFormatNotAmbiguousWithMonthDay
TimeZoneNumericUTCOffsetNotAmbiguousWithDayOfMonth
TimeZoneNumericUTCOffsetNotAmbiguousWithMonth
TimeZoneIdentifier, UnpaddedHour, TimeZoneIANALegacyName productions.
Sync the spec of TemporalInstantString, TemporalTimeString
TimeZone, TimeZoneBracketedAnnotation, TemporalTimeZoneString,
ToTemporalTimeZone, TimeZoneIANAName productions.
Fix bug in ScanCalendarDateTimeTimeRequired, ToTemporalTimeZone
Change name from Handle<String> to Handle<Object> to hold undefined
Update parser tests accordingly.
Spec Text:
Related PR changes:
Bug: v8:11544
Change-Id: I6f1a5e5dedba461db9f36abe76fa97119c1f8c2c
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83123}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #189
commit bc0e7c8722b81d92fe3c2e35da5457c25574e07e
Author: Frank Tang <ftang@chromium.org>
Date: Sat Sep 10 21:52:45 2022
[Temporal] Fix weekOfYear by passing undefined
Not passing null object but passing undefined while calling
ToTemporalDate()
Bug: v8:11544
Change-Id: I9376c32f306b000980d37bf233ffef3e83baf706
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83124}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #190
commit 0381aead8451746dfff14d3de82b443c67ecf62c
Author: Frank Tang <ftang@chromium.org>
Date: Mon Sep 12 23:12:23 2022
[Temporal] Sync BalanceISODate to PR 2178
Only change the implementation in BalanceISODate from
Changes of other AOs in that PR is not in this cl.
Note: Split from cl/3864358
Bug: v8:11544
Change-Id: I8c8514642cdb522975b23bcc9c2bb9eb56cb2839
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83141}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #191
commit edb57e37ae2b86e10c4cf2532f96cf71d67047b8
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 13 17:30:05 2022
[Temporal] Fix TimeZone get*Transition
1. Return null if the transition is out of bound.
2. Remove incorrect MAYBE_RETURN which is handled by the IsNothing check.
Bug: v8:11544
Change-Id: Ia54f68831120bd2460cb813464168b1a2c92da3d
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83171}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #192
commit 2847ad2e2027591e2b35e03beb61b1015f47f201
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 13 06:56:51 2022
[Temporal] Sync to PR 2291
Remove RegulateISODate after BalanceISODate and inline one call to AddISODate
Spec Text:
Bug: v8:11544
Change-Id: I4d5faaa48a26d37015c82bc06b3414698db9945d
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83172}
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #193
commit c8b4b66fe925b4f1adbdfaab1e9fe81003c69e89
Author: Frank Tang <ftang@chromium.org>
Date: Wed Sep 14 19:00:05 2022
[Temporal] Fix Instant rounding
Sync with 2210 and 2240
Add AO: RoundNumberToIncrementAsIfPositive
Change AO parameter: DifferenceInstant
Spec:
Bug: v8:11544
Change-Id: I6b613bd19014d770852b9ba587278e714f9ac110
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83204}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #194
commit b6f32720dde9ba7d63e8e1318fe26569cae20d15
Author: Frank Tang <ftang@chromium.org>
Date: Wed Sep 14 18:56:22 2022
[Temporal] Fix DST handling
Correct the call the the one which take the UTC based time
instead of the one taking the local wall time.
Bug: v8:11544
Change-Id: Ib288617e8f98b21865c306ca36cd905a3e5315bd
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83205}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #195
commit adc30b07c0d0cd0d451e49299476cdbb67dfe1e2
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 13 20:27:04 2022
[Temporal] Fix timezone and calendar parsing issue
Need to reset tzi_xxx and calendar_xxx in parser state if the
post-condition of CalendarName and TimeZoneIdentifier is not met.
Bug: v8:11544
Change-Id: If2df6c8fc8cf2418ddd5443abab02066d423a0c3
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83236}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #196
commit 4b0e8569cc7047ee1964ea1dd9acada1260bdfce
Author: Frank Tang <ftang@chromium.org>
Date: Fri Sep 16 19:56:08 2022
[Temporal] Add ParseTimeZoneIdentifier ParseCalendarName to parser
Needed for
and also
Bug: v8:11544
Change-Id: Ieb946abde1c623e9edcca608d737e8bf65a34637
Reviewed-on:
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83281}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #197
commit b16aa83fee013040e538469d68bd4d3c50849bc8
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 20 00:02:25 2022
[Temporal] Fix DST transition
Refactor the interface between intl and Temporal and pass
the nanosecond in BigInt to intl. Approximate the nanoseconds
to the correct close by millisecond depending on the usage
before calling ICU API and convert the result millisecond into
BigInt in nanosecond before return from intl.
Remove Maybe for function always complete.
Bug: v8:11544
Change-Id: Icc471b80312c513c9415b690804aa624df4a387d
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83310}
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #198
commit fe1245edf8f54f2f456b45bed35d149515bf4ed0
Author: Frank Tang <ftang@chromium.org>
Date: Sat Sep 17 02:19:12 2022
[Temporal] Fix ZDT hoursInDay for non-integer hours
The hoursInDay could be fractional number on the date of changng
daylight saving time for time zone in half hours or some historical time
zone.
Ex: Australia/Lord_Howe on Sunday, April 3, 2022, 2:00:00 am clocks were
turned backward 0:30 hours to Sunday, April 3, 2022, 1:30:00 am local
standard time instead. so that day will have 24.5 hours.
On Sunday, October 2, 2022, 2:00:00 am clocks are turned forward 0:30
hours to Sunday, October 2, 2022, 2:30:00 am local daylight time
instead. So the hoursInDay for that day is only 23.5 hours.
Historically, Singapore from 1933 to 1941 moved clocks forward 20 minutes for daylight savings, resulting the day in 24.33333 and
23.66667 hours.
Test covered in
Change the return type from MaybeHandle<Smi> to MaybeHandle<Object> so
we can return non integer value. Also change the method of division by
first convert the value to second in BigInt, then divid 3600 (number of
seconds in a hour) in double.
Bug: v8:11544
Change-Id: Ia69d2606cd832e51f415a00440fb9cbc236883e4
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83311}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #199
commit 20db58cb52606e38143c2ec3962c3adf3d466774
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 20 04:15:00 2022
[Temporal] Fix Duration toJSON/toString
1. Correct the return type of RoundTowardsZero to fix issue with
double value > 2^64
2. In TemporalDurationToString:
a. Use std::fmod instead of % to get the remainder
b. Use extra xx_add variables to hold additional value which may
overflow the double during computation.
c. Use BigInt for days if the value is too large for double
to ensure the precision.
3. Add tests with Number.MAX_SAFE_INTEGER
and Number.MAX_VALUE in values for Duration toJSON in mjsunit
Bug: v8:11544
Change-Id: Icac4f669ed1c591e947b51c82dd48bdef7a6db6e
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83344}
[add]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #200
commit e42eed1255c6f53b95c0573a92a096c0c0c45714
Author: Frank Tang <ftang@chromium.org>
Date: Tue Sep 20 02:38:02 2022
[Temporal] Sync to PR 2385
Changes in preparation for incorporating IETF draft
The changes in this CL is needed to implement
and several other PR just agreed on TC39
Rename DateRecord => DateRecordWithCalendar
Rename TimeRecord => TimeRecordWithCalendar
Rename DateTimeRecord => DateTimeRecordWithCalendar
Rename DateRecordCommon => DateRecord
Rename TimeRecordCommon => TimeRecord
Rename DateTimeRecordCommon => DateTimeRecord
Bug: v8:11544
Change-Id: I77397363569c15320154fe0b226036f8d6df74a3
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83375}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #201
commit 3f3c51e0d94faf1c1b282024f0de53b470737849
Author: Frank Tang <ftang@chromium.org>
Date: Sat Sep 17 01:57:48 2022
[Temporal] Sync PR2260 Disallow one day long time zone offsets
Spec text:
Bug: v8:11544
Change-Id: I107372ba883f97c1bf74b96cd0f592d47aa1f359
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83376}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #202
commit 97c0084b1ce22e74680e1d4663bb6f2042598849
Author: Frank Tang <ftang@chromium.org>
Date: Thu Sep 22 07:10:42 2022
[Temporal] Fix TemporalCalendarString ambiguity #2394
Sync with
to fix TemporalCalendarString ambiguity issues
Spec text:
Bug: v8:11544
Change-Id: I31d0255e55d1a432681fd060cf4f841cb1479480
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83409}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #203
commit 25ae9851d87b71ca08e9460ecbf2ffead096911c
Author: Frank Tang <ftang@chromium.org>
Date: Thu Sep 22 07:49:00 2022
[Temporal] Sync PR2377 order of observable in ...FromFields()
Sync to the spec/calendar.html changes in
to change the order of calling ToTemporalOverflow.
This cl only cover the ISO8601 part, the the intl part of the PR
is not yet implemented and will be handle when e implemenet them.
Spec text:
Bug: v8:11544
Change-Id: Ia4386d460dc45b0b377a483c6f4793da4cbd7c20
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83410}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #204
commit de1d7b33d6141a53eb6db17a5b309d06a9d85348
Author: Frank Tang <ftang@chromium.org>
Date: Sat Sep 24 06:28:46 2022
[Temporal] Clean up parser
Remove unused parser function/rule
ParseTemporalTimeZoneString and ParseTemporalCalendarString
were obsoleted by PR 2385 and 2394
in
This cl is purely unused code removal.
Bug: v8:11544
Change-Id: Ib7ff4a3860cffa09afe7c7f6866f8dc526273f34
Reviewed-on:
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83460}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #205
commit 85e384960c27406aac93d88bcffcbe80a1020e9a
Author: Frank Tang <ftang@chromium.org>
Date: Tue Oct 04 09:37:08 2022
[Temporal] Sync Rounding Mode
Sync to PR
add "expand", "halfCeil", "halfFloor", "halfTrunc", and "halfEven"*
rounding mode.
Bug: v8:11544
Change-Id: I8f7787a2d0743acc6a3b1ad43f370089ce405b8b
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83523}
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #206
commit 8e3b455f53fadb18ad3ee4f87334f22772c83aeb
Author: Frank Tang <ftang@chromium.org>
Date: Fri Nov 04 21:20:14 2022
[Temporal] Sync to PR2395 Address calendar case sensitivity
This cl only convert the part for calendar in PR2395.
The part to cover TimeZone change will be coded in another cl.
Spec Text:
Spec change
PR2395 achieved consensus at the September 2022 TC39 meeting.
Also merge unnecessary const std::string& id version of IsBuiltinCalendar to the Handle<String> version and remove the unnecessary version.
Bug: v8:11544
Change-Id: Idb711d48dbcf929059b71c48681c03b30089adb0
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84073}
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #207
commit 6e15c8c638c98c6c42aab95a11fc78481b3bcc83
Author: Shu-yu Guo <syg@chromium.org>
Date: Fri Mar 03 00:58:15 2023
[test262] Roll test262
Bug: v8:7834, v8:11544, v8:13791
Change-Id: Ieaf516ab21754713e7a5546787f2fb6327597a17
Reviewed-on:
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86236}
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
va...@gmail.com <va...@gmail.com> #208
A few lines later it also gets declared without the typo, which probably explains why it went unnoticed for a while.
is...@google.com <is...@google.com> #209
[Auto-CCs applied]
[Multiple monorail components: Internationalization, Language]
[Monorail blocked-on:
[Monorail components added to Component Tags custom field.]
dx...@google.com <dx...@google.com> #210
Project: v8/v8
Branch: main
Author: Manish Goregaokar
Link:
[temporal] Remove JSTemporalCalendar, stub out the bulk of the Temporal code
Expand for full commit details
Bug: 42201538
Change-Id: If8a8dc1e22259e68a683af12c29e154a69ed0667
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6508227
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100130}
Files:
- M
BUILD.bazel - M
BUILD.gn - M
src/builtins/builtins-definitions.h - M
src/builtins/builtins-temporal-gen.cc - M
src/builtins/builtins-temporal.cc - M
src/compiler/turbofan-types.cc - M
src/diagnostics/objects-printer.cc - M
src/init/bootstrapper.cc - M
src/objects/contexts.h - M
src/objects/js-date-time-format.cc - M
src/objects/js-function.cc - M
src/objects/js-objects.cc - M
src/objects/js-temporal-objects-inl.h - M
src/objects/js-temporal-objects.cc - M
src/objects/js-temporal-objects.h - M
src/objects/js-temporal-objects.tq - M
src/objects/map.cc - M
src/objects/object-list-macros.h - D
src/runtime/runtime-temporal.cc - M
src/runtime/runtime.h - M
test/intl/intl.status - M
test/mjsunit/mjsunit.status - D
test/mjsunit/regress/regress-1385368.js - M
test/test262/test262.status
Hash: 36d8ea301b285323821b6da18026639d16df1d6f
Date: Thu Apr 17 21:45:06 2025
dx...@google.com <dx...@google.com> #211
Project: v8/v8
Branch: main
Author: Manish Goregaokar
Link:
[temporal] Add build flag for toggling temporal
Expand for full commit details
The Rust build doesn't yet work with Node, and we don't have a way of
doing 3p Rust dependencies in Bazel. This lets us disable Temporal in
those build environments for now.
Bug: 42201538
Change-Id: If25693f3f73a4967e46007736e56512f651f9a35
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6514659
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Cr-Commit-Position: refs/heads/main@{#100138}
Files:
- M
BUILD.bazel - M
BUILD.gn - M
gni/v8.gni - M
include/v8-internal.h - M
src/builtins/builtins-date.cc - M
src/builtins/builtins-definitions.h - M
src/builtins/builtins-temporal.cc - M
src/codegen/code-stub-assembler.cc - M
src/codegen/code-stub-assembler.h - M
src/compiler/turbofan-types.cc - M
src/diagnostics/objects-debug.cc - M
src/diagnostics/objects-printer.cc - M
src/init/bootstrapper.cc - M
src/objects/all-objects-inl.h - M
src/objects/intl-objects.cc - M
src/objects/js-date-time-format.cc - M
src/objects/js-duration-format.cc - M
src/objects/js-function.cc - M
src/objects/js-objects.cc - A
src/objects/js-temporal-helpers.cc - A
src/objects/js-temporal-helpers.h - M
src/objects/js-temporal-objects.cc - M
src/objects/js-temporal-objects.h - M
src/objects/map.cc - M
src/objects/object-list-macros.h - M
tools/gcmole/BUILD.gn
Hash: f9aac5fc7c22463ca34c9fc1baad4e9390d10466
Date: Mon May 5 23:05:38 2025
dx...@google.com <dx...@google.com> #212
Project: v8/v8
Branch: main
Author: Manish Goregaokar
Link:
[temporal] Add some APIs to Temporal Instant
Expand for full commit details
This switches Temporal Instant over to using a temporal_rs Instant
object for all of its computation.
It adds constructors, epoch getters, and `.round()`. All other methods
are still stubbed out (they depend on other types).
It also removes old methods like the `From` family and `Compare()` that
are no longer in the spec.
Bug: 42201538
Change-Id: Ic7c239e6ca2ba08bc76f8c8e50d8e62843101040
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6508228
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100162}
Files:
- M
src/builtins/builtins-date.cc - M
src/builtins/builtins-definitions.h - M
src/builtins/builtins-temporal.cc - M
src/common/message-template.h - M
src/init/bootstrapper.cc - M
src/objects/DEPS - M
src/objects/js-date-time-format.cc - M
src/objects/js-temporal-objects-inl.h - M
src/objects/js-temporal-objects.cc - M
src/objects/js-temporal-objects.h - M
src/objects/js-temporal-objects.tq - M
src/profiler/heap-snapshot-generator.cc - M
test/unittests/interpreter/bytecode_expectations/PrivateAccessorAccess.golden - M
test/unittests/interpreter/bytecode_expectations/PrivateMethodAccess.golden - M
test/unittests/interpreter/bytecode_expectations/StaticPrivateMethodAccess.golden
Hash: 76296945b6b695a08b5c6b2581460caa3dbd4293
Date: Wed Apr 30 21:05:19 2025
Description
- Removing subclassing support
- Stop comparing calendars as part of the comparison