Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

[Pull To Refresh][Bug] Avoid accidental refreshes by forcing a cooldown period after the last scroll gesture #16661

Closed
@mstange

Description

@mstange

Steps to reproduce

  1. On a scrollable page, scroll down.
  2. Scroll up to the top with a series of quick pans / flings.

Expected behavior

No pull refresh should be triggered during gestures that were intended to only scroll.

Actual behavior

As soon as the top edge of the page is hit, the next gesture instantly triggers pull to refresh.

This does not happen in Chrome. Chrome seems to enforce a cooldown period before pull to refresh is triggered. See this video for a comparison: quick-consecutive-flings.mp4

From experimenting, it feels like the cooldown period is somewhere between 300 and 500ms.

Device information

  • Android device: Moto G5
  • Fenix version: Firefox Nightly

┆Issue is synchronized with this Jira Task

Activity

Mugurell

Mugurell commented on Feb 2, 2021

@Mugurell
Contributor

Judging from the video and a quick test in Chrome,
There is no cooldown per se.
What happens on Chrome is that a swipe up and then down will trigger the overscroll effect instead of the pull to refresh throbber like it happens on Fenix.
Then if you continue to swipe down while the edge effect hasn't finished the gesture will trigger again the overscroll effect and it would be possible to keep this behavior with such swipes for a loong time.

That being said, we should probably do the same. Thank you for filing this!

stale

stale commented on Aug 1, 2021

@stale

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost

ghost commented on Sep 3, 2021

@ghost

I have a similar issue on div with scrollable layout (site without mobile layout), everytime I try to scroll down the content of div I got a refresh and not a scroll.
I use the tricks scroll down and to right. but not always works.

stale

stale commented on Mar 2, 2022

@stale

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale

stale commented on Nov 23, 2022

@stale

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

csadilek

csadilek commented on Dec 23, 2022

@csadilek
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @csadilek@mstange@Mugurell@ekager

      Issue actions

        [Pull To Refresh][Bug] Avoid accidental refreshes by forcing a cooldown period after the last scroll gesture · Issue #16661 · mozilla-mobile/fenix