Change 6367996: Add NotebookLM to ChromeOS preinstalled web apps
Change metadata
Change Info
Submit Requirements
|
|
|
|
|
|
|
|
|
|
|
Commit Message
Add NotebookLM to ChromeOS preinstalled web apps https://screenshot.googleplex.com/BwpwdpR6oxi6YaZ Bug: b:402986247 Change-Id: Idc96249539af70ca4d607b0877e2c86e55f8cb6a
Comments and Checks Summary
| Comments |
|
| Checks |
Fetching results...
|
Files and Comments tabs
Patchset Range Selection
File list
Owners
File
Comments
Size
Delta
-0
+2
-19
+99
Change Log
Commit-Queue
+1
Hidehiko Abe, who was added as reviewer owns the following files:
* `chrome/browser/ash/extensions/default_app_order.cc`
* `chrome/browser/web_applications/BUILD.gn`
* `chrome/browser/web_applications/preinstalled_app_install_features.cc`
* `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.cc`
* `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.h`
* `chrome/browser/web_applications/preinstalled_web_apps/preinstalled_web_apps.cc`
* `chromeos/constants/chromeos_features.cc`
* `chromeos/constants/chromeos_features.h`
Colin Blundell, who was added as reviewer owns the following files:
* `ash/constants/web_app_id_constants.h`
* `chrome/browser/ash/extensions/default_app_order.cc`
* `chrome/browser/web_applications/BUILD.gn`
* `chrome/browser/web_applications/preinstalled_app_install_features.cc`
* `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.cc`
* `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm
This CL has passed the run
Thanks! Can you ping when Hidehiko gives his LGTM for the main review and I can stamp for anything left? I defer to him on the technical review here.
LGTM
//ash lgtm, thanks!
Uploaded patch set 5.
headers
Outdated Votes:
* Code-Review+1 by Colin Blundell, Hidehiko Abe (copy condition\*: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR (**has:unchanged-files** AND uploaderin:cria/project-chromium-committers) OR is:MIN")
\* The label has `labelCopyEnforcement` or `labelCopyRestriction` configured. Only the most relevant condition that determined the outcome is shown.
Commit-Queue
+2
Chromium LUCI CQ
on behalf of
Alan Cutter
Commit-Queue 0 (vote reset)
CV cannot start a Run because this CL is not satisfying the `Code-Review` submit requirement. Please hover over the corresponding entry in the Submit Requirements section to check what is missing.
Uploaded patch set 6.
about flags
Commit-Queue
+1
Dry run: CV is trying the patch.
Follow status at: https://luci-change-verifier.appspot.com/ui/run/chromium/8880519874854-1-f4ada94b7403d4f8
Bot data: {"action":"start","triggered_at":"2025-03-20T06:08:42Z","revision":"c913ae07bf20183fd90dbc2aab8ef8c5b2f25bdf"}
Chromium LUCI CQ
on behalf of
Alan Cutter
Commit-Queue 0 (vote reset)
This CL has failed the run. Reason:
Tryjob [chromium/try/linux-chromeos-rel](https://cr-buildbucket.appspot.com/build/8719901486255049441) has failed with summary ([view all results](https://chromium-review.googlesource.com/c/6367996?checksPatchset=6&tab=checks)):
---
1 Test Suite(s) failed.
**unit_tests** failed because of:
- AboutFlagsTest.EveryFlagHasMetadata
could you fix bot failure?