Add NotebookLM to ChromeOS preinstalled web apps (6367996) · Gerrit C…

archived 21 Mar 2025 10:45:17 UTC
Unable to get outage announcements from ChOpsDash.
X

Change 6367996: Add NotebookLM to ChromeOS preinstalled web apps

Active
6367996 arrow_drop_down Add NotebookLM to ChromeOS preinstalled web apps
content_copy
more_vert

Change metadata

Change Info

Show All expand_more
Updated 4:13 AM
Owner
label_important
Alan Cutter
Reviewers
label_important
Colin Blundell
label_important
Alan Cutter
CC
Repo | Branch chromium/src | main
Parent
Strategy Rebase Always
Hashtags

Submit Requirements

block Code-Review No votes
check_circle Code-Coverage No votes
check_circle Code-Owners Approved

Commit Message

Sign in
Add NotebookLM to ChromeOS preinstalled web apps

https://screenshot.googleplex.com/BwpwdpR6oxi6YaZ

Bug: b:402986247
Change-Id: Idc96249539af70ca4d607b0877e2c86e55f8cb6a

Comments and Checks Summary

Comments
Checks
Fetching results...
warning
Fetching results...

Files and Comments tabs

Files
Comments
Checks

Patchset Range Selection

Base arrow_drop_down Patchset 6 arrow_drop_down
c913ae0
content_copy
Download Expand All

File list

Owners
File
Comments
C
Size
Delta
|Cov|
ΔCov
|Cov|(U)
ΔCov(U)
|Cov.|
ΔCov.
Commit message Commit message
content_copy
No comments
No comments
-0 +12
-
-
-
-
-
-
expand_more
help
ash/constants/web_app_id_constants.h …/web_app_id_constants.h
content_copy
No comments
No comments
-0 +4
-
-
-
-
-
-
expand_more
help
chrome/browser/about_flags.cc …/about_flags.cc
content_copy
No comments
No comments
-0 +9
-
-
-
-
-
-
expand_more
help
chrome/browser/ash/extensions/default_app_order.cc …/default_app_order.cc
content_copy
No comments
No comments
-0 +2
-
-
-
-
-
-
expand_more
help
chrome/browser/flag_descriptions.h …/flag_descriptions.h
content_copy
No comments
No comments
-0 +3
-
-
-
-
-
-
expand_more
help
chrome/browser/flag_descriptions.cc …/flag_descriptions.cc
content_copy
No comments
No comments
-0 +4
-
-
-
-
-
-
expand_more
help
chrome/browser/web_applications/BUILD.gn …/BUILD.gn
content_copy
No comments
No comments
-0 +2
-
-
-
-
-
-
expand_more
help
chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.h …/notebook_lm.h
content_copy
No comments
No comments
-0 +17
-
-
-
-
-
-
expand_more
help
chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.cc …/notebook_lm.cc
content_copy
No comments
No comments
-0 +35
-
-
-
-
-
-
expand_more
help
chromeos/constants/chromeos_features.h …/chromeos_features.h
content_copy
No comments
No comments
-0 +2
-
-
-
-
-
-
expand_more
help
chromeos/constants/chromeos_features.cc …/chromeos_features.cc
content_copy
No comments
No comments
-0 +5
-
-
-
-
-
-
expand_more
help
docs/how_to_add_your_feature_flag.md …/how_to_add_your_feature_flag.md
content_copy
No comments
No comments
-1 +1
-
-
-
-
-
-
expand_more
help
tools/metrics/histograms/enums.xml …/enums.xml
content_copy
No comments
No comments
-0 +2
-
-
-
-
-
-
expand_more
-19 +99
Show 0 More Show All 14 Files
Change Log

Change Log

Expand All
Alan Cutter
Commit-Queue
+1
Patchset 4 | Mar 19 6:54 AM expand_more
Alan Cutter
Hidehiko Abe, who was added as reviewer owns the following files: * `chrome/browser/ash/extensions/default_app_order.cc` * `chrome/browser/web_applications/BUILD.gn` * `chrome/browser/web_applications/preinstalled_app_install_features.cc` * `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.cc` * `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.h` * `chrome/browser/web_applications/preinstalled_web_apps/preinstalled_web_apps.cc` * `chromeos/constants/chromeos_features.cc` * `chromeos/constants/chromeos_features.h` Colin Blundell, who was added as reviewer owns the following files: * `ash/constants/web_app_id_constants.h` * `chrome/browser/ash/extensions/default_app_order.cc` * `chrome/browser/web_applications/BUILD.gn` * `chrome/browser/web_applications/preinstalled_app_install_features.cc` * `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm.cc` * `chrome/browser/web_applications/preinstalled_web_apps/notebook_lm
Patchset 4 | Mar 19 6:54 AM expand_more
Chromium LUCI CQ
This CL has passed the run
Patchset 4 | Mar 19 7:36 AM expand_more
Colin Blundell
mark_chat_read 1
Thanks! Can you ping when Hidehiko gives his LGTM for the main review and I can stamp for anything left? I defer to him on the technical review here.
Patchset 4 | Mar 19 8:28 AM expand_more
Hidehiko Abe
Code-Review +1
mark_chat_read 2
LGTM
Patchset 4 | Mar 19 1:56 PM expand_more
Colin Blundell
Code-Review +1
mark_chat_read 1
//ash lgtm, thanks!
Patchset 4 | Mar 19 2:15 PM expand_more
Alan Cutter
Uploaded patch set 5. headers Outdated Votes: * Code-Review+1 by Colin Blundell, Hidehiko Abe (copy condition\*: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR (**has:unchanged-files** AND uploaderin:cria/project-chromium-committers) OR is:MIN") \* The label has `labelCopyEnforcement` or `labelCopyRestriction` configured. Only the most relevant condition that determined the outcome is shown.
View Diff Patchset 5 | Mar 20 1:02 AM expand_more
Alan Cutter
Commit-Queue
+2
mark_chat_read 1
Patchset 5 | Mar 20 1:03 AM expand_more
Chromium LUCI CQ on behalf of
Alan Cutter
Commit-Queue 0 (vote reset)
Patchset 5 | Mar 20 1:03 AM expand_more
Chromium LUCI CQ
CV cannot start a Run because this CL is not satisfying the `Code-Review` submit requirement. Please hover over the corresponding entry in the Submit Requirements section to check what is missing.
Patchset 5 | Mar 20 1:03 AM expand_more
Alan Cutter
Uploaded patch set 6. about flags
View Diff Patchset 6 | Mar 20 6:07 AM expand_more
Alan Cutter
Commit-Queue
+1
Patchset 6 | Mar 20 6:08 AM expand_more
Chromium LUCI CQ
Dry run: CV is trying the patch. Follow status at: https://luci-change-verifier.appspot.com/ui/run/chromium/8880519874854-1-f4ada94b7403d4f8 Bot data: {"action":"start","triggered_at":"2025-03-20T06:08:42Z","revision":"c913ae07bf20183fd90dbc2aab8ef8c5b2f25bdf"}
Patchset 6 | Mar 20 6:08 AM expand_more
Chromium LUCI CQ on behalf of
Alan Cutter
Commit-Queue 0 (vote reset)
Patchset 6 | Mar 20 6:52 AM expand_more
Chromium LUCI CQ
This CL has failed the run. Reason: Tryjob [chromium/try/linux-chromeos-rel](https://cr-buildbucket.appspot.com/build/8719901486255049441) has failed with summary ([view all results](https://chromium-review.googlesource.com/c/6367996?checksPatchset=6&tab=checks)): --- 1 Test Suite(s) failed. **unit_tests** failed because of: - AboutFlagsTest.EveryFlagHasMetadata
Patchset 6 | Mar 20 6:52 AM expand_more
Hidehiko Abe
mark_chat_read 1
could you fix bot failure?
Patchset 6 | 4:13 AM expand_more
0%
10%
20%
30%
40%
50%
60%
70%
80%
90%
100%
word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word word

mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1
mmMwWLliI0fiflO&1