Skip to content
/ ffms2 Public

fpsden-fpsnum don't work properly on RC4 #443

Closed
@Hackerpcs

Description

@Hackerpcs

I am using StaxRip to mostly encode from lossless SD HuffYUV avi, capturing VHS from ATI 600 USB and JVC HR-S7600EU VCR using AmarecTV. I use "fpsnum=25, fpsden=1" to force PAL 25fps because AmarecTV naturally inserts some frames when needed (start/stop of the tape, empty tape at the end with static, etc) because otherwise the result is less than 25fps, causing audio sync issues.

Using ffms2-2.40, the result correctly is that the duration being adjusted up when using "fpsnum=25, fpsden=1" with the added frames as stated in the documentation, e.g. on this ~3h recording, a total duration that before was 186:52, after using "fpsnum=25, fpsden=1" was adjusted up to 186:55

2 4 fpsden off

2 4 fpsden on

In contrast, if I instead use 5.0-RC4, the arguments don't work properly and the duration isn't adjusted, staying at 186:52 with or without the arguments and the end result has audio sync issues

I can't upload the source file because of its size but here is sample where I intentionally start and stop the tape to make the result have enough inserted frames. Due to the smaller duration the difference isn't that drastic but it there, the frames before (using Staxrip's Preview feature to see the resulting avs script) are 1932 and after if "fpsnum=25, fpsden=1" is used are 1943 which are the correct as seen in the AmarecTV's log (line 3171, "VT=00:01:17.773s(1943f)")

https://mega.nz/folder/XE4UzAZA#5co2GPSZm-z-j19wv4feKg

Activity

Dendraspis

Dendraspis commented on May 25, 2024

@Dendraspis

Just a few little additions to this report, that could help:

  • v5.0-RC3 is also affected, so it's not a recent change that causes the issue.
  • The media info of the sample file shows:
Frame rate                               : 25.000
Frame rate                               : 25.000 FPS
FrameRate_Num                            : 25
FrameRate_Den                            : 1
Frame count                              : 1944
  • StaxRip reports the data from AviSynth+:
    image
  • When setting fpsnum=25, fpsden=1 the report looks correct:
    image
myrsloik

myrsloik commented on May 25, 2024

@myrsloik
Contributor

Fixed here too

Dendraspis

Dendraspis commented on May 25, 2024

@Dendraspis

Thank you very much. ๐Ÿ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @myrsloik@Hackerpcs@Dendraspis

      Issue actions

        fpsden-fpsnum don't work properly on RC4 ยท Issue #443 ยท FFMS/ffms2