Description
Environment
Attachments
- CLJS-1973.patch12 Mar 2017, 06:21 AM
Activity
David Nolen March 18, 2017 at 5:23 AM
Thomas Heller March 12, 2017 at 7:19 PM
Wrote about this in Slack but I wanted to properly voice my concerns so they don't get lost in Slack archives.
I think managing npm via CLJS is a bad idea. While this is very interesting it could/should probably happen in a library. We will inherit all the woes npm brings and force this onto the user. What if the user prefers yarn? What if the user is using a tool with support for package.json but not deps.cljs?
I voiced similar concerns a while ago [1] and with everything happening recently with regards to JS modules the situation is getting worse. It may appear that this work must happen in CLJS but really could happen somewhere else without making cljs.core more complicated. clojure.core doesn't bundle with leiningen for good reason.
IMHO, YMMV
[1] https://groups.google.com/d/msg/clojurescript/xMQuEmQt7oQ/AWT5RZe_nQQJ
fixed https://github.com/clojure/clojurescript/commit/21da03e03e229a0b38fb872485d26a30fbf034b8