Description
Environment
None
Attachments
2
- CLJ-2502-2.patch09 Apr 2019, 05:17 PM
- CLJ-2502.patch09 Apr 2019, 07:10 AM
Activity
Show:
Alex Miller March 4, 2020 at 4:20 AM
Applied for 1.10.2
Alex Miller April 9, 2019 at 8:08 AM
There seem to be some extraneous indenting changes in there - if you could minimize those, that would be helpful. For root-cause, I'd prefer the type hint as high as possible (in the arg). Can you update those?
Michiel Borkent April 9, 2019 at 7:15 AM
Tested this with GraalVM and it now works.
Alex Miller April 8, 2019 at 10:14 PM
Go for it! Feel free to put the warn-on-reflect setting in the top of the code in the patch.
Michiel Borkent April 8, 2019 at 6:33 PM
I'd be happy to implement the fix myself, after some vetting of this issue.
Completed
Pinned fields
Click on the next to a field label to start pinning.
Details
Assignee
Reporter
Approval
Ok
Patch
Code
Priority
MajorFix versions
Created April 8, 2019 at 6:32 PM
Updated March 4, 2020 at 4:20 AM
Resolved March 4, 2020 at 4:20 AM
Problem
I tried to use
clojure.stracktrace/print-stack-tracewith GraalVM but that doesn't work since reflection is needed to find the methodgetMessage.Proposed solution
This can be resolved by adding type hints.
An overview of warnings emitted by
(set! *warn-on-reflection* true):
Reflection warning, /tmp/stacktrace.clj:24:18 - reference to field getCause can't be resolved. Reflection warning, /tmp/stacktrace.clj:32:15 - reference to field getClassName can't be resolved. Reflection warning, /tmp/stacktrace.clj:33:9 - reference to field getMethodName can't be resolved. Reflection warning, /tmp/stacktrace.clj:38:26 - reference to field getFileName can't be resolved. Reflection warning, /tmp/stacktrace.clj:38:47 - reference to field getLineNumber can't be resolved. Reflection warning, /tmp/stacktrace.clj:45:42 - reference to field getMessage can't be resolved. Reflection warning, /tmp/stacktrace.clj:24:18 - reference to field getCause can't be resolved.Patch CLJ-2502-2.patch removes unwanted whitespace changes and moves the type hint of
root-causehigher up.Screened by: Alex Miller