-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary conditions in Matrix::compute_rank
#16
Conversation
|
I understand why Kaspa didn't want to merge it for now as it is risky consensus critical change. I did already some basic smoke testing:
Moreover, I've tested this patch for quite some time now in our I will merge it for now as I like to removal of |
|
let me do better then.. |
by @Slixe
In
fn compute_rank(&self)remove the if condition previously used to remove the bounds check.According to the issue linked (rust-lang/rust#90794) it has been fixed since 1.72.
@0xA001113 We should check if we can make more improvements like this.