Fixed
Status Update
Comments
mp...@chromium.org <mp...@chromium.org> #2
I have no objections to deleting it. I believe that pages only visited more than three months ago are not likely to be useful for omnibox purposes at least.
va...@chromium.org <va...@chromium.org> #4
Cc-ing engedy@, as just today he told me he is working on the bug of archived history popping up in suggestions without a way to delete it
en...@chromium.org <en...@chromium.org> #5
We do surface archived history items in two places:
(1) Searches on the chrome://history page.
(2) Searches through the History API.
In fact, I have just started writing a fix for https://crbug.com/chromium/323873, to also make it possible to remove archived history items that show up as results. A similar defect is present with the History API.
If we decide to get rid of the whole thing, I am just the happier.
(1) Searches on the chrome://history page.
(2) Searches through the History API.
In fact, I have just started writing a fix for
If we decide to get rid of the whole thing, I am just the happier.
en...@chromium.org <en...@chromium.org> #6
Following an off-line discussion, we have consensus to remove this.
[Deleted User] <[Deleted User]> #7
sgtm
en...@chromium.org <en...@chromium.org> #8
[Empty comment from Monorail migration]
bu...@chromium.org <bu...@chromium.org> #9
------------------------------------------------------------------
r275159 | engedy@chromium.org | 2014-06-05T16:44:38.529323Z
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/favicon_cache.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend_unittest.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_querying_unittest.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/url_database.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.h?r1=275159&r2=275158&pathrev=275159
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/archived_history.4.sql?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.h?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/url_database.h?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_notifications.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_notifications.h?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_unittest.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/typed_url_syncable_service.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=275159&r2=275158&pathrev=275159
D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/archived_database.cc?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/typed_url_syncable_service.h?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=275159&r2=275158&pathrev=275159
D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/archived_database.h?r1=275159&r2=275158&pathrev=275159
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc?r1=275159&r2=275158&pathrev=275159
Eliminate the archived history database and clean up related code.
More specifically, this change list:
* Removes all code related to the archived history database, and removes all mentions of it from comments.
* Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
* Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
* Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.
BUG=359377
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/235863023
-----------------------------------------------------------------
r275159 | engedy@chromium.org | 2014-06-05T16:44:38.529323Z
Changed paths:
M
M
M
M
M
M
M
M
M
M
A
M
M
M
M
M
M
M
M
M
D
M
M
D
M
Eliminate the archived history database and clean up related code.
More specifically, this change list:
* Removes all code related to the archived history database, and removes all mentions of it from comments.
* Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
* Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
* Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.
BUG=359377
TBR=pkasting@chromium.org
Review URL:
-----------------------------------------------------------------
bu...@chromium.org <bu...@chromium.org> #10
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/cd05b97364507693c99110f642c611c929252cd4
commit cd05b97364507693c99110f642c611c929252cd4
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 05 16:44:38 2014
Eliminate the archived history database and clean up related code.
More specifically, this change list:
* Removes all code related to the archived history database, and removes all mentions of it from comments.
* Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
* Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
* Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.
BUG=359377
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/235863023
git-svn-id: svn:// svn.chromium.org/chrome/trunk/src@275159 0039d316-1c4b-4281-b951-d872f2087c98
commit cd05b97364507693c99110f642c611c929252cd4
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 05 16:44:38 2014
Eliminate the archived history database and clean up related code.
More specifically, this change list:
* Removes all code related to the archived history database, and removes all mentions of it from comments.
* Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
* Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
* Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.
BUG=359377
TBR=pkasting@chromium.org
Review URL:
git-svn-id: svn://
en...@chromium.org <en...@chromium.org> #12
[Empty comment from Monorail migration]
en...@chromium.org <en...@chromium.org> #13
[Empty comment from Monorail migration]
bu...@chromium.org <bu...@chromium.org> #14
------------------------------------------------------------------
r276998 | engedy@chromium.org | 2014-06-13T12:49:25.113614Z
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h?r1=276998&r2=276997&pathrev=276998
M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=276998&r2=276997&pathrev=276998
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.cc?r1=276998&r2=276997&pathrev=276998
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.h?r1=276998&r2=276997&pathrev=276998
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model.cc?r1=276998&r2=276997&pathrev=276998
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc?r1=276998&r2=276997&pathrev=276998
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL: https://codereview.chromium.org/316063003
-----------------------------------------------------------------
r276998 | engedy@chromium.org | 2014-06-13T12:49:25.113614Z
Changed paths:
M
M
M
M
M
M
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL:
-----------------------------------------------------------------
bu...@chromium.org <bu...@chromium.org> #15
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d753c94adbbe38d1163a3fda57e620626fd9c295
commit d753c94adbbe38d1163a3fda57e620626fd9c295
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 12:49:25 2014
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL: https://codereview.chromium.org/316063003
git-svn-id: svn:// svn.chromium.org/chrome/trunk/src@276998 0039d316-1c4b-4281-b951-d872f2087c98
commit d753c94adbbe38d1163a3fda57e620626fd9c295
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 12:49:25 2014
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL:
git-svn-id: svn://
bu...@chromium.org <bu...@chromium.org> #16
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/908431e63848edfd99d78ec0cec0277bbea6e48a
commit 908431e63848edfd99d78ec0cec0277bbea6e48a
Author: kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 16:09:24 2014
Revert 276998 "Remove recovery diagnostics for the archived hist..."
Broke Linux ChromiumOS Tests.
commit 908431e63848edfd99d78ec0cec0277bbea6e48a
Author: kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 16:09:24 2014
Revert 276998 "Remove recovery diagnostics for the archived hist..."
Broke Linux ChromiumOS Tests.
TBR=engedy@chromium.org
Review URL:
git-svn-id: svn://
bu...@chromium.org <bu...@chromium.org> #17
------------------------------------------------------------------
r277030 | kalman@chromium.org | 2014-06-13T16:09:24.093924Z
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model.cc?r1=277030&r2=277029&pathrev=277030
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc?r1=277030&r2=277029&pathrev=277030
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h?r1=277030&r2=277029&pathrev=277030
M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=277030&r2=277029&pathrev=277030
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.cc?r1=277030&r2=277029&pathrev=277030
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.h?r1=277030&r2=277029&pathrev=277030
Revert 276998 "Remove recovery diagnostics for the archived hist..."
Broke Linux ChromiumOS Tests.
r277030 | kalman@chromium.org | 2014-06-13T16:09:24.093924Z
Changed paths:
M
M
M
M
M
M
Revert 276998 "Remove recovery diagnostics for the archived hist..."
Broke Linux ChromiumOS Tests.
TBR=engedy@chromium.org
Review URL:
-----------------------------------------------------------------
bu...@chromium.org <bu...@chromium.org> #18
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/28a7e95c78c04d996ab325c81f73507964419e6b
commit 28a7e95c78c04d996ab325c81f73507964419e6b
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 02 12:41:26 2014
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL: https://codereview.chromium.org/334633006
git-svn-id: svn:// svn.chromium.org/chrome/trunk/src@281003 0039d316-1c4b-4281-b951-d872f2087c98
commit 28a7e95c78c04d996ab325c81f73507964419e6b
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 02 12:41:26 2014
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL:
git-svn-id: svn://
bu...@chromium.org <bu...@chromium.org> #19
------------------------------------------------------------------
r281003 | engedy@chromium.org | 2014-07-02T12:41:26.236106Z
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_model.cc?r1=281003&r2=281002&pathrev=281003
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc?r1=281003&r2=281002&pathrev=281003
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h?r1=281003&r2=281002&pathrev=281003
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.cc?r1=281003&r2=281002&pathrev=281003
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/diagnostics_metrics.h?r1=281003&r2=281002&pathrev=281003
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL: https://codereview.chromium.org/334633006
-----------------------------------------------------------------
r281003 | engedy@chromium.org | 2014-07-02T12:41:26.236106Z
Changed paths:
M
M
M
M
M
Remove recovery diagnostics for the archived history database.
The reason is that the archived history database feature has been removed as of r275159.
BUG=359377
Review URL:
-----------------------------------------------------------------
ch...@gmail.com <ch...@gmail.com> #20
Disappointed about this. I just spent two hours looking for an old link (one that just today became important) I'd visited in May before I discovered (by manually paging through my Chrome history) that Chrome only saves 90 days of history; further research turned up the ability to access the "archived history" database, which I was unable to find, which led me to this.
Count me as a bit peeved that you guys implemented this "fix."
Rather ironic that the king of amassing data (Google) has decided that anything I did more than 90 days ago isn't worth knowing.
Count me as a bit peeved that you guys implemented this "fix."
Rather ironic that the king of amassing data (Google) has decided that anything I did more than 90 days ago isn't worth knowing.
pk...@chromium.org <pk...@chromium.org> #21
Since the archived history database was never accessible from any Chrome UI anywhere, the changes here haven't changed the behavior of Chrome, which has been consistent since our 2008 launch.
So if you want to complain, don't complain about this bug.
So if you want to complain, don't complain about this bug.
mr...@gmail.com <mr...@gmail.com> #22
pkasting, allow me to disagree. In fact, the entries older than 90 days were accessible from the Chrome UI, which has led to the discovery of at least https://crbug.com/chromium/323873, https://crbug.com/chromium/332743, https://crbug.com/chromium/339130, https://crbug.com/chromium/341839, https://crbug.com/chromium/355088, and https://crbug.com/chromium/367447. So not only have people had the possibility of accessing older history entries, they also did so often enough to find behavior inconsistent with the access to more recent history entries.
pk...@chromium.org <pk...@chromium.org> #23
Argh. When we discussed removing the archived history DB, the claim was that we don't use it anywhere anyway. It's pretty annoying to find out that that wasn't true.
Given how atrociously awful the History page is at finding anything anyway, it's not as if this was a terribly reliable feature, but still. Frustrating. Thanks for the bug links.
Given how atrociously awful the History page is at finding anything anyway, it's not as if this was a terribly reliable feature, but still. Frustrating. Thanks for the bug links.
en...@chromium.org <en...@chromium.org> #24
Peter, back then, we did, in fact, debate the value provided by surfacing archived entries (see https://crbug.com/chromium/359377#c4 and also the off-line discussion per e-mail). We arrived at pretty much the same conclusion as you have above: more code and more space on the user's disk for a feature that provides little value, is inconsistent and broken in several aspects, and would require a non-trivial amount of engineering effort to get into a reliably working state.
We can reconsider if this turns out to be a lot more useful than we had initially thought.
We can reconsider if this turns out to be a lot more useful than we had initially thought.
pk...@chromium.org <pk...@chromium.org> #25
Well, today is just the day when I
(1) Can't read, and
(2) Am wrong
I apologize to everyone for repeatedly saying false things. I'm going to go slink away from this bug now.
(1) Can't read, and
(2) Am wrong
I apologize to everyone for repeatedly saying false things. I'm going to go slink away from this bug now.
pk...@chromium.org <pk...@chromium.org> #28
[Empty comment from Monorail migration]
bu...@chromium.org <bu...@chromium.org> #29
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a3199711171ab3760a9b8f940f1befa2bc9f591c
commit a3199711171ab3760a9b8f940f1befa2bc9f591c
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Thu Sep 10 09:26:50 2015
Removed archived history file deletion on browser start
Remove delete of archived history file on browser start.
Archived history file usage was removed since M37.
BUG=359377
R=engedy@chromium.org
Review URL: https://codereview.chromium.org/1311403011
Cr-Commit-Position: refs/heads/master@{#348126}
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend.h
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend_db_unittest.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_constants.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_constants.h
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/test/history_backend_db_base_test.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/test/history_backend_db_base_test.h
[delete] http://crrev.com/69a18f2bd871839d6ef9994f17b3e0ffd37d244b/components/test/data/history/archived_history.4.sql
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/tools/metrics/histograms/histograms.xml
commit a3199711171ab3760a9b8f940f1befa2bc9f591c
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Thu Sep 10 09:26:50 2015
Removed archived history file deletion on browser start
Remove delete of archived history file on browser start.
Archived history file usage was removed since M37.
BUG=359377
R=engedy@chromium.org
Review URL:
Cr-Commit-Position: refs/heads/master@{#348126}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[modify]
is...@google.com <is...@google.com> #30
This issue was migrated from crbug.com/chromium/359377?no_tracker_redirect=1
[Multiple monorail components: Privacy, UI>Browser>History]
[Monorail blocking: crbug.com/chromium/323873, crbug.com/chromium/381588]
[Monorail components added to Component Tags custom field.]
[Multiple monorail components: Privacy, UI>Browser>History]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
Description
It seems like we should either hook up the archived DB to do useful things, or get rid of it entirely and delete all related code and all archive files on disk.