Fixed
Status Update
No update yet.
Conversations with UX and PM led to a few changes for the Google Play Protect prompt on APK downloads:
- The "File may be harmful" prompt should not show if the user was prompted for file location (consistent with desktop)
- The "File may be harmful" prompt should not show if GPP is enabled
- The "File may be harmful" prompt should show before the download, and the GPP prompt should show after the download.
- The "File may be harmful" prompt should not show if the user was prompted for file location (consistent with desktop)
- The "File may be harmful" prompt should not show if GPP is enabled
- The "File may be harmful" prompt should show before the download, and the GPP prompt should show after the download.
Comments
dr...@chromium.org
Screencast of new code.
- First download does not warn because the user was prompted about the APK dowlnaod
- Second does warn because GPP is disabled, and the user was not prompted
- Third does not warn because the user has GPP enabled after second download.
ap...@google.com
Project: chromium/src
Branch: main
commit 98ae0b37133fa0ba7265fe522726aac9f1cff942
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 16 16:02:22 2024
Decrease file-type warnings on Android
The DownloadTargetDeterminer sets the danger_level to NOT_DANGEROUS if
the user has been prompted for the file extension. On Android, however,
that prompt runs through a second check of the validity of the file,
which clears confirmation_reason_. This means we still show file-type
based warnings even when the user has been prompted.
This CL fixes this by allowing a confirmation_reason_ of PREFERENCE to
persist through the second check.
Bug: 352379271
Change-Id: I89d29826e0267357903ab90b4d177672349af87d
Reviewed-on:
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1328209}
M chrome/browser/download/download_target_determiner.cc
Branch: main
commit 98ae0b37133fa0ba7265fe522726aac9f1cff942
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 16 16:02:22 2024
Decrease file-type warnings on Android
The DownloadTargetDeterminer sets the danger_level to NOT_DANGEROUS if
the user has been prompted for the file extension. On Android, however,
that prompt runs through a second check of the validity of the file,
which clears confirmation_reason_. This means we still show file-type
based warnings even when the user has been prompted.
This CL fixes this by allowing a confirmation_reason_ of PREFERENCE to
persist through the second check.
Bug: 352379271
Change-Id: I89d29826e0267357903ab90b4d177672349af87d
Reviewed-on:
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1328209}
M chrome/browser/download/download_target_determiner.cc
ap...@google.com
Project: chromium/src
Branch: main
commit a7cf068bc1e44b204e85232f7cd0bb92b85aa96a
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 16 23:45:59 2024
Change sequencing of Android download warnings
On feedback from UX, "File might be harmful" prompts should not show if
Google Play Protect is enabled, and the prompt to enable Google Play
Protect should show after the download is complete.
This CL determines if Google Play Protect is enabled in the
DownloadTargetDeterminer by adding a new state on Android,
STATE_CHECK_APP_VERIFICATION. This will suppress setting the danger
level to DANGEROUS_FILE if we find that GPP is enabled.
It also moves the code for triggering the "Turn on Play Protect?" so
that it only triggers for downloads that bypassed a warning. This is
handled by the DownloadController.
Since the functionality of the DownloadAppVerificationRequest is now
divided between download start and end, this CL removes that class
entirely.
See bug for screencast.
Fixed: 352379271
Change-Id: I9c8b03c9b36e56d788d70d9a3cdaf85408f7101b
Reviewed-on:
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1328535}
M chrome/browser/BUILD.gn
D chrome/browser/download/android/download_app_verification_request.cc
D chrome/browser/download/android/download_app_verification_request.h
M chrome/browser/download/android/download_controller.cc
M chrome/browser/download/android/download_controller.h
M chrome/browser/download/download_target_determiner.cc
M chrome/browser/download/download_target_determiner.h
Branch: main
commit a7cf068bc1e44b204e85232f7cd0bb92b85aa96a
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 16 23:45:59 2024
Change sequencing of Android download warnings
On feedback from UX, "File might be harmful" prompts should not show if
Google Play Protect is enabled, and the prompt to enable Google Play
Protect should show after the download is complete.
This CL determines if Google Play Protect is enabled in the
DownloadTargetDeterminer by adding a new state on Android,
STATE_CHECK_APP_VERIFICATION. This will suppress setting the danger
level to DANGEROUS_FILE if we find that GPP is enabled.
It also moves the code for triggering the "Turn on Play Protect?" so
that it only triggers for downloads that bypassed a warning. This is
handled by the DownloadController.
Since the functionality of the DownloadAppVerificationRequest is now
divided between download start and end, this CL removes that class
entirely.
See bug for screencast.
Fixed: 352379271
Change-Id: I9c8b03c9b36e56d788d70d9a3cdaf85408f7101b
Reviewed-on:
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1328535}
M chrome/browser/BUILD.gn
D chrome/browser/download/android/download_app_verification_request.cc
D chrome/browser/download/android/download_app_verification_request.h
M chrome/browser/download/android/download_controller.cc
M chrome/browser/download/android/download_controller.h
M chrome/browser/download/download_target_determiner.cc
M chrome/browser/download/download_target_determiner.h
ap...@google.com
Project: chromium/src
Branch: main
commit 9b7255ed732f2820fd07be394aa44cf34080eb4b
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 23 18:39:45 2024
Use a separate feature flag for disabling file-type warnings on Android
We won't be shipping that behavior change as part of the Google Play
Protect prompt launch. We are still likely to ship it in the near term,
so put it behind its own feature flag.
Bug: 352379271
Change-Id: Idfcd21f59e526837d402c87fce246b7f6660ed3d
Reviewed-on:
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331896}
M chrome/browser/download/download_target_determiner.cc
M components/safe_browsing/core/common/features.cc
M components/safe_browsing/core/common/features.h
Branch: main
commit 9b7255ed732f2820fd07be394aa44cf34080eb4b
Author: Daniel Rubery <drubery@chromium.org>
Date: Tue Jul 23 18:39:45 2024
Use a separate feature flag for disabling file-type warnings on Android
We won't be shipping that behavior change as part of the Google Play
Protect prompt launch. We are still likely to ship it in the near term,
so put it behind its own feature flag.
Bug: 352379271
Change-Id: Idfcd21f59e526837d402c87fce246b7f6660ed3d
Reviewed-on:
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331896}
M chrome/browser/download/download_target_determiner.cc
M components/safe_browsing/core/common/features.cc
M components/safe_browsing/core/common/features.h