![warning](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg>)
Open
+201
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![@TOGEP](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="40" height="40"><rect fill-opacity="0"/></svg>){kind=avatar}
|
I'm amazed to see a PR here with actual typo fixes that are merge-worthy. |
| @@ -18,7 +18,7 @@ | |||
| private final PriorityQueue<DistancedItem<T>> queue; | |||
| private final boolean minQueue; | |||
| /** | |||
| * Creates ontainer for items with their distances. | |||
| * Creates a container for items with their distances. | |||
| @@ -94,7 +94,7 @@ public DistancedItem<T> dequeue() { | |||
| } | |||
|
|
|||
| /** | |||
| * Dequeue all the elements from queueu with ordering mantained | |||
| * Dequeue all the elements from queueu with ordering maintained | |||
| @@ -91,7 +91,7 @@ def parse_metric(config): | |||
| elif metric_str == "linf": | |||
| return faiss.METRIC_Linf | |||
| else: | |||
| raise Exception(f"Uknown metric: {metric_str}") | |||
| raise Exception(f"Unknown metric: {metric_str}") | |||
| @@ -36,7 +36,7 @@ object AnnoyCommon { | |||
|
|
|||
| case class AnnoyRuntimeParams( | |||
| /* Number of vectors to evaluate while searching. A larger value will give more accurate results, but will take longer time to return. | |||
| * Default value would be numberOfTrees*numberOfNeigboursRequested | |||
| * Default value would be numberOfTrees*numberOfNeighboursRequested | |||
twml/libtwml/src/ops/feature_id.cpp
Outdated
twml/twml/__init__.py
Outdated
![rps2579](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="60" height="60"><rect fill-opacity="0"/></svg>){kind=small}
| @@ -37,7 +37,7 @@ trait Task extends Closable { self: Logging => | |||
|
|
|||
| @volatile private var taskLoop: Future[Unit] = null | |||
|
|
|||
| /** Execute the task wih bookkeeping **/ | |||
| /** Execute the task with bookkeeping **/ | |||
There was a problem hiding this comment.
No changes here.. formatting?
|
amazing job!! |
| @@ -168,7 +168,7 @@ class ProductPipelineBuilder[TRequest <: Request, Query <: PipelineQuery, Respon | |||
| } | |||
|
|
|||
| def pipelineSelectorStep( | |||
| pipelineByIdentifer: Map[ComponentIdentifier, Pipeline[Query, Response]], | |||
| pipelineByIdentifler: Map[ComponentIdentifier, Pipeline[Query, Response]], | |||
There was a problem hiding this comment.
Typo correction contains typo.. should've been identifier
| @@ -178,7 +178,7 @@ class ProductPipelineBuilder[TRequest <: Request, Query <: PipelineQuery, Respon | |||
| override def executorArrow: Arrow[ | |||
| Query, | |||
| PipelineSelectorExecutorResult | |||
| ] = pipelineSelectorExecutor.arrow(pipelineByIdentifer, pipelineSelector, context) | |||
| ] = pipelineSelectorExecutor.arrow(pipelineByIdentifler, pipelineSelector, context) | |||
There was a problem hiding this comment.
Same here.. should've been identifier
twml/twml/dataset.py
Outdated
| @@ -30,7 +30,7 @@ def __init__(self, filenames, compression_type="auto", buffer_size=1 << 20): | |||
| self._filenames = tf.convert_to_tensor(filenames, dtype=tf.string, name="filenames") | |||
| self._compression_type = tf.convert_to_tensor(compression_type.lower(), name="compression_type") | |||
| self._buffer_size = tf.convert_to_tensor(buffer_size, dtype=tf.int64, name="buffer_size") | |||
| # Parent class calss self._as_variant_tensor in init. So call this at the end. | |||
| # Parent class call self._as_variant_tensor in init. So call this at the end. | |||
There was a problem hiding this comment.
Should this be parent class *calls* self...
|
|
|
@rps2579 |
|
Reviewed all 100+ files, looks good. Great efforts. @TOGEP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Got fooled? Have a great day! ;)