Skip to content
New issue

Why is there no reference to ORB_SLAM2 ? #12

Closed
nikolaseu opened this issue on May 22, 2019 · 3 comments

Comments

@nikolaseu
Copy link

@nikolaseu nikolaseu commented on May 22, 2019

I'm currently trying to learn about SLAM on my free time, so I'm looking at different open source projects. I noticed the core of this project is really close to ORB_SLAM2 but with different namespace and some change in the name of methods. Are the projects related in some way? Are both based on some other previous code base?

@kensakurada
Copy link
Member

@kensakurada kensakurada commented on May 23, 2019

We appreciate your letting us know about that we forgot to describe the references in the documentation (the details and the references are described in our paper that is under review). We compared and analyzed many kinds of open sources, such as ORB-SLAM, ProSLAM, and UcoSLAM. From the insights, we created our open source from scratch. Although the names of some variables and functions in OpenVSLAM might be close to them because both of OpenVSLAM and them are based on a feature-based algorithm, the code structures of other main parts (e.g. camera model, initializer, tracker, optimizer) are completely different. Considering your thoughtful comment, we added the references into the documentation. Thank you for your cooperation.

@masahi
Copy link

@masahi masahi commented on May 28, 2019

I would suggest that you should at least add a proper acknowledgement or note to ORBSLAM2 (on README, for example). Having spent considerable time on the ORBSLAM2 codebase, I'm afraid it is obvious that this codebase is directy derived from ORBSLAM2 (although written from scratch). I've read initialization, local_mapping and matching components, and I can see line by line correspondence between the two codebases.

@kensakurada
Copy link
Member

@kensakurada kensakurada commented on May 28, 2019

Thank you for your thoughtful comments. We added reference to README so that users notice that OpenVSLAM refers ORB-SLAM, ProSLAM and other SLAM systems at a glance. Please refer to the preprint of OpenVSLAM paper for the detail that will be uploaded soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.