Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 275
  • Merge Requests 31
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !470

Open
Opened 17 hours ago by Marcelo Rivera@eiennohi
Report abuse

Change the error message for "No VOIP allowed" to "Invalid phone number"

  • Overview 2
  • Commits 2
  • Pipelines 4
  • Changes 7
2/2 threads resolved

closes #1319

** Testing ** We need to test verification for:

  • twofactor
  • rewards (in Wallet)
  • Onboarding

So do this for twofactor in settings, rewards and onboarding:

  1. Create a new user
  2. Go to wallet
  3. Input an invalid phone. You should see an error message saying "Invalid phone number"
  4. Input a voip phone (if you know of one). It should show a message saying that voip phones aren't allowed
  5. Input a valid phone. It should work
Request to merge fix/twilio-verification-message into master
Open in Web IDE
Pipeline #119620115 running for 2a2ce2b1 on fix/twilio-verification-message
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena Martin Santangelo Ben Hayward Olivia Madrid Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1319

          Deletes source branch

          • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label 16 hours ago

            added scoped label

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 33 minutes ago
            Resolved by Marcelo Rivera 24 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 33 minutes ago
            Resolved by Marcelo Rivera 23 minutes ago
          • Marcelo Rivera @eiennohi added 1 commit 25 minutes ago

            added 1 commit

            • be9cdc4c - (fix): show a better error message for invalid phones

            Compare with previous version

          • Marcelo Rivera @eiennohi resolved all threads 23 minutes ago

            resolved all threads

          • Marcelo Rivera @eiennohi added 1 commit 23 minutes ago

            added 1 commit

            • 13c805eb - (fix): show a better error message for invalid phones

            Compare with previous version

          • Marcelo Rivera @eiennohi added Status::Review scoped label and automatically removed Status::Requires Changes label 22 minutes ago

            added scoped label and automatically removed label

          • Marcelo Rivera @eiennohi added 6 commits 1 minute ago

            added 6 commits

            • 13c805eb...5d48a12a - 5 commits from branch master
            • 2a2ce2b1 - Merge remote-tracking branch 'upstream/master' into fix/twilio-verification-message

            Compare with previous version

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          Status::Review
          Lock merge request
          Unlocked
          9
          9 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!470