Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 275
  • Merge Requests 31
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !461

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

Fix/signed wire threshold export 2004

  • Overview 8
  • Commits 15
  • Pipelines 7
  • Changes 1
1/1 thread resolved

Closes front#2004 (closed)

Summary

Users could not view their own and others paywalled content. See the steps on the issue above and try it out for yourself.

Test

  1. Make a paywalled media post (image)
  2. Refresh and check you can click the unlock button and see the image
  3. Go to the media page for the image
  4. Check you can see the image (note the url)
  5. Log out
  6. Visit URL - should not be able to access
  7. Visit the channel that posted the paywalled image, try unlock the post. You should be prompted to send tokens.

Possible areas of regression

To test, I think we should test a variety of different media types, some with paywall and some without, from multiple accounts, and logged out, to ensure that everything is working.

Edited 1 day ago by Ben Hayward
Request to merge fix/signed-wire-threshold-export-2004 into master
Pipeline #119067234 passed for ac584c41 on fix/signed-wire-threshold-export-2004
          Merge request approved. Approved by
          Mark Harding Emiliano Balbuena
          Martin Santangelo Olivia Madrid Marcelo Rivera Rami Albatal Brian Hatchet

          Merged by Mark Harding 3 minutes ago

          The changes were merged into master with 5d48a12a

          The source branch has been deleted

          Closed front#2004 (closed)

          Pipeline #119610878 running for 5d48a12a on master
                          • Ben Hayward @benhayward.ben added 3 commits 1 week ago

                            added 3 commits

                            • e6d328ba...dd03087f - 2 commits from branch master
                            • 26d89257 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004

                            Compare with previous version

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 1 week ago
                            Developer

                            Review failed, re-running start pipe.

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 1 week ago
                            Developer

                            Took another 2 pipes down, re-running again.

                          • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 1 week ago

                            added scoped labels

                          • Emiliano Balbuena
                            Emiliano Balbuena @edgebal · 1 week ago
                            Developer

                            Works OK!

                          • Emiliano Balbuena @edgebal assigned to @benhayward.ben, @brianhatchet, and @markeharding 1 week ago

                            assigned to @benhayward.ben, @brianhatchet, and @markeharding

                          • Mark Harding @markeharding approved this merge request 6 days ago

                            approved this merge request

                          • Mark Harding @markeharding added Status::Ready to Merge scoped label and automatically removed Status::Awaiting Review label 6 days ago

                            added scoped label and automatically removed label

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 6 days ago
                            Developer

                            Note this needs testing on production

                            Mark Harding: Need to see if that works on production as its a cdn issue with no session

                          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 6 days ago

                            approved this merge request

                          • Xander Miller
                            Xander Miller @xander-miller · 6 days ago
                            Developer

                            I went a bit off the testing path and found that paywalled content no longer works if you don't add an attachment.

                            pay_wall_break

                          • Ben Hayward @benhayward.ben added 7 commits 6 days ago

                            added 7 commits

                            • 26d89257...6e96d473 - 5 commits from branch master
                            • 40839669 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004
                            • b11c2e3e - Added in default value for when no image

                            Compare with previous version

                          • Emiliano Balbuena
                            Emiliano Balbuena @edgebal started a thread on an old version of the diff 6 days ago
                            Resolved by Emiliano Balbuena 1 day ago
                          • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::Ready to Merge label 6 days ago

                            added scoped label and automatically removed label

                          • Emiliano Balbuena @edgebal marked as a Work In Progress 6 days ago

                            marked as a Work In Progress

                          • Emiliano Balbuena @edgebal changed the description 6 days ago

                            changed the description

                          • Ben Hayward @benhayward.ben added 1 commit 5 days ago

                            added 1 commit

                            • 18b11072 - Refactored and added entity type check

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 8 commits 1 day ago

                            added 8 commits

                            • 18b11072...4fb9ac89 - 7 commits from branch master
                            • 44335717 - Merge remote-tracking branch 'origin/master' into fix/signed-wire-threshold-export-2004

                            Compare with previous version

                          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 1 day ago

                            unmarked as a Work In Progress

                          • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 day ago

                            added scoped label and automatically removed label

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

                            added 1 commit

                            • 96815dc7 - Fixing a bug with setState on the jury and moderation report. We refactored...

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

                            added 1 commit

                            • ac584c41 - Revert "Fixing a bug with setState on the jury and moderation report. We...

                            Compare with previous version

                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                            Developer

                            Pushed to the wrong branch. Derp

                          • Emiliano Balbuena @edgebal approved this merge request 1 day ago

                            approved this merge request

                          • Emiliano Balbuena @edgebal resolved all threads 1 day ago

                            resolved all threads

                          • Emiliano Balbuena
                            Emiliano Balbuena @edgebal · 1 day ago
                            Developer

                            Works like a charm!

                          • Mark Harding @markeharding approved this merge request 3 minutes ago

                            approved this merge request

                          • Mark Harding @markeharding merged 3 minutes ago

                            merged

                          • Mark Harding @markeharding mentioned in commit 5d48a12a 2 minutes ago

                            mentioned in commit 5d48a12a

                          Please register or sign in to reply
                          3 Assignees
                          Mark Harding's avatar
                          Brian Hatchet's avatar
                          Ben Hayward's avatar
                          None
                          Milestone
                          None
                          Time tracking
                          No estimate or time spent
                          2
                          Labels
                          Squad::Yellow Status::Awaiting Review
                          Lock merge request
                          Unlocked
                          9
                          9 participants
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          Reference: minds/engine!461