Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 408
  • Merge Requests 64
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !784

Merged
Opened 5 days ago by Ben Hayward@benhayward.ben
Report abuse

Removed Remind and Boost buttons in closed groups #2586

  • Overview 3
  • Commits 2
  • Pipelines 2
  • Changes 4

Summary

Closes #2586 (closed)

image

Steps to test

  • Closed group https://fix-closed-group-remind-boost-2586.minds.io/groups/profile/1075189549673484302/feed
  • Open group https://fix-closed-group-remind-boost-2586.minds.io/groups/profile/1075189737242759171/feed

Try a variety of group configurations, check that the remind and boost are not hidden on other areas of the site.

Estimated Regression Scope

In the worst-case scenario maybe boost and remind buttons would not be shown when they should be.

Edited 5 days ago by Ben Hayward
Request to merge fix/closed-group-remind-boost-2586 into master
Pipeline #119034318 passed with warnings for d0505c67 on fix/closed-group-remind-boost-2586
              Merge request approved. Approved by
              Brian Hatchet Xander Miller
              Marcelo Rivera Martin Santangelo Mark Harding Juan Manuel Solaro Emiliano Balbuena

              Merged by Brian Hatchet 1 hour ago

              The changes were merged into master with 7863956e

              The source branch has been deleted

              Closed #2586 (closed)

              Pipeline #119428527 running for 7863956e on master
                              • Ben Hayward
                                Ben Hayward @benhayward.ben · 5 days ago
                                Developer

                                I'll get some groups set up once the sandbox is done running

                              • Ben Hayward @benhayward.ben mentioned in issue minds#796 (moved) 5 days ago

                                mentioned in issue minds#796 (moved)

                              • Ben Hayward @benhayward.ben changed the description 5 days ago

                                changed the description

                              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 5 days ago

                                added scoped labels

                              • Mark Harding @markeharding approved this merge request 1 day ago

                                approved this merge request

                              • Emiliano Balbuena @edgebal approved this merge request 1 day ago

                                approved this merge request

                              • Emiliano Balbuena
                                Emiliano Balbuena @edgebal · 1 day ago
                                Developer

                                Works OK.

                                Edited by Emiliano Balbuena 1 day ago
                              • Brian Hatchet :speech_balloon: @brianhatchet added 75 commits 1 day ago

                                added 75 commits

                                • e384309c...18d19ab7 - 74 commits from branch master
                                • d0505c67 - Merge remote-tracking branch 'origin/master' into fix/closed-group-remind-boost-2586

                                Compare with previous version

                              • Xander Miller @xander-miller approved this merge request 1 day ago

                                approved this merge request

                              • Ben Hayward
                                Ben Hayward @benhayward.ben · 10 hours ago
                                Developer

                                I'm so confused why this pipe has failed

                              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 hours ago

                                approved this merge request

                              • Brian Hatchet :speech_balloon: @brianhatchet enabled an automatic merge when the pipeline for d0505c67 succeeds 2 hours ago

                                enabled an automatic merge when the pipeline for d0505c67 succeeds

                              • Brian Hatchet :speech_balloon: @brianhatchet merged 1 hour ago

                                merged

                              • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit 7863956e 1 hour ago

                                mentioned in commit 7863956e

                              Please register or sign in to reply
                              0 Assignees
                              None
                              None
                              Milestone
                              None
                              Time tracking
                              No estimate or time spent
                              2
                              Labels
                              Squad::Yellow Status::Awaiting Review
                              Lock merge request
                              Unlocked
                              10
                              10 participants
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              Reference: minds/front!784