Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 275
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 33
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #1319

Closed
Open
Opened 4 weeks ago by Brian Hatchet@brianhatchet:speech_balloon:0 of 2 tasks completed0/2 tasks
Report abuse New issue

Change the error message for "No VOIP allowed" to "Invalid phone number"

Our error messaging coming out of the voip verification is misleading. If you enter a phone number that's valid or voip, we get a generic error.

As reported by @omadrid:

Sidenote: I think the 'voip phones not allowed' blanket error message isn't user-friendly and is often not an accurate description of the problem.

Look at the error messages that we get back from twilio in the sms client in engine. For actual voip errors we want to return the original message. But we should return better errors than we currently ar

  • Return the invalid voip error for voip numbers
  • Return "invalid phone numbers" for numbers
Edited 1 week ago by Brian Hatchet

Linked issues
0

Related merge requests
1
  • Change the error message for "No VOIP allowed" to "Invalid phone number"
    !470
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 1
  • Designs 0
  • Brian Hatchet :speech_balloon: @brianhatchet changed due date to February 11, 2020 4 weeks ago

    changed due date to February 11, 2020

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint:01/29 Abatic Aenome 4 weeks ago

    changed milestone to %Sprint:01/29 Abatic Aenome

  • Brian Hatchet :speech_balloon: @brianhatchet added Platform::Browser Sprint::01/29 Abatic Aenome Squad::Blue scoped labels 4 weeks ago

    added scoped labels

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 2 4 weeks ago

    changed weight to 2

  • Brian Hatchet :speech_balloon: @brianhatchet added to epic &91 4 weeks ago

    added to epic &91

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label 4 weeks ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 2h 4 weeks ago

    changed time estimate to 2h

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::02/12 - Baritone Baboon scoped label and automatically removed Sprint::01/29 Abatic Aenome label 3 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 week ago

    changed the description

  • Marcelo Rivera @eiennohi added Status::InProgress scoped label and automatically removed Status::Backlog label 8 hours ago

    added scoped label and automatically removed label

  • Marcelo Rivera @eiennohi mentioned in merge request !470 1 hour ago

    mentioned in merge request !470

  • Marcelo Rivera @eiennohi added Status::Review scoped label and automatically removed Status::InProgress label 1 hour ago

    added scoped label and automatically removed label

  • Marcelo Rivera @eiennohi added 4h of time spent at 2020-02-19 1 hour ago

    added 4h of time spent at 2020-02-19

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 54 minutes ago
    Developer

    I tried this with my wife's VOIP massage business number. Which detected as VOIP here https://www.phonevalidator.com/. I got the "invalid number" message instead of the VOIP error. I'll zulip you the number I tried, to make sure we're still getting the VOIP error

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::Review label 54 minutes ago

    added scoped label and automatically removed label

Please register or sign in to reply
Assignee
Marcelo Rivera's avatar
Marcelo Rivera @eiennohi
Registration and Onboarding Web
Epic
Registration and Onboarding Web
Sprint::01/29 Abatic Aenome
Milestone
Sprint::01/29 Abatic Aenome
Time tracking
Spent 4h
Est 2h
Feb 11, 2020
Due date
Feb 11, 2020
4
Labels
Platform::Browser Sprint::02/12 - Baritone Baboon Squad::Blue Status::Requires Changes
2
Weight
2
Confidentiality
Not confidential
Lock issue
Unlocked
4
4 participants
user avatar
user avatar
user avatar
user avatar
Reference: minds/engine#1319