Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 409
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !736

Merged
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Add ability to upload avatar into onboarding

  • Overview 22
  • Commits 46
  • Pipelines 14
  • Changes 14
6/7 threads resolved

closes #2411 (closed)

Request to merge feat/add-avatar-uploading into master
Pipeline #119370770 passed with warnings for 11367cae on feat/add-avatar-uploading
              Merge request approved. Approved by
              Brian Hatchet Xander Miller
              Martin Santangelo Juan Manuel Solaro Mark Harding Ben Hayward Emiliano Balbuena

              Merged by Brian Hatchet 1 hour ago

              The changes were merged into master with e98ef5cb

              The source branch has been deleted

              Closed #2411 (closed)

              Pipeline #119395894 running for e98ef5cb on master
                              • Marcelo Rivera @eiennohi added Sprint::01/15 - Youthful Yabby Squad::Blue scoped labels 3 weeks ago

                                added scoped labels

                              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                                added 1 commit

                                • 7f3738e4 - (fix): e2e tests

                                Compare with previous version

                              • Marcelo Rivera @eiennohi added 26 commits 3 weeks ago

                                added 26 commits

                                • 8f74ef12 - (feat): add "Join the conversation" link to /register
                                • f3443338 - (fix): group and channel names overflow issue
                                • 3dfbec6e - (feat): export user counts
                                • 30323aad - (fix): Disable email confirmation banner in onboarding screens
                                • 527ef4d2 - (chore): Remove console.log
                                • bacd664d - (fix): redirection
                                • 92b8d0e2 - (fix): android app logo should redirect to /mobile
                                • ce381393 - (fix): ios safari issue
                                • 5fceb0e3 - (fix): terms moving when clicking it issue
                                • 67f7c523 - (fix): issue in signup-on-scroll modal
                                • a7fe0c56 - (fix): bottom should be 0px
                                • 2525660e - Merge remote-tracking branch 'upstream/master' into fix/onboarding-issues
                                • 3cb05564 - (fix): button should shrink more than the input
                                • a2da2df1 - (fix): double negative in signup-on-scroll
                                • 34be9f85 - (fix): made the register form a little smaller in the homepage
                                • 51cd7162 - (fix): sizes for progressbar in mobile onboarding
                                • 707cd2c9 - (fix): correctly handle username and group name overflow
                                • af672c71 - (fix): change detection issues in lists
                                • bc3a353c - (fix): use visibility: hidden for hiding re-captcha
                                • 31cc0155 - (fix): send export_user_counts to feeds endpoint
                                • 3c5dadfe - (fix): changed "members" to "subscribers" for channels list
                                • a09ef86d - (fix): use 1y vs 30d for channels and groups suggestions
                                • dba729af - (fix): properly center forms on desktop resolutions
                                • 91e5f03d - Merge branch 'fix/onboarding-issues' into feat/add-avatar-uploading
                                • 0a746866 - (feat): add cancel button
                                • fdea3a33 - (fix): e2e tests

                                Compare with previous version

                                Toggle commit list
                              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                                added 1 commit

                                • 550c3a37 - (fix): add missing package-lock.json

                                Compare with previous version

                              • Xander Miller @xander-miller approved this merge request 3 weeks ago

                                approved this merge request

                              • Xander Miller
                                Xander Miller @xander-miller · 3 weeks ago
                                Developer

                                Looks good.

                              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 3 weeks ago

                                approved this merge request

                                • Olivia Madrid
                                  Olivia Madrid @omadrid · 3 weeks ago
                                  Developer
                                  Resolved by Brian Hatchet 2 weeks ago

                                  Does this icon look super facebook-y to anyone else? image

                                • Marcelo Rivera Brian Hatchet
                                  Last reply by Brian Hatchet 2 weeks ago
                                • Olivia Madrid
                                  Olivia Madrid @omadrid · 3 weeks ago
                                  Developer
                                  Resolved by Marcelo Rivera 2 weeks ago

                                  If I try to upload a file type that isn't an image/gif, I get this screen and am allowed to proceed.

                                  image

                                  Also - if I had previously uploaded an image and then pressed 'cancel', then tried to upload a non-image file type, then proceed with the screen above, my avatar becomes the image that I had previously tried to cancel.

                                  Is that ok?

                                  Edited by Olivia Madrid 3 weeks ago
                                • Brian Hatchet Marcelo Rivera
                                  Last reply by Marcelo Rivera 2 weeks ago
                              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 3 weeks ago

                                unapproved this merge request

                                • Brian Hatchet
                                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                                  Developer
                                  Resolved by Brian Hatchet 2 weeks ago

                                  @eiennohi can you verify the avatar upload in Firefox? It crippled my browser trying to open the file select and I just want to be sure it's me

                                • Marcelo Rivera Brian Hatchet
                                  Last reply by Brian Hatchet 2 weeks ago
                              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                                added 1 commit

                                • d245c157 - (fix): only accept image types

                                Compare with previous version

                              • Marcelo Rivera @eiennohi added 21 commits 3 weeks ago

                                added 21 commits

                                • d245c157...2cb1c987 - 20 commits from branch master
                                • 6ee739a3 - Merge branch 'master' into 'feat/add-avatar-uploading'

                                Compare with previous version

                              • Marcelo Rivera @eiennohi changed target branch from master to production 2 weeks ago

                                changed target branch from master to production

                              • Marcelo Rivera @eiennohi added 6 commits 2 weeks ago

                                added 6 commits

                                • 6ee739a3...c6474453 - 5 commits from branch production
                                • 39e12b1e - Merge remote-tracking branch 'upstream/production' into feat/add-avatar-uploading

                                Compare with previous version

                              • Marcelo Rivera @eiennohi resolved all threads 2 weeks ago

                                resolved all threads

                              • Olivia Madrid
                                Olivia Madrid @omadrid started a thread on an old version of the diff 2 weeks ago
                                Resolved by Marcelo Rivera 2 weeks ago
                              • Marcelo Rivera @eiennohi changed target branch from production to master 2 weeks ago

                                changed target branch from production to master

                              • Marcelo Rivera @eiennohi resolved all threads 2 weeks ago

                                resolved all threads

                              • Marcelo Rivera @eiennohi added 66 commits 2 weeks ago

                                added 66 commits

                                • 39e12b1e...759cb8aa - 64 commits from branch master
                                • 21f64b95 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
                                • da3ef877 - (fix): remove references to window.Minds

                                Compare with previous version

                              • Olivia Madrid
                                Olivia Madrid @omadrid · 1 week ago
                                Developer

                                image

                              • Olivia Madrid @omadrid approved this merge request 1 week ago

                                approved this merge request

                              • Brian Hatchet
                                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 1 week ago
                                Resolved by Marcelo Rivera 1 week ago
                                • Brian Hatchet
                                  Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                                  Developer

                                  There' also a pretty weird user experience in firefox where the thumbnail preview shifts all the way to the left after I upload. This should be centered where the placeholder is

                                • Collapse replies
                                • Marcelo Rivera
                                  Marcelo Rivera @eiennohi · 1 week ago
                                  Developer

                                  This isn't a firefox-only behavior, and it comes from the plugin itself for images with certain dimensions, so I cannot fix it. For now I removed both the border and the white background so it's not that noticeable. Do you want me to create an issue in the plugin's repo?

                                • Please register or sign in to reply
                              • Marcelo Rivera @eiennohi added 31 commits 1 week ago

                                added 31 commits

                                • da3ef877...745769a5 - 28 commits from branch master
                                • 588c71e7 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
                                • 1e0aae5c - (fix): remove console.log
                                • e6cdc436 - (fix): remove border and white background from image-cropper

                                Compare with previous version

                                Toggle commit list
                                • Brian Hatchet
                                  Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                                  Developer
                                  Resolved by Marcelo Rivera 3 hours ago

                                  merge conflicts

                                • Please register or sign in to reply
                              • Marcelo Rivera @eiennohi added 20 commits 5 days ago

                                added 20 commits

                                • e6cdc436...6822f8c9 - 18 commits from branch master
                                • 332fb5a2 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
                                • 66e702a1 - (fix): cleanup

                                Compare with previous version

                              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

                                approved this merge request

                              • Xander Miller
                                Xander Miller @xander-miller · 4 hours ago
                                Developer

                                Wizard works but ppload isn't persisting on to channel after onboarding is complete.

                                image

                              • Xander Miller
                                Xander Miller @xander-miller · 3 hours ago
                                Developer

                                Info step still has finish button, should be next button.

                                image

                              • Marcelo Rivera @eiennohi added 1 commit 3 hours ago

                                added 1 commit

                                • 11367cae - (fix): button labels

                                Compare with previous version

                              • Xander Miller
                                Xander Miller @xander-miller · 1 hour ago
                                Developer

                                Works.

                                image

                              • Xander Miller @xander-miller approved this merge request 1 hour ago

                                approved this merge request

                              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 hour ago

                                approved this merge request

                              • Brian Hatchet :speech_balloon: @brianhatchet enabled an automatic merge when the pipeline for 11367cae succeeds 1 hour ago

                                enabled an automatic merge when the pipeline for 11367cae succeeds

                              • Brian Hatchet :speech_balloon: @brianhatchet merged 1 hour ago

                                merged

                              • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit e98ef5cb 1 hour ago

                                mentioned in commit e98ef5cb

                              Please register or sign in to reply
                              0 Assignees
                              None
                              None
                              Milestone
                              None
                              Time tracking
                              No estimate or time spent
                              2
                              Labels
                              Sprint::01/15 - Youthful Yabby Squad::Blue
                              Lock merge request
                              Unlocked
                              10
                              10 participants
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              Reference: minds/front!736