Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 275
  • Merge Requests 33
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !450

Merged
Opened 3 weeks ago by Emiliano Balbuena@edgebal
Report abuse

Signup events for analytics

  • Overview 9
  • Commits 4
  • Pipelines 4
  • Changes 2
2/2 threads resolved

Summary

Push signup events to analyze user conversions

  • Closes #1240 (closed)
  • Closes #1359 (closed)

ElasticSearch Mappings

  • NEW: minds-metrics-* -> bool pro_referrer

Steps to test

  • Port forward sandbox sites elasticsearch cluster to your local machine (optional)
  • Open your elasticsearch browser and open minds-metrics-* index
  • Sort by @timestamp descending
  • Open the review site, and create a new user. Don't do anything else after that to avoid unnnecesary events.
  • Refresh your minds-metrics-* view on ElasticSearch browser
  • Ensure there's a signup metric with a user_guid and a cookie_id value set (might be the third or fourth row from the top). Filtering by cookie_id (which has the same value a mwa cookie on the website).
  • Log out from the site.
  • Create a new user using this link: https://goal-signup-cookie-id.minds.io/register?referrer=0xEMI
  • Refresh your minds-metrics-* view on ElasticSearch browser
  • Ensure there's a new signup metric with referrer_guid and pro_referrer set to true.

Note: This one might be tricky for @xander-miller to test as it's a backend-only storage change. The main concern is to ensure new user registration works OK.

Example data: image

Estimated Regression Scope

New block of code executed at register/complete event, might affect user sign-up.

Edited 1 day ago by Emiliano Balbuena
Request to merge goal/signup-cookie-id into master
Pipeline #118915840 passed for 257133da on goal/signup-cookie-id
          Merge request approved. Approved by
          Brian Hatchet Xander Miller
          Martin Santangelo Mark Harding Ben Hayward Marcelo Rivera Rami Albatal

          Merged by Brian Hatchet 1 hour ago

          The changes were merged into master with c28af3ce

          The source branch has been deleted

          Closed #1240 (closed) and #1359 (closed)

          Pipeline #119359712 waiting for manual action for c28af3ce on master
                          • Emiliano Balbuena @edgebal added Squad::Yellow Status::Awaiting Review scoped labels 3 weeks ago

                            added scoped labels

                          • Emiliano Balbuena @edgebal changed the description 3 weeks ago

                            changed the description

                          • Emiliano Balbuena @edgebal mentioned in issue #1240 (closed) 3 weeks ago

                            mentioned in issue #1240 (closed)

                          • Emiliano Balbuena @edgebal assigned to @benhayward.ben 3 weeks ago

                            assigned to @benhayward.ben

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 3 weeks ago
                            Developer

                            @Xander if you need help getting set-up to test this one also, DM me.

                          • Mark Harding @markeharding approved this merge request 2 weeks ago

                            approved this merge request

                          • Emiliano Balbuena @edgebal changed target branch from master to production 2 weeks ago

                            changed target branch from master to production

                          • Emiliano Balbuena @edgebal added 21 commits 1 week ago

                            added 21 commits

                            • dcaa9f5d...fec60070 - 4 commits from branch production
                            • de6fd8ed - (wip): Frontend rendering module
                            • 7e2c2364 - Merge branch 'master' of https://gitlab.com/Minds/engine into epic/SSR
                            • dcaea0d4 - (chore): ci fixes
                            • f2751134 - Merge branch 'master' of https://gitlab.com/Minds/engine into epic/SSR
                            • 9a498785 - (chore): ci for preprod
                            • 5562dca5 - (chore): export pro on api config
                            • 1d9730a6 - Merge branch 'master' of https://gitlab.com/Minds/engine into epic/SSR
                            • 1ccf1085 - (chore): allow master to push to preprod too
                            • d3b9a8ec - Merge branch 'epic/SSR'
                            • e4fdcb9e - (chore): january token gift
                            • 550c417c - Merge branch 'production' of https://gitlab.com/Minds/engine
                            • 85275399 - (chore): bring sandbox helm chart branch to master
                            • 2d4ca7d6 - (feat): backend for captcha - front#646 (closed)
                            • 7c362781 - Merge branch 'feat/646-captcha' into 'master'
                            • 5c3e5b05 - Add environment support to Feature services
                            • 5e9b7bb9 - Merge branch 'goal/unleash-sync-namespaces' into 'master'
                            • f880bb3a - Merge remote-tracking branch 'origin/master' into goal/signup-cookie-id

                            Compare with previous version

                            Toggle commit list
                          • Emiliano Balbuena @edgebal changed target branch from production to master 1 week ago

                            changed target branch from production to master

                          • Emiliano Balbuena
                            Emiliano Balbuena @edgebal · 1 week ago
                            Developer

                            @benhayward.ben I just re-started review site for this MR.

                          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                            approved this merge request

                          • Emiliano Balbuena
                            Emiliano Balbuena @edgebal · 1 week ago
                            Developer

                            @benhayward.ben You couldn't create a new account because I needed to create a matching front branch that had the captcha fixed.

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 week ago
                              Developer
                              Resolved by Emiliano Balbuena 1 week ago

                              Give me a ping when this is ready Emi - I think you said you needed to add email confirmation?

                            • Emiliano Balbuena
                              Last reply by Emiliano Balbuena 1 week ago
                          • Emiliano Balbuena @edgebal resolved all threads 1 week ago

                            resolved all threads

                          • Ben Hayward @benhayward.ben approved this merge request 1 week ago

                            approved this merge request

                          • Ben Hayward @benhayward.ben added Status::QA Review scoped label and automatically removed Status::Awaiting Review label 1 week ago

                            added scoped label and automatically removed label

                          • Ben Hayward @benhayward.ben assigned to @xander-miller and unassigned @benhayward.ben 1 week ago

                            assigned to @xander-miller and unassigned @benhayward.ben

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 1 week ago
                            Developer

                            image

                            All working fine for me!

                          • Mark Harding
                            Mark Harding @markeharding started a thread on an old version of the diff 6 days ago
                            Resolved by Emiliano Balbuena 1 day ago
                          • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::QA Review label 6 days ago

                            added scoped label and automatically removed label

                          • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 6 days ago

                            unapproved this merge request

                          • Emiliano Balbuena @edgebal changed the description 1 day ago

                            changed the description

                          • Emiliano Balbuena @edgebal added 11 commits 1 day ago

                            added 11 commits

                            • f880bb3a...5c9218c9 - 10 commits from branch master
                            • bbb4eb82 - Merge remote-tracking branch 'origin/master' into goal/signup-cookie-id

                            Compare with previous version

                          • Emiliano Balbuena @edgebal added 1 commit 1 day ago

                            added 1 commit

                            • 257133da - (feat): Referrer Pro status and missing fields

                            Compare with previous version

                          • Emiliano Balbuena @edgebal resolved all threads 1 day ago

                            resolved all threads

                          • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 day ago

                            added scoped label and automatically removed label

                          • Emiliano Balbuena @edgebal assigned to @benhayward.ben and unassigned @xander-miller 1 day ago

                            assigned to @benhayward.ben and unassigned @xander-miller

                          • Emiliano Balbuena @edgebal changed the description 1 day ago

                            changed the description

                          • Ben Hayward
                            Ben Hayward @benhayward.ben · 1 day ago
                            Developer

                            All good from me image

                          • Ben Hayward @benhayward.ben assigned to @brianhatchet, @xander-miller, and @markeharding and unassigned @edgebal 1 day ago

                            assigned to @brianhatchet, @xander-miller, and @markeharding and unassigned @edgebal

                          • Xander Miller
                            Xander Miller @xander-miller · 1 hour ago
                            Developer

                            user Registration works. Ben's screen shots of the analytics results are satisfactory proof for me that that part is tested and working.

                          • Xander Miller @xander-miller approved this merge request 1 hour ago

                            approved this merge request

                          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 hour ago

                            approved this merge request

                          • Brian Hatchet :speech_balloon: @brianhatchet merged 1 hour ago

                            merged

                          • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit c28af3ce 1 hour ago

                            mentioned in commit c28af3ce

                          Please register or sign in to reply
                          4 Assignees
                          Mark Harding's avatar
                          Brian Hatchet's avatar
                          Xander Miller's avatar
                          Ben Hayward's avatar
                          None
                          Milestone
                          None
                          Time tracking
                          No estimate or time spent
                          2
                          Labels
                          Squad::Yellow Status::Awaiting Review
                          Lock merge request
                          Unlocked
                          10
                          10 participants
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          user avatar
                          Reference: minds/engine!450