[Sprint/PinkPanther](fix): Delete activity after moderation queue rejection #504
Closes #504
Summary
On production right now, if you reject a post in a group you moderate, the post no longer appears in the queue, but still shows up in the feed for mods only like so:
Testing
- Make a group, make it moderated.
- Login to a secondary account, create posts numbered 1, 2, 3, 4, 5.
- Log-in to primary account, look at the group, see the posts with "awaiting moderation"
- Go to the moderation queue and reject the post numbered 3.
- Check that the activity with the content '3' is not visible on the feed with its "awaiting moderation"
added scoped labels
added 69 commits
-
52f5c842...a8a3fed6 - 68 commits from branch
master - 009351e2 - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
52f5c842...a8a3fed6 - 68 commits from branch
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Resolved by Ben Hayward- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added scoped label and automatically removed label
added 2 commits
added scoped label and automatically removed label
added 3 commits
-
b1f82ae1...52a592b9 - 2 commits from branch
master - 5d25f8fe - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
b1f82ae1...52a592b9 - 2 commits from branch
resolved all threads
- Developer
Need to pull master in and get this reviewed.
added 139 commits
-
5d25f8fe...dd03087f - 138 commits from branch
master - d34b0c09 - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
5d25f8fe...dd03087f - 138 commits from branch
added scoped label and automatically removed label
- Developer
pipeline failing for me
added scoped label and automatically removed label
added scoped label and automatically removed label
added scoped label and automatically removed label
- Developer
Restarted pipeline multiple more times, others have passed, this one does not.
added 3 commits
-
d34b0c09...b08a0e7b - 2 commits from branch
master - 339fb3de - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
d34b0c09...b08a0e7b - 2 commits from branch
- Developer
Gonna give it one more try.
added 4 commits
-
339fb3de...6e96d473 - 3 commits from branch
master - a80ad7dc - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
339fb3de...6e96d473 - 3 commits from branch
- Developer
Restarted twice through the day (once pulling master), going again and moving to blocked as I do not anticipate it to work.
added scoped label and automatically removed label
![Emiliano Balbuena](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperSandbox site worked OK. I was able to test and the outcome was the expected one.
assigned to @benhayward.ben, @markeharding, and @brianhatchet
approved this merge request
15 protected $eventsDispatcher; 16 17 /** @var mixed */ 18 protected $activity; 19 20 /** 21 * Save constructor. 22 * @param null $eventsDispatcher 23 */ 24 public function __construct( 25 $eventsDispatcher = null 26 ) { 27 $this->eventsDispatcher = $eventsDispatcher ?: Di::_()->get('EventsDispatcher'); 28 } 29 30 /** - Developer
Awesome
- Developer
Code looks great @benhayward.ben I just need to resurrect your pod since it got purged
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}