Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 407
  • Merge Requests 66
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !786

Merged
Opened 20 hours ago by Ben Hayward@benhayward.ben
Report abuse

Black youtube preview #2585

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Summary

YT depreciated something on their endpoint, the embed needs to use controls=1, and controls=2 shows a black preview.

Steps to test

  1. Open a comment
  2. Post a youtube link
  3. After posting, make sure the video has a preview and is not a black box with a play button.

Estimated Regression Scope

Not huge regression scope, worst case something goes wrong with youtube embeds.

Request to merge fix/black-youtube-preview-2585 into master
Pipeline #119067303 passed with warnings for a53b882f on fix/black-youtube-preview-2585
              Merge request approved. Approved by
              Xander Miller Emiliano Balbuena Mark Harding
              Martin Santangelo Juan Manuel Solaro Marcelo Rivera Brian Hatchet Rami Albatal

              Merged by Xander Miller 53 minutes ago

              The changes were merged into master with 9764b044

              The source branch has been deleted

              Mentions #2585

              Pipeline #119353429 running for 9764b044 on master
                              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 20 hours ago

                                added scoped labels

                              • Mark Harding @markeharding approved this merge request 9 hours ago

                                approved this merge request

                              • Emiliano Balbuena @edgebal approved this merge request 4 hours ago

                                approved this merge request

                              • Xander Miller @xander-miller approved this merge request 53 minutes ago

                                approved this merge request

                              • Xander Miller @xander-miller merged 53 minutes ago

                                merged

                              • Xander Miller @xander-miller mentioned in commit 9764b044 53 minutes ago

                                mentioned in commit 9764b044

                              Please register or sign in to reply
                              0 Assignees
                              None
                              None
                              Milestone
                              None
                              Time tracking
                              No estimate or time spent
                              2
                              Labels
                              Squad::Yellow Status::Awaiting Review
                              Lock merge request
                              Unlocked
                              10
                              10 participants
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              Reference: minds/front!786