Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 407
  • Merge Requests 68
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !788

Open
Opened 19 minutes ago by Ben Hayward@benhayward.ben
Report abuse

Fix legacy usd option appearing

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Summary

Closes #2593

Legacy boost prompt that allows payment in USD still appears sometimes.

Rather than refactoring down the class right now I've opted to stop it showing. We should schedule a refactor / remake of this in the future.

Steps to test

  1. Go to someone else's channel and click to Wire them on a post.
  2. Toggle over to send them USD.
  3. Exit wire prompt without making payment.
  4. Go back to your channel and click boost on your post.
  5. There should be nothing like the below image in the modal window.

image

Estimated Regression Scope

Maybe it could show at an inappropriate time, or in some circumstance the cookie works. Maybe this creator is re-used somewhere where USD is valid that I am unaware of/

Edited 13 minutes ago by Ben Hayward
Request to merge fix/legacy-usd-boosts-1341 into master
Open in Web IDE
Pipeline #119340443 running for cae333a7 on fix/legacy-usd-boosts-1341
              Requires 3 more approvals from Devs, Deployers, and QA.
              Martin Santangelo Juan Manuel Solaro Mark Harding Emiliano Balbuena Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2593

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 19 minutes ago

                added scoped labels

              • Ben Hayward @benhayward.ben added 1 commit 16 minutes ago

                added 1 commit

                • cae333a7 - Fixed legacy usd modal showing for boosts

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 13 minutes ago

                changed the description

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!788