Fix/url hashtag count #2361
Summary
Closes #2361
** note this MR includes the new installer changes, wait for that before merge **
Added in a check for whether the matching tag is located in a URL.
Steps to Test
This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:
- Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
- Try a URL with a hashtag in.
- Check the hashtags links go through to the correct place.
- Try to use the hashtag selector to bypass the limit
- Ensure when you add a tag it shows up in the selector
Estimated Regression Scope
This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag
added scoped label
added 12 commits
-
0e69ebb8...745769a5 - 11 commits from branch
master
- 547ff898 - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count
-
0e69ebb8...745769a5 - 11 commits from branch
- Developer
Works pretty good for most of the cases I tried, but it seems that it parses the first half of a word that starts with the pound sign as a hashtag as well. Check the image below:
Edited by Emiliano Balbuena added scoped label
assigned to @benhayward.ben
added 5 commits
-
547ff898...28b1e2b3 - 4 commits from branch
master
- 6782df1a - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count
-
547ff898...28b1e2b3 - 4 commits from branch
- DeveloperEdited by Ben Hayward
added 6 commits
-
6782df1a...4d90e094 - 4 commits from branch
master
- 4321812a - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count
- 5cfdc4d8 - Fixed issue tagging non-tags
-
6782df1a...4d90e094 - 4 commits from branch
- Developer
Works OK!
approved this merge request
added scoped label and automatically removed label
added 28 commits
-
b7c38f1b...18d19ab7 - 27 commits from branch
master
- 8d8bfb36 - Merge remote-tracking branch 'origin/master' into fix/url-hashtag-count
-
b7c38f1b...18d19ab7 - 27 commits from branch
approved this merge request
- Developer
approved this merge request
- Developer
Needs more approvals
added 4 commits
-
8d8bfb36...bac5ec87 - 3 commits from branch
master
- a56582e5 - Merge branch 'master' into 'fix/url-hashtag-count'
-
8d8bfb36...bac5ec87 - 3 commits from branch
- Developer
Reapproval would be appreciated. Another single line merge conflict in import statements.