Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 67
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !772

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

Fix/url hashtag count #2361

  • Overview 6
  • Commits 15
  • Pipelines 7
  • Changes 9

Summary

Closes #2361

** note this MR includes the new installer changes, wait for that before merge **

Added in a check for whether the matching tag is located in a URL.

Steps to Test

This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:

  1. Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
  2. Try a URL with a hashtag in.
  3. Check the hashtags links go through to the correct place.
  4. Try to use the hashtag selector to bypass the limit
  5. Ensure when you add a tag it shows up in the selector

Estimated Regression Scope

This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag

Request to merge fix/url-hashtag-count into master
The source branch is 1 commit behind the target branch
Open in Web IDE
Pipeline #119270479 running for a56582e5 on fix/url-hashtag-count
              Requires 3 more approvals from Devs, Deployers, and QA.
              Juan Manuel Solaro Mark Harding Emiliano Balbuena Marcelo Rivera Brian Hatchet
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2361

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 1 week ago

                added scoped label

              • Ben Hayward @benhayward.ben added 12 commits 6 days ago

                added 12 commits

                • 0e69ebb8...745769a5 - 11 commits from branch master
                • 547ff898 - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count

                Compare with previous version

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 6 days ago
                Developer

                Works pretty good for most of the cases I tried, but it seems that it parses the first half of a word that starts with the pound sign as a hashtag as well. Check the image below:

                image

                Edited by Emiliano Balbuena 6 days ago
              • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label 6 days ago

                added scoped label

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 6 days ago

                assigned to @benhayward.ben

              • Ben Hayward @benhayward.ben added 5 commits 6 days ago

                added 5 commits

                • 547ff898...28b1e2b3 - 4 commits from branch master
                • 6782df1a - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 6 days ago
                Developer

                No worries. Very weird though because it's not happening locally, but definitely is on the sandbox.

                image

                Edited by Ben Hayward 6 days ago
              • Ben Hayward @benhayward.ben added 6 commits 5 days ago

                added 6 commits

                • 6782df1a...4d90e094 - 4 commits from branch master
                • 4321812a - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count
                • 5cfdc4d8 - Fixed issue tagging non-tags

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 5 days ago

                added 1 commit

                • b7c38f1b - Un needed import

                Compare with previous version

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 5 days ago
                Developer

                Works OK!

              • Emiliano Balbuena @edgebal approved this merge request 5 days ago

                approved this merge request

              • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 5 days ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet added 28 commits 19 hours ago

                added 28 commits

                • b7c38f1b...18d19ab7 - 27 commits from branch master
                • 8d8bfb36 - Merge remote-tracking branch 'origin/master' into fix/url-hashtag-count

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 19 hours ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 17 hours ago
                Developer

                image

              • Xander Miller @xander-miller approved this merge request 17 hours ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 17 hours ago
                Developer

                Needs more approvals

              • Ben Hayward @benhayward.ben added 4 commits 1 hour ago

                added 4 commits

                • 8d8bfb36...bac5ec87 - 3 commits from branch master
                • a56582e5 - Merge branch 'master' into 'fix/url-hashtag-count'

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 hour ago
                Developer

                Reapproval would be appreciated. Another single line merge conflict in import statements.

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!772