Fix/signed wire threshold export 2004
Closes front#2004
Summary
Users could not view their own and others paywalled content. See the steps on the issue above and try it out for yourself.
Test
- Make a paywalled media post (image)
- Refresh and check you can click the unlock button and see the image
- Go to the media page for the image
- Check you can see the image (note the url)
- Log out
- Visit URL - should not be able to access
- Visit the channel that posted the paywalled image, try unlock the post. You should be prompted to send tokens.
Possible areas of regression
To test, I think we should test a variety of different media types, some with paywall and some without, from multiple accounts, and logged out, to ensure that everything is working.
added 3 commits
-
e6d328ba...dd03087f - 2 commits from branch
master - 26d89257 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004
-
e6d328ba...dd03087f - 2 commits from branch
![Ben Hayward](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
DeveloperReview failed, re-running start pipe.
- Developer
Took another 2 pipes down, re-running again.
added scoped labels
![Emiliano Balbuena](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperWorks OK!
assigned to @benhayward.ben, @brianhatchet, and @markeharding
approved this merge request
added scoped label and automatically removed label
- Developer
Note this needs testing on production
Mark Harding: Need to see if that works on production as its a cdn issue with no session
approved this merge request
DeveloperI went a bit off the testing path and found that paywalled content no longer works if you don't add an attachment.
added 7 commits
-
26d89257...6e96d473 - 5 commits from branch
master - 40839669 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004
- b11c2e3e - Added in default value for when no image
-
26d89257...6e96d473 - 5 commits from branch
- Last updated by Ben Hayward
42 43 if ($isAllowed) { 43 44 $entity->setPaywall(false); 44 45 46 // Sign URI so that user can view it. 47 $signedUri = new SignedUri(); 48 $signed = $entity->custom_data[0]['src'] ? - Developer
This line is going to throw an error (or a warning) for videos, as they have custom_data, but it's not an array.
I would just ditch the inline
? :, move all the$signedUrioperations below (within theif ($entity->type == 'activity') {scope) onto its ownif isset($entity->custom_type === 'batch') {). changed this line in version 4 of the diff
added scoped label and automatically removed label
marked as a Work In Progress
changed the description
added 8 commits
-
18b11072...4fb9ac89 - 7 commits from branch
master - 44335717 - Merge remote-tracking branch 'origin/master' into fix/signed-wire-threshold-export-2004
-
18b11072...4fb9ac89 - 7 commits from branch
unmarked as a Work In Progress
added scoped label and automatically removed label
added 1 commit
- 96815dc7 - Fixing a bug with setState on the jury and moderation report. We refactored...
added 1 commit
- ac584c41 - Revert "Fixing a bug with setState on the jury and moderation report. We...
DeveloperPushed to the wrong branch. Derp
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
