Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 66
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !775

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

Upgraded Plyr #2572

  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 2

Closes #2572,

Summary

Plyr has put forth an update that should address the volume control going missing for some users.

Removed logic to hide/show volume controls based on audio track detection due to it's problematic nature. If you want to hide volume control, use the controls option to do so.

https://github.com/sampotts/plyr/releases

Steps to test

  1. Check video player all working properly
  2. Make sure that you can see the volume control on Chrome and Firefox

Estimated Regression Scope

If there's a broken change, that is not in our control. Branch has been officially released.

Request to merge chore/plyr-upgrade-2572 into master
Open in Web IDE
Pipeline #119042945 failed for afdef14c on chore/plyr-upgrade-2572
              Requires 3 more approvals from Devs, Deployers, and QA.
              Olivia Madrid Martin Santangelo Rami Albatal Mark Harding Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2572

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 1 week ago

                added scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 46 minutes ago
                Developer

                Let's get this one closed off and make way for forking the ngx-plyr wrapper and fixing the type / update errors there

              • Brian Hatchet :speech_balloon: @brianhatchet added 75 commits 45 minutes ago

                added 75 commits

                • d99379c4...18d19ab7 - 74 commits from branch master
                • afdef14c - Merge remote-tracking branch 'origin/master' into chore/plyr-upgrade-2572

                Compare with previous version

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!775