Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 68
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !777

Open
Opened 6 days ago by Ben Hayward@benhayward.ben
Report abuse

Logged out update markers calls #2577

  • Overview 2
  • Commits 12
  • Pipelines 2
  • Changes 1

Summary

Closes #2577

In some weird set of circumstances, it appears that users can call the api/v1/groups/member endpoint while not logged in.

Steps to test

Neither I nor @brianhatchet have been able to replicate this locally.

Estimated Regression Scope

Not really much I can think of. It's just adding a logged in check to a function so that an endpoint with no purpose for a logged-out user, isn't called when logged out.

Request to merge fix/logged-out-update-markers-2577 into master
Open in Web IDE
Pipeline #118948247 running for f77266ab on fix/logged-out-update-markers-2577
              Requires 3 more approvals from Devs, Deployers, and QA.
              Olivia Madrid Martin Santangelo Rami Albatal Mark Harding Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2577

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 6 days ago

                added scoped labels

              • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 5 days ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 5 hours ago
                Owner

                @benhayward.ben looks like some other stuff got put in here. Can you cleanup before we merge?

              • Mark Harding @markeharding assigned to @benhayward.ben 5 hours ago

                assigned to @benhayward.ben

              • Ben Hayward @benhayward.ben added 42 commits 58 minutes ago

                added 42 commits

                • 79aa76a4...d3223fbc - 41 commits from branch master
                • f77266ab - Merge branch 'master' of gitlab.com:minds/front into fix/logged-out-update-markers-2577

                Compare with previous version

              • Ben Hayward @benhayward.ben added Status::Review scoped label and automatically removed Status::Requires Changes label 58 minutes ago

                added scoped label and automatically removed label

              • Ben Hayward
                Ben Hayward @benhayward.ben · 57 minutes ago
                Developer

                Ah sorry, it had some of Emi's stack changes in there that were meant to disappear when merged but ended up changed.

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!777