Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 68
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !784

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
Report abuse

Removed Remind and Boost buttons in closed groups #2586

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 4

Summary

Closes #2586

image

Steps to test

  • Closed group https://fix-closed-group-remind-boost-2586.minds.io/groups/profile/1075189549673484302/feed
  • Open group https://fix-closed-group-remind-boost-2586.minds.io/groups/profile/1075189737242759171/feed

Try a variety of group configurations, check that the remind and boost are not hidden on other areas of the site.

Estimated Regression Scope

In the worst-case scenario maybe boost and remind buttons would not be shown when they should be.

Edited 3 days ago by Ben Hayward
Request to merge fix/closed-group-remind-boost-2586 into master
The source branch is 72 commits behind the target branch
Open in Web IDE
Pipeline #118085694 passed with warnings for e384309c on fix/closed-group-remind-boost-2586
              Merge request approved. Approved by
              Emiliano Balbuena Mark Harding
              Olivia Madrid Martin Santangelo Rami Albatal Marcelo Rivera Juan Manuel Solaro
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2586

              Deletes source branch

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 days ago
                Developer

                I'll get some groups set up once the sandbox is done running

              • Ben Hayward @benhayward.ben mentioned in issue minds#796 (moved) 3 days ago

                mentioned in issue minds#796 (moved)

              • Ben Hayward @benhayward.ben changed the description 3 days ago

                changed the description

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 3 days ago

                added scoped labels

              • Mark Harding @markeharding approved this merge request 4 hours ago

                approved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 3 hours ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 3 hours ago
                Developer

                Works OK.

                Edited by Emiliano Balbuena 3 hours ago
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!784