Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 402
  • Merge Requests 66
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !733

Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

WIP: CKEditor5 Blog PoC

  • Overview 17
  • Commits 22
  • Pipelines 12
  • Changes 15
9/10 threads resolved

Summary

Closes #2333

Depends on engine!448 This is a PoC for testing and evaluation.

We are going to need to fork the balloon editor and upload the package via NPM, so that we can make a lightly customized build where we enable the Alignment plugin. Because we are going the custom-build route, there is also no image upload, as the code for the UploadAdapter will likely change when separating from the Balloon build.

Steps to test

  1. Make a new blog.
  2. Edit it. The url should still be /blog/edit/:guid
  3. Old editor should still work fine.
  4. Change the URL to blog-v2 e.g. /blog-v2/edit/:guid
  5. Play with new editor, remember alignment and upload are going to require additional work.
  6. Save.
  7. Hit edit again, it should link to the /blog-v2/edit/:guid again as the editor_version variable has changed

Estimated Regression Scope

As this is not to go live; there isn't a huge scope for regression. If this is tested on Staging or in another environment, any regressions would be in former blogs, as the v2-blogs route isn't known to users.

Edited 2 weeks ago by Ben Hayward
Request to merge feat/ckeditor-blogs-2333 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #118037985 failed for dcd0c2eb on feat/ckeditor-blogs-2333
              Requires 3 more approvals from Devs, Deployers, and QA.
              Juan Manuel Solaro Mark Harding Emiliano Balbuena Olivia Madrid Marcelo Rivera
              This is a Work in Progress

              Closes #2333

              Deletes source branch

              You can merge this merge request manually using the
              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Requires Changes scoped labels 3 weeks ago

                added scoped labels

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 2 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Last updated by Ben Hayward 2 weeks ago
                src/app/modules/blogs-v2/blog-v2.module.ts
                11
                12 // import { WireModule } from '../wire/wire.module';
                13 // import { CommentsModule } from '../comments/comments.module';
                14 // import { HashtagsModule } from '../hashtags/hashtags.module';
                15 import { CanDeactivateGuardService } from '../../services/can-deactivate-guard';
                16 import { CKEditorModule } from '@ckeditor/ckeditor5-angular';
                17 import { BlogEditor } from './editor/editor';
                18 import { BlogEdit } from './edit/edit';
                19 import { WireModule } from '../wire/wire.module';
                20 import { CommentsModule } from '../comments/comments.module';
                21 import { HashtagsModule } from '../hashtags/hashtags.module';
                22 import { LegacyModule } from '../legacy/legacy.module';
                23
                24 const routes: Routes = [
                25 {
                26 path: 'blog-v2/edit/:guid',
                • Mark Harding
                  Mark Harding @markeharding · 3 weeks ago
                  Owner

                  bad path, keep consistent with blog routes

                • Ben Hayward
                  Ben Hayward @benhayward.ben · 2 weeks ago
                  Developer

                  I recognize the importance of this, but as we're evaluating it as PoC I think it is valuable to leave like this right now so that we are able to take any blog, and simply change the URL segment from blog to blog-v2 to see how it fares in the new editor.

                  Leaving unresolved however as a todo.

                • Ben Hayward @benhayward.ben changed this line in version 8 of the diff 2 weeks ago

                  changed this line in version 8 of the diff

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 2 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Ben Hayward 3 weeks ago
              • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                added 1 commit

                • 9ee0445e - Update for feedback

                Compare with previous version

              • Ben Hayward @benhayward.ben added 3 commits 3 weeks ago

                added 3 commits

                • c63e1593 - Added in border around editor
                • dbd56a5a - Added ckeditor5 alignment plugin
                • f85b4607 - Added in config

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 9048abd6 - updated to add custom editor_version attribute and digest it

                Compare with previous version

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 weeks ago

                unmarked as a Work In Progress

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 2 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 57e53512 - Tidying and removing legacy tests

                Compare with previous version

              • Ben Hayward @benhayward.ben added 34 commits 2 weeks ago

                added 34 commits

                • 57e53512...9f5a7a2b - 33 commits from branch master
                • fa17ae44 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • cb7b5b8d - Updated CSS

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 05f6c931 - Refactored and merged into singular module.

                Compare with previous version

              • Ben Hayward @benhayward.ben added 6 commits 2 weeks ago

                added 6 commits

                • 05f6c931...1359c6d9 - 4 commits from branch master
                • 4e9f4e04 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • c0e11cab - Adding in new files for module

                Compare with previous version

              • Ben Hayward @benhayward.ben mentioned in issue minds#864 1 week ago

                mentioned in issue minds#864

              • Ben Hayward @benhayward.ben added 80 commits 1 week ago

                added 80 commits

                • c0e11cab...c6310433 - 77 commits from branch master
                • 6ea6f47f - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • 55613e00 - WIP changes
                • 0849786b - Updated to fix save feat post SSR merge

                Compare with previous version

                Toggle commit list
              • Ben Hayward @benhayward.ben marked as a Work In Progress from 55613e00 1 week ago

                marked as a Work In Progress from 55613e00

              • Ben Hayward @benhayward.ben added 23 commits 2 days ago

                added 23 commits

                • 0849786b...745769a5 - 22 commits from branch master
                • 0c9fcdb1 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333

                Compare with previous version

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                Developer

                Getting this error message when I try to edit the url

                Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'blog-v2/edit/1074757606632853507' Error: Cannot match any routes. URL Segment: 'blog-v2/edit/1074757606632853507'

                To simplify the equation (since we have unleash), let's wire this up so the new blog editor is loaded when we create blogs, edit blogs, etc. We need to show this off to the stakeholders and reduce the level of complexity regarding testing it.

              • Ben Hayward @benhayward.ben added 24 commits 2 hours ago

                added 24 commits

                • 0c9fcdb1...6822f8c9 - 18 commits from branch master
                • da785d0b - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • 276b247c - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • 103fac6a - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • 87cd716f - Temp commit
                • f02b893f - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
                • dcd0c2eb - Current attempts to bypass SSR, progress check

                Compare with previous version

                Toggle commit list
              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 hours ago
                Developer

                https://www.lavalamp.biz/software-development/how-to-use-ckeditor-5-in-angular-with-server-side-rendering-support/

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!733