Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 277
  • Merge Requests 36
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !459

Open
Opened 1 week ago by Marcelo Rivera@eiennohi7 of 7 tasks completed7/7 tasks
Report abuse

Deny write permissions for new unverified users

  • Overview 5
  • Commits 23
  • Pipelines 7
  • Changes 22
3/3 threads resolved

closes #1300

Testing

This MR is for showing the blue email confirmation banner when a certain exception is thrown from the backend, which only applies to new registered users that haven't verified their emails.

First use an old user (older than the email confirmation task), and you should be able to do all of the following:

  • Create a post
  • Comment on a post
  • Vote up or down
  • Create group
  • Create blog
  • Upload images
  • Upload movies

Second, create a new user, don't verify its email address, hide the blue email confirmation banner by clicking on the X icon and try to do the same. Each time you try to do any of those, the blue banner should re-appear

Edited 1 week ago by Marcelo Rivera
Request to merge feat/unverified-users-permissions into master
Open in Web IDE
Pipeline #118046618 passed for c58923ec on feat/unverified-users-permissions
          Requires 3 more approvals from Devs, Deployers, and QA.
          Mark Harding Ben Hayward Emiliano Balbuena Olivia Madrid Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1300

          Deletes source branch

          • Marcelo Rivera @eiennohi added Squad::Blue Status::BuddyReview scoped labels 1 week ago

            added scoped labels

          • Marcelo Rivera @eiennohi changed the description 1 week ago

            changed the description

          • Marcelo Rivera @eiennohi added 1 commit 1 week ago

            added 1 commit

            • 334430f8 - (fix): updated spec tests for Votes\Manager

            Compare with previous version

          • Olivia Madrid @omadrid added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 3 days ago

            added scoped label and automatically removed label

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
            Resolved by Marcelo Rivera 57 minutes ago
            • Mark Harding
              Mark Harding @markeharding · 1 day ago
              Owner
              Resolved by Marcelo Rivera 52 minutes ago

              There are a bunch of places that acl write is being used. Lets not duplicate this call unless we have to.

            • Marcelo Rivera
              Last reply by Marcelo Rivera 52 minutes ago
            • Mark Harding
              Mark Harding @markeharding · 1 day ago
              Owner
              Resolved by Marcelo Rivera 52 minutes ago

              What about subscribing and other interact acl actions?

            • Marcelo Rivera
              Last reply by Marcelo Rivera 52 minutes ago
          • Marcelo Rivera @eiennohi resolved all threads 57 minutes ago

            resolved all threads

          • Marcelo Rivera @eiennohi added 18 commits 56 minutes ago

            added 18 commits

            • 334430f8...5c9218c9 - 10 commits from branch master
            • d5dd61e8 - Merge remote-tracking branch 'upstream/master' into feat/unverified-users-permissions
            • f67b0efa - (fix): remove acl check from Save as ElggEntity does it already
            • dda6687c - (feat): ACL check for wires
            • 256e99e1 - (fix): removed acl check from v1/media as it's already done in ElggEntity
            • 407ab5a1 - (fix): remove acl->write check from Votes\Manager
            • ee1fb98e - (fix): spec tests for SaveSpec
            • fbf39026 - (fix): remove ACL->write check from Blogs\Manager as it's done in the entity
            • c5ab2c9d - (feat): catch unverified users in comments

            Compare with previous version

            Toggle commit list
          • Marcelo Rivera @eiennohi added 1 commit 53 minutes ago

            added 1 commit

            • c58923ec - (fix): lint

            Compare with previous version

          • Marcelo Rivera @eiennohi resolved all threads 52 minutes ago

            resolved all threads

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Blue Status::Requires Changes
          Lock merge request
          Unlocked
          9
          9 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!459