WIP: CKEditor5 Blog PoC
Summary
Closes #2333
Depends on engine!448 This is a PoC for testing and evaluation.
We are going to need to fork the balloon editor and upload the package via NPM, so that we can make a lightly customized build where we enable the Alignment plugin. Because we are going the custom-build route, there is also no image upload, as the code for the UploadAdapter will likely change when separating from the Balloon build.
Steps to test
- Make a new blog.
- Edit it. The url should still be
/blog/edit/:guid
- Old editor should still work fine.
- Change the URL to blog-v2 e.g.
/blog-v2/edit/:guid
- Play with new editor, remember alignment and upload are going to require additional work.
- Save.
- Hit edit again, it should link to the
/blog-v2/edit/:guid
again as theeditor_version
variable has changed
Estimated Regression Scope
As this is not to go live; there isn't a huge scope for regression. If this is tested on Staging or in another environment, any regressions would be in former blogs, as the v2-blogs
route isn't known to users.
added scoped labels
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Last updated by Ben Hayward
11 12 // import { WireModule } from '../wire/wire.module'; 13 // import { CommentsModule } from '../comments/comments.module'; 14 // import { HashtagsModule } from '../hashtags/hashtags.module'; 15 import { CanDeactivateGuardService } from '../../services/can-deactivate-guard'; 16 import { CKEditorModule } from '@ckeditor/ckeditor5-angular'; 17 import { BlogEditor } from './editor/editor'; 18 import { BlogEdit } from './edit/edit'; 19 import { WireModule } from '../wire/wire.module'; 20 import { CommentsModule } from '../comments/comments.module'; 21 import { HashtagsModule } from '../hashtags/hashtags.module'; 22 import { LegacyModule } from '../legacy/legacy.module'; 23 24 const routes: Routes = [ 25 { 26 path: 'blog-v2/edit/:guid', - Owner
bad path, keep consistent with blog routes
- Developer
I recognize the importance of this, but as we're evaluating it as PoC I think it is valuable to leave like this right now so that we are able to take any blog, and simply change the URL segment from
blog
toblog-v2
to see how it fares in the new editor.Leaving unresolved however as a todo.
changed this line in version 8 of the diff
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
changed the description
added 1 commit
- 9048abd6 - updated to add custom editor_version attribute and digest it
unmarked as a Work In Progress
changed the description
added scoped label and automatically removed label
added 34 commits
-
57e53512...9f5a7a2b - 33 commits from branch
master
- fa17ae44 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
-
57e53512...9f5a7a2b - 33 commits from branch
added 6 commits
-
05f6c931...1359c6d9 - 4 commits from branch
master
- 4e9f4e04 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- c0e11cab - Adding in new files for module
-
05f6c931...1359c6d9 - 4 commits from branch
mentioned in issue minds#864
added 80 commits
-
c0e11cab...c6310433 - 77 commits from branch
master
- 6ea6f47f - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- 55613e00 - WIP changes
- 0849786b - Updated to fix save feat post SSR merge
Toggle commit list-
c0e11cab...c6310433 - 77 commits from branch
marked as a Work In Progress from 55613e00
added 23 commits
-
0849786b...745769a5 - 22 commits from branch
master
- 0c9fcdb1 - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
-
0849786b...745769a5 - 22 commits from branch
- Developer
Getting this error message when I try to edit the url
Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'blog-v2/edit/1074757606632853507' Error: Cannot match any routes. URL Segment: 'blog-v2/edit/1074757606632853507'
To simplify the equation (since we have unleash), let's wire this up so the new blog editor is loaded when we create blogs, edit blogs, etc. We need to show this off to the stakeholders and reduce the level of complexity regarding testing it.
added 24 commits
-
0c9fcdb1...6822f8c9 - 18 commits from branch
master
- da785d0b - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- 276b247c - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- 103fac6a - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- 87cd716f - Temp commit
- f02b893f - Merge branch 'master' of gitlab.com:minds/front into feat/ckeditor-blogs-2333
- dcd0c2eb - Current attempts to bypass SSR, progress check
Toggle commit list-
0c9fcdb1...6822f8c9 - 18 commits from branch