Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 277
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 35
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #698

Closed
Open
Opened 6 months ago by Nicholas Lewis@javanick
Report abuse New issue

(bug): boosts from blocked users are being shown

Summary

When user 'A' blocks user 'B', user 'A' is being served the boosts from user 'B'.

Steps to reproduce

  1. Block a user
  2. Go to Newsfeed
  3. Boosts from that user persist

What is the expected correct behavior?

Boosts should be blocked too.

Relevant logs and/or screenshots

https://www.minds.com/newsfeed/1002258011014168576 https://www.minds.com/newsfeed/1031185109487849472

Edited 3 months ago by Nicholas Lewis

Linked issues
0

  • Discussion 17
  • Designs 0
  • Nicholas Lewis @javanick added Priority::1 - High Product::Boost Type::Bug (Triage) scoped labels 6 months ago

    added scoped labels

  • Nicholas Lewis @javanick added Squad::Green scoped label 6 months ago

    added scoped label

  • Nicholas Lewis @javanick assigned to @edgebal 6 months ago

    assigned to @edgebal

  • Emiliano Balbuena @edgebal unassigned @edgebal 6 months ago

    unassigned @edgebal

  • Ben Hayward
    Ben Hayward @benhayward.ben · 6 months ago
    Developer

    Unable to replicate, although I appreciate the urgency.

    I made a boost locally, approved it, logged into a second user and blocked the boosting account - I no longer see the boost (as the env is scaled down there's only a few posts in the rotation at the moment).

    Open to ideas or suggestions of what may have caused it, what activity types have been boosted etc so that the dots can be connected.

  • Ben Hayward @benhayward.ben added Triage::Unable to Replicate scoped label 6 months ago

    added scoped label

  • Nicholas Lewis
    Nicholas Lewis @javanick · 6 months ago
    Reporter

    We'll have to keep isolating -- lots of users have reported this periodically. I'll add links as I come across them. eg: https://www.minds.com/newsfeed/1007592353455951872

  • Ben Hayward
    Ben Hayward @benhayward.ben · 6 months ago
    Developer

    I think the best option is to please do keep them coming. @brianhatchet's upcoming changed to the RBAC stuff should really make all of this work, quite well I believe (correct me if I'm wrong Brian).

    So I think these bugs should just vanish in a matter of weeks.

  • Ben Hayward @benhayward.ben assigned to @benhayward.ben 6 months ago

    assigned to @benhayward.ben

  • Ben Hayward
    Ben Hayward @benhayward.ben · 6 months ago
    Developer

    This is in this sprint, but whether it gets fixed this sprint is another matter, im gonna have to put effort into trying to replicate. So far no luck.

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 3 6 months ago

    changed weight to 3

  • Nicholas Lewis
    Nicholas Lewis @javanick · 6 months ago
    Reporter

    https://www.minds.com/newsfeed/1008717805662629888

  • Nicholas Lewis @javanick mentioned in issue minds#744 (closed) 5 months ago

    mentioned in issue minds#744 (closed)

  • Nicholas Lewis
    Nicholas Lewis @javanick · 5 months ago
    Reporter

    minds#755 (closed)

  • Nicholas Lewis @javanick mentioned in issue minds#755 (closed) 5 months ago

    mentioned in issue minds#755 (closed)

  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 months ago
    Developer

    minds#755 (comment 206460413)

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label 5 months ago

    added scoped label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 months ago
    Developer

    What do you think @brianhatchet?

    It's definitely happening, but what sort of timeframe are we looking at for the RBAC changes? We could add some front-end validation around the area.

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 5 months ago
    Developer

    Definitely covered in RBAC and definitely has to be done by next sprint. I'll move it onto the next sprint and assign it to myself

  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 months ago
    Developer

    Closing in favour of that then

  • Ben Hayward @benhayward.ben closed 5 months ago

    closed

  • Nicholas Lewis @javanick reopened 4 months ago

    reopened

  • Nicholas Lewis
    Nicholas Lewis @javanick · 4 months ago
    Reporter

    Not fixed

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 months ago
    Developer

    Sorry, should have specified where it will be fixed instead of here.

    &28

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 months ago
    Developer

    Feel free to keep it open if you want to keep an eye on it, but its not a card that I think will be picked up by a developer, as the solution is encompassed in that epic.

  • Nicholas Lewis @javanick changed the description 3 months ago

    changed the description

  • Nicholas Lewis
    Nicholas Lewis @javanick · 3 months ago
    Reporter

    @benhayward.ben @brianhatchet Take a look at this: https://www.minds.com/newsfeed/1031185109487849472

  • Ben Hayward @benhayward.ben unassigned @benhayward.ben 3 months ago

    unassigned @benhayward.ben

  • Luculent
    Luculent @luculent · 2 weeks ago

    Okay, this will happen once in a while for me if I dont REFRESH my browser directly after applying the block.

    Firefox 68.4.1 esr

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 weeks ago
    Developer

    That kind of edge-case would make sense. Without navigating away from the feed also?

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint::02/12 - Bartone Baboon 2 days ago

    changed milestone to %Sprint::02/12 - Bartone Baboon

  • Brian Hatchet :speech_balloon: @brianhatchet removed milestone 2 days ago

    removed milestone

  • Nicholas Lewis
    Nicholas Lewis @javanick · 11 minutes ago
    Reporter

    More reports:

    https://www.minds.com/newsfeed/1074743303341051904 https://www.minds.com/newsfeed/1075072612853043200

    Edited by Nicholas Lewis 6 minutes ago
Please register or sign in to reply
0 Assignees
None
none
Epic
None
None
Milestone
None
Time tracking
No estimate or time spent
None
Due date
None
6
Labels
Priority::1 - High Product::Boost Squad::Green Status::Follow Up Triage::Unable to Replicate Type::Bug (Triage)
3
Weight
3
Confidentiality
Not confidential
Lock issue
Unlocked
5
5 participants
user avatar
user avatar
user avatar
user avatar
user avatar
Reference: minds/engine#698