Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 275
  • Merge Requests 33
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !461

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
Report abuse

Fix/signed wire threshold export 2004

  • Overview 5
  • Commits 11
  • Pipelines 3
  • Changes 1

Closes front#2004

Summary

Users could not view their own and others paywalled content. See the steps on the issue above and try it out for yourself.

Test

  1. Make a paywalled media post (image)
  2. Refresh and check you can click the unlock button and see the image
  3. Go to the media page for the image
  4. Check you can see the image (note the url)
  5. Log out
  6. Visit URL - should not be able to access
  7. Visit the channel that posted the paywalled image, try unlock the post. You should be prompted to send tokens.

Possible areas of regression

To test, I think we should test a variety of different media types, some with paywall and some without, from multiple accounts, and logged out, to ensure that everything is working.

Request to merge fix/signed-wire-threshold-export-2004 into master
Open in Web IDE
Pipeline #117738899 passed for b11c2e3e on fix/signed-wire-threshold-export-2004
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena Rami Albatal Martin Santangelo Marcelo Rivera Olivia Madrid
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#2004

          Deletes source branch

          • Ben Hayward @benhayward.ben added 3 commits 1 day ago

            added 3 commits

            • e6d328ba...dd03087f - 2 commits from branch master
            • 26d89257 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 day ago
            Developer

            Review failed, re-running start pipe.

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 day ago
            Developer

            Took another 2 pipes down, re-running again.

          • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 1 day ago

            added scoped labels

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal · 8 hours ago
            Developer

            Works OK!

          • Emiliano Balbuena @edgebal assigned to @benhayward.ben, @brianhatchet, and @markeharding 8 hours ago

            assigned to @benhayward.ben, @brianhatchet, and @markeharding

          • Mark Harding @markeharding approved this merge request 6 hours ago

            approved this merge request

          • Mark Harding @markeharding added Status::Ready to Merge scoped label and automatically removed Status::Awaiting Review label 6 hours ago

            added scoped label and automatically removed label

          • Ben Hayward
            Ben Hayward @benhayward.ben · 6 hours ago
            Developer

            Note this needs testing on production

            Mark Harding: Need to see if that works on production as its a cdn issue with no session

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 hours ago

            approved this merge request

          • Xander Miller
            Xander Miller @xander-miller · 1 hour ago
            Developer

            I went a bit off the testing path and found that paywalled content no longer works if you don't add an attachment.

            pay_wall_break

          • Ben Hayward @benhayward.ben added 7 commits 37 minutes ago

            added 7 commits

            • 26d89257...6e96d473 - 5 commits from branch master
            • 40839669 - Merge branch 'master' of gitlab.com:minds/engine into fix/signed-wire-threshold-export-2004
            • b11c2e3e - Added in default value for when no image

            Compare with previous version

          Please register or sign in to reply
          3 Assignees
          Mark Harding's avatar
          Brian Hatchet's avatar
          Ben Hayward's avatar
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Yellow Status::Ready to Merge
          Lock merge request
          Unlocked
          9
          9 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!461