Group description not loading, some reports links also aren't clickable
Summary
Cannot load group description, there are also reports that links cannot be clicked in group descriptions. I've included the groups description in this card as I suspect they're related; if it turns out not to be please split this into a new card.
Steps to reproduce
- Visit the Help and Support group
- Try to see description
- If you can see it, try to click link in description
Platform information
reported v3.10.1 iOS IPhone XL
replicated S10, Android 9.0. v3.12.0
What is the current bug behavior?
Cannot load group description, there are also reports that links cannot be clicked in group descriptions.
What is the expected correct behavior?
Should load description, and links should be clickable, ideally warning users of navigation away from the app.
Relevant logs and/or screenshots
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
Let's try changing mobile so it functions like web and calls api/v1/groups/group
added 1 deleted label
moved from minds#941 (moved)
changed the description
added scoped label
- Developer
Hey @benhayward.ben I'm looking at this, currently it's not failing for me (iphone 11 ios 13 sim), may i bother you checking if is failing for you?
- Developer
Tried differents groups and worked fine for me
changed time estimate to 1h
added scoped label and automatically removed label
added scoped label
assigned to @benhayward.ben and unassigned @msantang78 and @juanmsolaro
removed 1 deleted label
- Developer
@benhayward.ben can you reverify this as a bug?
- Developer
Yeah sorry, I had a conversation with Juan about this.
For me, the description does not load at all.
Will add to scheduling after some changes to this card.
added 1 deleted label
removed label
added scoped labels and automatically removed label
changed title from Group description not clickable to Group description not clickable
changed the description
changed weight to 2
changed weight to 4
assigned to @juanmsolaro
unassigned @benhayward.ben
- Developer
looks like our old friend h&s description is causing some issues.
@juanmsolaro please look into this again, since we can reproduce the behavior internally with Ben
added scoped label
changed milestone to %Sprint:01/29 Abatic Aenome
added scoped label and automatically removed label
added scoped label
added scoped label and automatically removed label
- Developer
Hey @brianhatchet, @benhayward.ben! I checked this again. It appears to be the same old problem, endpoint not returning description for that group. I logged the call that get all the groups that user is subscribed to (
api/v1/groups/member
), this is (part of) what we get:0: guid: "100000000000000681" type: "group" name: "Help & Support" brief_description: "" 1: guid: "569521254306951168" type: "group" name: "Minds Developers (Internal)" brief_description: "https://gitlab.com/minds" 2: guid: "881442153276985344" type: "group" name: "Science & Tech & AI" brief_description: "Breaking science and technology and artificial intelligence..."
- Developer
Also checked this same call on the web, and this endpoint is returning brief_description='' for H&S too. The difference is that in the web, when user click on the group to navigate,
api/v1/groups/group/
is called, this endpoint does return brief_description and in the app, when user tap on the group to navigate,api/v2/entities/
is called, this endpoint does NOT return brief_description. added scoped label and automatically removed label
changed the description
added scoped label and automatically removed label
added scoped label and automatically removed label
- Developer
We need to implement a separate loader for groups because api/v2/entities isn't fully hydrating the help and support group. So long we're calling the same endpoints as front, we should get back all
assigned to @brianhatchet and unassigned @juanmsolaro
- Developer
Taking this one back, because @edgebal has a good plan to fix it with resolvers on the backend
- Developer
We should add a new Entity Resolver on
api/v2/entities
that mapsurn:group:123123
to the right entity with all the needed values exported correctly without having a different URL for this kind of objects.