Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 274
  • Merge Requests 33
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !459

Open
Opened 5 days ago by Marcelo Rivera@eiennohi7 of 7 tasks completed7/7 tasks
Report abuse

Deny write permissions for new unverified users

  • Overview 3
  • Commits 14
  • Pipelines 5
  • Changes 17
0/1 thread resolved

closes #1300

Testing

This MR is for showing the blue email confirmation banner when a certain exception is thrown from the backend, which only applies to new registered users that haven't verified their emails.

First use an old user (older than the email confirmation task), and you should be able to do all of the following:

  • Create a post
  • Comment on a post
  • Vote up or down
  • Create group
  • Create blog
  • Upload images
  • Upload movies

Second, create a new user, don't verify its email address, hide the blue email confirmation banner by clicking on the X icon and try to do the same. Each time you try to do any of those, the blue banner should re-appear

Edited 5 days ago by Marcelo Rivera
Request to merge feat/unverified-users-permissions into master
The source branch is 7 commits behind the target branch
Open in Web IDE
Pipeline #115990636 passed with warnings for 334430f8 on feat/unverified-users-permissions
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena Ben Hayward Rami Albatal Martin Santangelo Olivia Madrid
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1300

          Deletes source branch

          • Marcelo Rivera @eiennohi added Squad::Blue Status::BuddyReview scoped labels 5 days ago

            added scoped labels

          • Marcelo Rivera @eiennohi changed the description 5 days ago

            changed the description

          • Marcelo Rivera @eiennohi added 1 commit 5 days ago

            added 1 commit

            • 334430f8 - (fix): updated spec tests for Votes\Manager

            Compare with previous version

          • Olivia Madrid @omadrid added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 1 day ago

            added scoped label and automatically removed label

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 hour ago
            Core/Entities/Actions/Save.php
            63 70 return false;
            64 71 }
            65 72
            73 if (!$this->acl->write($this->entity)) {
            • Mark Harding
              Mark Harding @markeharding · 1 hour ago
              Owner

              Why do we need to add this? ACL should ready be being hit?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding · 1 hour ago
            Owner

            There are a bunch of places that acl write is being used. Lets not duplicate this call unless we have to.

          • Mark Harding
            Mark Harding @markeharding · 1 hour ago
            Owner

            What about subscribing and other interact acl actions?

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Blue Status::Requires Changes
          Lock merge request
          Unlocked
          9
          9 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!459