Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 399
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !776

Open
Opened 2 days ago by Marcelo Rivera@eiennohi
Report abuse

Allow users to permanently hide "share" buttons in settings

  • Overview 6
  • Commits 6
  • Pipelines 5
  • Changes 10
3/3 threads resolved

closes #2462

depends on engine!463

Edited 2 days ago by Marcelo Rivera
Request to merge feat/hide-share-buttons into master
The source branch is 8 commits behind the target branch
Open in Web IDE
Pipeline #117604470 passed with warnings for 92d0dc39 on feat/hide-share-buttons
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Ben Hayward Xander Miller Juan Manuel Solaro Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2462

              Deletes source branch

              • Marcelo Rivera @eiennohi changed the description 2 days ago

                changed the description

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                  Developer
                  Resolved by Marcelo Rivera 50 minutes ago

                  Ok, finally got the review site working with the latest and greatest changes. Unfortunately, the share button disabling is not working

                  • Go to settings
                  • Uncheck share settings
                  • Save
                  • Reload settings, note how it's properly unchecked
                  • Go to the feed
                  • Click on the date of a single entity
                  • Share buttons are still there

                  image

                  Note my settings are confirmed image

                • Marcelo Rivera
                  Last reply by Marcelo Rivera 50 minutes ago
              • Brian Hatchet :speech_balloon: @brianhatchet added Community label 1 day ago

                added label

              • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label 1 day ago

                added scoped label

              • Brian Hatchet :speech_balloon: @brianhatchet removed Community label 1 day ago

                removed label

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 day ago
                Resolved by Marcelo Rivera 2 hours ago
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 1 day ago
                Resolved by Marcelo Rivera 2 hours ago
              • Marcelo Rivera @eiennohi added 4 commits 2 hours ago

                added 4 commits

                • 0fb8b7b6...745769a5 - 2 commits from branch master
                • 7b12c0c0 - Merge remote-tracking branch 'upstream/master' into feat/hide-share-buttons
                • 1214a85a - (fix): it should take the value from the session!

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 2 hours ago

                added 1 commit

                • 92d0dc39 - (fix): it should take the value from the session!

                Compare with previous version

              • Marcelo Rivera @eiennohi resolved all threads 50 minutes ago

                resolved all threads

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!776