Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 398
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !774

Merged
Opened 2 days ago by Ben Hayward@benhayward.ben
Report abuse

Posting before rich-embed completed shows unwanted attachment in new comment underneath #2418

  • Overview 4
  • Commits 9
  • Pipelines 3
  • Changes 3

Summary

Closes #2418 (closed)

Original change on prod is that if you hit enter too quickly after posting a link, it will not post with the rich embed preview, but it will upload in a separate comment below after the comment is posted instead.

Behaviourally,

  • A user should be able to post a link without a rich embed
  • Once the user has posted, they should not see rich-embed in new window.

Steps to test

  1. Log in and go to a post
  2. Copy a link e.g. https://www.google.com/
  3. Paste it into a comment on the post and rapidly hit enter (do not wait for preview response)
  4. it should post without the preview, there should not be a new attachment that loads under the comment.
  5. Repeat with an invalid URL e.g. https://www.ks3fnj3n9.com
  6. Try typing a url
  7. Ensure when you wait for the rich-embed to come back, it does post.

Estimated Regression Scope

The area that this change impacts has been reduced; it should now, in the worst-case scenario mess something up only with rich-embeds.

Request to merge fix/premature-posting-2418 into master
Pipeline #117302737 passed with warnings for b70dd721 on fix/premature-posting-2418
              Merge request approved. Approved by
              Xander Miller Brian Hatchet Emiliano Balbuena
              Rami Albatal Juan Manuel Solaro Marcelo Rivera Martin Santangelo Olivia Madrid

              Merged by Xander Miller 36 minutes ago

              The changes were merged into master with 4d90e094

              The source branch has been deleted

              Closed #2418 (closed)

              Pipeline #117587454 running for 4d90e094 on master
                              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 2 days ago

                                added scoped labels

                              • Ben Hayward @benhayward.ben assigned to @edgebal 2 days ago

                                assigned to @edgebal

                              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                                added 1 commit

                                • 319a9bff - Removed arrow functions

                                Compare with previous version

                              • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 day ago

                                added scoped label and automatically removed label

                              • Brian Hatchet
                                Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                                Developer

                                Needs @edgebal 's dev changes to be merged into master first

                              • Ben Hayward @benhayward.ben added 27 commits 21 hours ago

                                added 27 commits

                                • 319a9bff...745769a5 - 26 commits from branch master
                                • b70dd721 - Merge branch 'master' of gitlab.com:minds/front into fix/premature-posting-2418

                                Compare with previous version

                              • Emiliano Balbuena @edgebal approved this merge request 17 hours ago

                                approved this merge request

                              • Emiliano Balbuena @edgebal assigned to @benhayward.ben, @brianhatchet, and @markeharding and unassigned @edgebal 17 hours ago

                                assigned to @benhayward.ben, @brianhatchet, and @markeharding and unassigned @edgebal

                              • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 17 hours ago

                                added scoped label and automatically removed label

                              • Emiliano Balbuena
                                Emiliano Balbuena @edgebal · 17 hours ago
                                Developer

                                Works OK!

                              • Brian Hatchet
                                Brian Hatchet :speech_balloon: @brianhatchet · 15 hours ago
                                Developer

                                Muuuuuuch cleaner <3

                              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 15 hours ago

                                approved this merge request

                              • Xander Miller
                                Xander Miller @xander-miller · 36 minutes ago
                                Developer

                                Works.

                              • Xander Miller @xander-miller approved this merge request 36 minutes ago

                                approved this merge request

                              • Xander Miller @xander-miller merged 36 minutes ago

                                merged

                              • Xander Miller @xander-miller mentioned in commit 4d90e094 36 minutes ago

                                mentioned in commit 4d90e094

                              Please register or sign in to reply
                              3 Assignees
                              Mark Harding's avatar
                              Brian Hatchet's avatar
                              Ben Hayward's avatar
                              None
                              Milestone
                              None
                              Time tracking
                              No estimate or time spent
                              2
                              Labels
                              Squad::Yellow Status::Awaiting Review
                              Lock merge request
                              Unlocked
                              10
                              10 participants
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              Reference: minds/front!774