Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 399
  • Merge Requests 66
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !772

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
Report abuse

Fix/url hashtag count #2361

  • Overview 2
  • Commits 10
  • Pipelines 3
  • Changes 9

Summary

Closes #2361

** note this MR includes the new installer changes, wait for that before merge **

Added in a check for whether the matching tag is located in a URL.

Steps to Test

This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:

  1. Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
  2. Try a URL with a hashtag in.
  3. Check the hashtags links go through to the correct place.
  4. Try to use the hashtag selector to bypass the limit
  5. Ensure when you add a tag it shows up in the selector

Estimated Regression Scope

This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag

  • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 5 days ago

    added scoped label

  • Ben Hayward @benhayward.ben added 12 commits 8 hours ago

    added 12 commits

    • 0e69ebb8...745769a5 - 11 commits from branch master
    • 547ff898 - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count

    Compare with previous version

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 4 hours ago
    Developer

    Works pretty good for most of the cases I tried, but it seems that it parses the first half of a word that starts with the pound sign as a hashtag as well. Check the image below:

    image

    Edited by Emiliano Balbuena 4 hours ago
  • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label 4 hours ago

    added scoped label

  • Emiliano Balbuena @edgebal assigned to @benhayward.ben 4 hours ago

    assigned to @benhayward.ben

  • Ben Hayward @benhayward.ben added 5 commits 2 hours ago

    added 5 commits

    • 547ff898...28b1e2b3 - 4 commits from branch master
    • 6782df1a - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count

    Compare with previous version

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 hours ago
    Developer

    No worries. Very weird though because it's not happening locally, but definitely is on the sandbox.

    image

    Edited by Ben Hayward 2 hours ago
Please register or sign in to reply
Assignee
Ben Hayward's avatar
Ben Hayward @benhayward.ben
None
Milestone
None
Time tracking
No estimate or time spent
2
Labels
Squad::Yellow Status::Requires Changes
Lock merge request
Unlocked
10
10 participants
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
Reference: minds/front!772