Posting before rich-embed completed shows unwanted attachment in new comment underneath #2418
Summary
Closes #2418
Original change on prod is that if you hit enter too quickly after posting a link, it will not post with the rich embed preview, but it will upload in a separate comment below after the comment is posted instead.
Behaviourally,
- A user should be able to post a link without a rich embed
- Once the user has posted, they should not see rich-embed in new window.
Steps to test
- Log in and go to a post
- Copy a link e.g.
https://www.google.com/
- Paste it into a comment on the post and rapidly hit enter (do not wait for preview response)
- it should post without the preview, there should not be a new attachment that loads under the comment.
- Repeat with an invalid URL e.g.
https://www.ks3fnj3n9.com
- Try typing a url
- Ensure when you wait for the rich-embed to come back, it does post.
Estimated Regression Scope
The area that this change impacts has been reduced; it should now, in the worst-case scenario mess something up only with rich-embeds.
added scoped labels
assigned to @edgebal
added scoped label and automatically removed label
- Developer
Needs @edgebal 's dev changes to be merged into master first
added 27 commits
-
319a9bff...745769a5 - 26 commits from branch
master
- b70dd721 - Merge branch 'master' of gitlab.com:minds/front into fix/premature-posting-2418
-
319a9bff...745769a5 - 26 commits from branch
approved this merge request
assigned to @benhayward.ben, @brianhatchet, and @markeharding and unassigned @edgebal
added scoped label and automatically removed label
- Developer
Works OK!
- Developer
Muuuuuuch cleaner <3
approved this merge request