Fix/url hashtag count #2361
Summary
Closes #2361
** note this MR includes the new installer changes, wait for that before merge **
Added in a check for whether the matching tag is located in a URL.
Steps to Test
This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:
- Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
- Try a URL with a hashtag in.
- Check the hashtags links go through to the correct place.
- Try to use the hashtag selector to bypass the limit
- Ensure when you add a tag it shows up in the selector
Estimated Regression Scope
This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag
added scoped label
added 12 commits
-
0e69ebb8...745769a5 - 11 commits from branch
master
- 547ff898 - Merge branch 'master' of gitlab.com:minds/front into fix/url-hashtag-count
-
0e69ebb8...745769a5 - 11 commits from branch
- Developer
Works pretty good for most of the cases I tried, but it seems that it parses the first half of a word that starts with the pound sign as a hashtag as well. Check the image below:
Edited by Emiliano Balbuena added scoped label
assigned to @benhayward.ben
Please register or sign in to reply