Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 399
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #2361

Closed
Open
Opened 2 months ago by Nicholas Lewis@javanick
Report abuse New issue

Change hashtag detection regex to disregard non-tags.

Summary

A hashtag in the URL within a post will count as one of the 5 permitted hashtags.

Steps to reproduce

  1. Create a post
  2. Insert a link with a hashtag in its URL
  3. Try creating 5 hashtags for that post
  4. Error appears

Relevant logs and/or screenshots

https://www.minds.com/newsfeed/1051859070102446080

Edited 3 weeks ago by Ben Hayward

Linked issues
0

Related merge requests
3
  • Updated URL regex for hashtags to disregard hashes used mid-sentence. #2361
    !751
  • Updated URL regex for hashtags to disregard hashes used mid-sentence. #2361
    !762
  • Fix/url hashtag count #2361
    !772
    Avatar for Ben Hayward
When these merge requests are accepted, this issue will be closed automatically.
  • Discussion 5
  • Designs 0
  • Nicholas Lewis @javanick added Priority::2 - Normal Product::Newsfeed Type::Bug scoped labels 2 months ago

    added scoped labels

  • Ben Hayward @benhayward.ben added Status::Scheduling scoped label 2 months ago

    added scoped label

  • Bill Ottman :dragon_face: @ottman added Priority::1 - High scoped label and automatically removed Priority::2 - Normal label 1 month ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/15 - Youthful Yabby scoped label 1 month ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed due date to January 28, 2020 1 month ago

    changed due date to January 28, 2020

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint::01/15 - Youthful Yabby 1 month ago

    changed milestone to %Sprint::01/15 - Youthful Yabby

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 1 month ago

    assigned to @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 6 1 month ago

    changed weight to 6

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label and automatically removed Status::Scheduling label 1 month ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Yellow scoped label 1 month ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 4 1 month ago

    changed weight to 4

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint:01/29 Abatic Aenome 3 weeks ago

    changed milestone to %Sprint:01/29 Abatic Aenome

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/29 Abatic Aenome scoped label and automatically removed Sprint::01/15 - Youthful Yabby label 3 weeks ago

    added scoped label and automatically removed label

  • bulrush15
    bulrush15 @bulrush15 · 3 weeks ago

    Please ignore all tags that are all digits, like: #1 (closed) #2 #3 (closed) #4 (closed) #666 (closed) #2020 .

    Or maybe ignore all tags that are 3 or less digits.

  • Ben Hayward @benhayward.ben changed title from Hashtags in URLs should not count to Change hashtag detection regex to disregard non-tags. 3 weeks ago

    changed title from to

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 weeks ago
    Developer

    I think we may need to rework the regex a little. I think it should looking for a space, followed by a hashtag.

    I don't think that we can ignore the number ones though because some users may want to use numbers in a valid way for hashtags that have a meaning beyond the number (e.g. #911 (closed), #420 (closed), #666 (closed) or whatever). Maybe there's an argument that there should be more than one character following the tag though.

    @ottman @jotto141 could you please give your thoughts on what the correct behavior here should be?

  • CSharpner
    CSharpner @CSharpner · 3 weeks ago

    You may want to look for a line break in front of the # too. And check if it's the first character in the post as well.

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 3 weeks ago
    Owner

    I agree there should be more than one character following the tag (though autocomplete should immediately display). Also the URL hashtags shouldn't come into play.

    Note: We need to make Enter work to select the hashtag from autocomplete.

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Backlog label 2 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben mentioned in commit 23383abd 1 week ago

    mentioned in commit 23383abd

  • Ben Hayward @benhayward.ben mentioned in merge request !751 (closed) 1 week ago

    mentioned in merge request !751 (closed)

  • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label and automatically removed Status::InProgress label 1 week ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Requires Changes label 1 week ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben mentioned in merge request !762 (closed) 1 week ago

    mentioned in merge request !762 (closed)

  • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::InProgress label 1 week ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::BuddyReview label 5 days ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben mentioned in merge request !772 4 days ago

    mentioned in merge request !772

  • Ben Hayward @benhayward.ben added 4h of time spent at 2020-02-07 4 days ago

    added 4h of time spent at 2020-02-07

  • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::InProgress label 4 days ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::02/12 - Baritone Baboon scoped label and automatically removed Sprint::01/29 Abatic Aenome label 20 hours ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 5 hours ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::Requires Changes label 5 hours ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben assigned to @edgebal 4 hours ago

    assigned to @edgebal

  • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 32 minutes ago

    added scoped label and automatically removed label

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 32 minutes ago
    Developer

    There are some issues with parsing. Check MR.

    cc/ @benhayward.ben

  • Emiliano Balbuena @edgebal unassigned @edgebal 31 minutes ago

    unassigned @edgebal

Please register or sign in to reply
Assignee
Ben Hayward's avatar
Ben Hayward @benhayward.ben
none
Epic
None
Sprint::01/29 Abatic Aenome
Milestone
Sprint::01/29 Abatic Aenome
Time tracking
Spent: 4h
Jan 28, 2020
Due date
Jan 28, 2020
6
Labels
Priority::1 - High Product::Newsfeed Sprint::02/12 - Baritone Baboon Squad::Yellow Status::Requires Changes Type::Bug
4
Weight
4
Confidentiality
Not confidential
Lock issue
Unlocked
8
8 participants
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
Reference: minds/front#2361