Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 399
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !774

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
Report abuse

Posting before rich-embed completed shows unwanted attachment in new comment underneath #2418

  • Overview 2
  • Commits 9
  • Pipelines 3
  • Changes 3

Summary

Closes #2418

Original change on prod is that if you hit enter too quickly after posting a link, it will not post with the rich embed preview, but it will upload in a separate comment below after the comment is posted instead.

Behaviourally,

  • A user should be able to post a link without a rich embed
  • Once the user has posted, they should not see rich-embed in new window.

Steps to test

  1. Log in and go to a post
  2. Copy a link e.g. https://www.google.com/
  3. Paste it into a comment on the post and rapidly hit enter (do not wait for preview response)
  4. it should post without the preview, there should not be a new attachment that loads under the comment.
  5. Repeat with an invalid URL e.g. https://www.ks3fnj3n9.com
  6. Try typing a url
  7. Ensure when you wait for the rich-embed to come back, it does post.

Estimated Regression Scope

The area that this change impacts has been reduced; it should now, in the worst-case scenario mess something up only with rich-embeds.

Request to merge fix/premature-posting-2418 into master
The source branch is 4 commits behind the target branch
Open in Web IDE
Pipeline #117302737 passed with warnings for b70dd721 on fix/premature-posting-2418
              Requires approval from QA. Approved by
              Emiliano Balbuena
              Brian Hatchet Marcelo Rivera Rami Albatal Xander Miller Juan Manuel Solaro
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2418

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 1 day ago

                added scoped labels

              • Ben Hayward @benhayward.ben assigned to @edgebal 1 day ago

                assigned to @edgebal

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • 319a9bff - Removed arrow functions

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 23 hours ago

                added scoped label and automatically removed label

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 23 hours ago
                Developer

                Needs @edgebal 's dev changes to be merged into master first

              • Ben Hayward @benhayward.ben added 27 commits 4 hours ago

                added 27 commits

                • 319a9bff...745769a5 - 26 commits from branch master
                • b70dd721 - Merge branch 'master' of gitlab.com:minds/front into fix/premature-posting-2418

                Compare with previous version

              • Emiliano Balbuena @edgebal approved this merge request 40 minutes ago

                approved this merge request

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben, @brianhatchet, and @markeharding and unassigned @edgebal 40 minutes ago

                assigned to @benhayward.ben, @brianhatchet, and @markeharding and unassigned @edgebal

              • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 39 minutes ago

                added scoped label and automatically removed label

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 39 minutes ago
                Developer

                Works OK!

              Please register or sign in to reply
              3 Assignees
              Mark Harding's avatar
              Brian Hatchet's avatar
              Ben Hayward's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!774