Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 402
  • Merge Requests 67
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !736

Open
Opened 2 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Add ability to upload avatar into onboarding

  • Overview 18
  • Commits 43
  • Pipelines 12
  • Changes 13
5/6 threads resolved

closes #2411

Request to merge feat/add-avatar-uploading into master
Open in Web IDE
Pipeline #117305070 running for e6cdc436 on feat/add-avatar-uploading
              Requires 3 more approvals from Devs, Deployers, and QA.
              Ben Hayward Brian Hatchet Rami Albatal Xander Miller Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2411

              Deletes source branch

              • Marcelo Rivera @eiennohi added Sprint::01/15 - Youthful Yabby Squad::Blue scoped labels 2 weeks ago

                added scoped labels

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 7f3738e4 - (fix): e2e tests

                Compare with previous version

              • Marcelo Rivera @eiennohi added 26 commits 2 weeks ago

                added 26 commits

                • 8f74ef12 - (feat): add "Join the conversation" link to /register
                • f3443338 - (fix): group and channel names overflow issue
                • 3dfbec6e - (feat): export user counts
                • 30323aad - (fix): Disable email confirmation banner in onboarding screens
                • 527ef4d2 - (chore): Remove console.log
                • bacd664d - (fix): redirection
                • 92b8d0e2 - (fix): android app logo should redirect to /mobile
                • ce381393 - (fix): ios safari issue
                • 5fceb0e3 - (fix): terms moving when clicking it issue
                • 67f7c523 - (fix): issue in signup-on-scroll modal
                • a7fe0c56 - (fix): bottom should be 0px
                • 2525660e - Merge remote-tracking branch 'upstream/master' into fix/onboarding-issues
                • 3cb05564 - (fix): button should shrink more than the input
                • a2da2df1 - (fix): double negative in signup-on-scroll
                • 34be9f85 - (fix): made the register form a little smaller in the homepage
                • 51cd7162 - (fix): sizes for progressbar in mobile onboarding
                • 707cd2c9 - (fix): correctly handle username and group name overflow
                • af672c71 - (fix): change detection issues in lists
                • bc3a353c - (fix): use visibility: hidden for hiding re-captcha
                • 31cc0155 - (fix): send export_user_counts to feeds endpoint
                • 3c5dadfe - (fix): changed "members" to "subscribers" for channels list
                • a09ef86d - (fix): use 1y vs 30d for channels and groups suggestions
                • dba729af - (fix): properly center forms on desktop resolutions
                • 91e5f03d - Merge branch 'fix/onboarding-issues' into feat/add-avatar-uploading
                • 0a746866 - (feat): add cancel button
                • fdea3a33 - (fix): e2e tests

                Compare with previous version

                Toggle commit list
              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 550c3a37 - (fix): add missing package-lock.json

                Compare with previous version

              • Xander Miller @xander-miller approved this merge request 2 weeks ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 2 weeks ago
                Developer

                Looks good.

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 weeks ago

                approved this merge request

                • Olivia Madrid
                  Olivia Madrid @omadrid · 2 weeks ago
                  Developer
                  Resolved by Brian Hatchet 1 week ago

                  Does this icon look super facebook-y to anyone else? image

                • Marcelo Rivera Brian Hatchet
                  Last reply by Brian Hatchet 1 week ago
                • Olivia Madrid
                  Olivia Madrid @omadrid · 2 weeks ago
                  Developer
                  Resolved by Marcelo Rivera 1 week ago

                  If I try to upload a file type that isn't an image/gif, I get this screen and am allowed to proceed.

                  image

                  Also - if I had previously uploaded an image and then pressed 'cancel', then tried to upload a non-image file type, then proceed with the screen above, my avatar becomes the image that I had previously tried to cancel.

                  Is that ok?

                  Edited by Olivia Madrid 2 weeks ago
                • Brian Hatchet Marcelo Rivera
                  Last reply by Marcelo Rivera 1 week ago
              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 2 weeks ago

                unapproved this merge request

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
                  Developer
                  Resolved by Brian Hatchet 1 week ago

                  @eiennohi can you verify the avatar upload in Firefox? It crippled my browser trying to open the file select and I just want to be sure it's me

                • Marcelo Rivera Brian Hatchet
                  Last reply by Brian Hatchet 1 week ago
              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • d245c157 - (fix): only accept image types

                Compare with previous version

              • Marcelo Rivera @eiennohi added 21 commits 2 weeks ago

                added 21 commits

                • d245c157...2cb1c987 - 20 commits from branch master
                • 6ee739a3 - Merge branch 'master' into 'feat/add-avatar-uploading'

                Compare with previous version

              • Marcelo Rivera @eiennohi changed target branch from master to production 1 week ago

                changed target branch from master to production

              • Marcelo Rivera @eiennohi added 6 commits 1 week ago

                added 6 commits

                • 6ee739a3...c6474453 - 5 commits from branch production
                • 39e12b1e - Merge remote-tracking branch 'upstream/production' into feat/add-avatar-uploading

                Compare with previous version

              • Marcelo Rivera @eiennohi resolved all threads 1 week ago

                resolved all threads

              • Olivia Madrid
                Olivia Madrid @omadrid started a thread on an old version of the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Marcelo Rivera @eiennohi changed target branch from production to master 1 week ago

                changed target branch from production to master

              • Marcelo Rivera @eiennohi resolved all threads 1 week ago

                resolved all threads

              • Marcelo Rivera @eiennohi added 66 commits 1 week ago

                added 66 commits

                • 39e12b1e...759cb8aa - 64 commits from branch master
                • 21f64b95 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
                • da3ef877 - (fix): remove references to window.Minds

                Compare with previous version

              • Olivia Madrid
                Olivia Madrid @omadrid · 5 days ago
                Developer

                image

              • Olivia Madrid @omadrid approved this merge request 20 hours ago

                approved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 16 hours ago
                Resolved by Marcelo Rivera 42 minutes ago
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 16 hours ago
                  Developer

                  There' also a pretty weird user experience in firefox where the thumbnail preview shifts all the way to the left after I upload. This should be centered where the placeholder is

                • Collapse replies
                • Marcelo Rivera
                  Marcelo Rivera @eiennohi · 41 minutes ago
                  Developer

                  This isn't a firefox-only behavior, and it comes from the plugin itself for images with certain dimensions, so I cannot fix it. For now I removed both the border and the white background so it's not that noticeable. Do you want me to create an issue in the plugin's repo?

                • Please register or sign in to reply
              • Marcelo Rivera @eiennohi added 31 commits 42 minutes ago

                added 31 commits

                • da3ef877...745769a5 - 28 commits from branch master
                • 588c71e7 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
                • 1e0aae5c - (fix): remove console.log
                • e6cdc436 - (fix): remove border and white background from image-cropper

                Compare with previous version

                Toggle commit list
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Sprint::01/15 - Youthful Yabby Squad::Blue
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!736