Add ability to upload avatar into onboarding
closes #2411
added scoped labels
added 26 commits
- 8f74ef12 - (feat): add "Join the conversation" link to /register
- f3443338 - (fix): group and channel names overflow issue
- 3dfbec6e - (feat): export user counts
- 30323aad - (fix): Disable email confirmation banner in onboarding screens
- 527ef4d2 - (chore): Remove console.log
- bacd664d - (fix): redirection
- 92b8d0e2 - (fix): android app logo should redirect to /mobile
- ce381393 - (fix): ios safari issue
- 5fceb0e3 - (fix): terms moving when clicking it issue
- 67f7c523 - (fix): issue in signup-on-scroll modal
- a7fe0c56 - (fix): bottom should be 0px
- 2525660e - Merge remote-tracking branch 'upstream/master' into fix/onboarding-issues
- 3cb05564 - (fix): button should shrink more than the input
- a2da2df1 - (fix): double negative in signup-on-scroll
- 34be9f85 - (fix): made the register form a little smaller in the homepage
- 51cd7162 - (fix): sizes for progressbar in mobile onboarding
- 707cd2c9 - (fix): correctly handle username and group name overflow
- af672c71 - (fix): change detection issues in lists
- bc3a353c - (fix): use visibility: hidden for hiding re-captcha
- 31cc0155 - (fix): send export_user_counts to feeds endpoint
- 3c5dadfe - (fix): changed "members" to "subscribers" for channels list
- a09ef86d - (fix): use 1y vs 30d for channels and groups suggestions
- dba729af - (fix): properly center forms on desktop resolutions
- 91e5f03d - Merge branch 'fix/onboarding-issues' into feat/add-avatar-uploading
- 0a746866 - (feat): add cancel button
- fdea3a33 - (fix): e2e tests
Toggle commit listapproved this merge request
![Xander Miller](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperLooks good.
approved this merge request
![Olivia Madrid](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
DeveloperResolved by Brian HatchetDoes this icon look super facebook-y to anyone else?
- Last reply by Brian Hatchet
- DeveloperResolved by Marcelo Rivera
If I try to upload a file type that isn't an image/gif, I get this screen and am allowed to proceed.
Also - if I had previously uploaded an image and then pressed 'cancel', then tried to upload a non-image file type, then proceed with the screen above, my avatar becomes the image that I had previously tried to cancel.
Is that ok?
Edited by Olivia Madrid - Last reply by Marcelo Rivera
unapproved this merge request
- DeveloperResolved by Brian Hatchet
@eiennohi can you verify the avatar upload in Firefox? It crippled my browser trying to open the file select and I just want to be sure it's me
- Last reply by Brian Hatchet
added 21 commits
-
d245c157...2cb1c987 - 20 commits from branch
master - 6ee739a3 - Merge branch 'master' into 'feat/add-avatar-uploading'
-
d245c157...2cb1c987 - 20 commits from branch
changed target branch from
mastertoproductionadded 6 commits
-
6ee739a3...c6474453 - 5 commits from branch
production - 39e12b1e - Merge remote-tracking branch 'upstream/production' into feat/add-avatar-uploading
-
6ee739a3...c6474453 - 5 commits from branch
resolved all threads
- Resolved by Marcelo Rivera
changed target branch from
productiontomasterresolved all threads
added 66 commits
-
39e12b1e...759cb8aa - 64 commits from branch
master - 21f64b95 - Merge remote-tracking branch 'upstream/master' into feat/add-avatar-uploading
- da3ef877 - (fix): remove references to window.Minds
-
39e12b1e...759cb8aa - 64 commits from branch
- Developer
approved this merge request
24 25 constructor( 26 protected upload: Upload, 27 protected userAvatarService: UserAvatarService, 28 protected router: Router, 29 private configs: ConfigsService 30 ) { 31 this.cdnAssetsUrl = this.configs.get('cdn_assets_url'); 32 } 33 34 uploadPhoto() { 35 this.fileInput.nativeElement.click(); 36 } 37 38 loadImageFailed() { 39 console.log('Load failed'); - Developer
console.log to nowhere
- Developer
There' also a pretty weird user experience in firefox where the thumbnail preview shifts all the way to the left after I upload. This should be centered where the placeholder is
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
