Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 402
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 67
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #2577

Closed
Open
Opened 4 months ago by Mark Harding@markeharding
Report abuse New issue

Exception: user_guid be be sent when getting Update Markers

Sentry Issue: ENGINE-D

Exception: user_guid be be sent
  File "/Core/Notification/UpdateMarkers/Repository.php", line 34, in Minds\Core\Notification\UpdateMarkers\Repository::getList
    throw new \Exception('user_guid be be sent');
  File "/Core/Notification/UpdateMarkers/Manager.php", line 28, in Minds\Core\Notification\UpdateMarkers\Manager::getList
    return $this->repository->getList($opts);
  File "/Core/Groups/Membership.php", line 649, in Minds\Core\Groups\Membership::getGroupsByMember
    'limit' => 1000,
  File "/Controllers/api/v1/groups.php", line 52, in Minds\Controllers\api\v1\groups::get
    'offset' => (int) $_GET['offset'],
  File "/Api/Factory.php", line 70, in Minds\Api\Factory::build
    return $handler->$method($pages);
...
(3 additional frame(s) were not displayed)

We need to check to make sure that we check for an authenticated user before we request update markers

Edited 1 day ago by Brian Hatchet

Linked issues
0

Related merge requests
2
  • Logged out update markers calls #2577
    !777
  • WIP: [Sprint/PinkPanther](fix): Better handling of 'user not found' state at v1/groups/member. #871
    engine !372
When these merge requests are accepted, this issue will be closed automatically.
  • Discussion 6
  • Designs 0
  • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 4 months ago

    added scoped labels

  • Emiliano Balbuena @edgebal changed weight to 2 4 months ago

    changed weight to 2

  • Emiliano Balbuena @edgebal added 1 deleted label 4 months ago

    added 1 deleted label

  • Emiliano Balbuena @edgebal added Priority::2 - Normal Type::Bug scoped labels 4 months ago

    added scoped labels

  • Mark Harding @markeharding assigned to @benhayward.ben 4 months ago

    assigned to @benhayward.ben

  • Mark Harding @markeharding changed time estimate to 1h 4 months ago

    changed time estimate to 1h

  • Mark Harding @markeharding added Status::Backlog scoped label 4 months ago

    added scoped label

  • Mark Harding @markeharding added 1 deleted label and removed 1 deleted label 4 months ago

    added 1 deleted label and removed 1 deleted label

  • Mark Harding @markeharding changed weight to 1 4 months ago

    changed weight to 1

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Backlog label 3 months ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben mentioned in merge request engine!372 (closed) 3 months ago

    mentioned in merge request engine!372 (closed)

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::InProgress label 3 months ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 months ago
    Developer

    Have spent an hour on this but the solution I'm not happy with. Will discuss tomorrow.

  • Ben Hayward @benhayward.ben added 1h of time spent at 2019-10-16 3 months ago

    added 1h of time spent at 2019-10-16

  • Ben Hayward @benhayward.ben removed Status::Follow Up label 3 months ago

    removed label

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label 3 months ago

    added scoped label

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::InProgress label 3 months ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Follow Up label 3 months ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::InProgress label 3 months ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben removed 1 deleted label 3 months ago

    removed 1 deleted label

  • Ben Hayward @benhayward.ben added 1 deleted label 3 months ago

    added 1 deleted label

  • Ben Hayward @benhayward.ben removed 1 deleted label 3 months ago

    removed 1 deleted label

  • Ben Hayward @benhayward.ben added 1 deleted label 3 months ago

    added 1 deleted label

  • Ben Hayward @benhayward.ben removed Status::Follow Up label 3 months ago

    removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 months ago
    Developer

    This is going to take some lower level changes than just checking for the user at the start of the failing endpoint.

  • Ben Hayward @benhayward.ben changed time estimate to 3h 3 months ago

    changed time estimate to 3h

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 months ago
    Developer

    Will discuss through the week.

  • Ben Hayward @benhayward.ben added 1 deleted label and removed 1 deleted label 2 months ago

    added 1 deleted label and removed 1 deleted label

  • Ben Hayward @benhayward.ben unassigned @benhayward.ben 2 months ago

    unassigned @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label and removed 1 deleted label 2 months ago

    added 1 deleted label and removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 2 months ago

    assigned to @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 3 2 months ago

    changed weight to 3

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label 2 months ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/01 - Xerothermic Xenarthra scoped label 1 month ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet removed 1 deleted label 1 month ago

    removed 1 deleted label

  • Ben Hayward @benhayward.ben removed Status::InProgress label 1 month ago

    removed label

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint::01/01 - Xerothermic Xenartha 1 month ago

    changed milestone to %Sprint::01/01 - Xerothermic Xenartha

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/15 - Youthful Yabby scoped label and automatically removed Sprint::01/01 - Xerothermic Xenarthra label 4 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label 3 weeks ago

    added scoped label

  • Ben Hayward @benhayward.ben removed Status::Follow Up label 3 weeks ago

    removed label

  • Ben Hayward @benhayward.ben added Status::Backlog scoped label 2 weeks ago

    added scoped label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 weeks ago
    Developer

    This is going to require a discussion with @brianhatchet and @edgebal because we can add a check to the Factory, but I believe this is something that has existed previously and was removed.

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::Backlog label 2 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/29 Abatic Aenome scoped label and automatically removed Sprint::01/15 - Youthful Yabby label 2 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 day ago

    changed the description

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::02/12 - Baritone Baboon scoped label and automatically removed Sprint::01/29 Abatic Aenome label 1 day ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label and automatically removed Status::Follow Up label 1 day ago

    added scoped label and automatically removed label

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
    Developer

    @benhayward.ben I updated the case with the appropriate fix

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Backlog label 1 hour ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben changed milestone to %Sprint::01/01 - Xerothermic Xenartha 1 hour ago

    changed milestone to %Sprint::01/01 - Xerothermic Xenartha

  • Ben Hayward @benhayward.ben changed weight to 3 1 hour ago

    changed weight to 3

  • Ben Hayward @benhayward.ben moved from engine#871 (moved) 1 hour ago

    moved from engine#871 (moved)

  • Ben Hayward @benhayward.ben mentioned in merge request !777 56 minutes ago

    mentioned in merge request !777

  • Ben Hayward @benhayward.ben added 15m of time spent at 2020-02-12 56 minutes ago

    added 15m of time spent at 2020-02-12

  • Ben Hayward
    Ben Hayward @benhayward.ben · 56 minutes ago
    Developer

    Made an MR for that, assuming you added in the line

    We need to check to make sure that we check for an authenticated user before we request update markers

  • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::InProgress label 56 minutes ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 3 minutes ago

    added scoped label and automatically removed label

Please register or sign in to reply
Assignee
Ben Hayward's avatar
Ben Hayward @benhayward.ben
none
Epic
None
Sprint::01/01 - Xerothermic Xenartha
Milestone
Sprint::01/01 - Xerothermic Xenartha
Time tracking
Spent 15m
Est 3h
None
Due date
None
6
Labels
Priority::2 - Normal Product::Platform Sprint::02/12 - Baritone Baboon Squad::Yellow Status::Requires Changes Type::Bug
3
Weight
3
Confidentiality
Not confidential
Lock issue
Unlocked
4
4 participants
user avatar
user avatar
user avatar
user avatar
Reference: minds/front#2577